From 806d30a0649927577bc382a539acd25ff3685800 Mon Sep 17 00:00:00 2001 From: "Savannah Savings (CTO)" Date: Tue, 9 Jun 2026 08:30:56 +0000 Subject: [PATCH] fix(ci): resolve uat lint + typecheck failures (CAR-1340) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - cache.py:38: Add explicit type annotation for redis.get() return value to resolve mypy no-any-return - rate_limit.py: Remove duplicate forward-declaration block (dead code, mypy no-redef) - conftest.py: Remove one excess blank line to satisfy ruff format check All three fixes verified locally: ruff check ✅, ruff format ✅, mypy ✅ Co-Authored-By: Paperclip --- src/cartsnitch_api/cache.py | 2 +- src/cartsnitch_api/middleware/rate_limit.py | 4 ---- tests/conftest.py | 1 - 3 files changed, 1 insertion(+), 6 deletions(-) diff --git a/src/cartsnitch_api/cache.py b/src/cartsnitch_api/cache.py index 6766a8c..836bfb8 100644 --- a/src/cartsnitch_api/cache.py +++ b/src/cartsnitch_api/cache.py @@ -35,7 +35,7 @@ class CacheClient: async def get(self, key: str) -> str | None: if not self._client: return None - value = await self._client.get(key) + value: str | bytes | None = await self._client.get(key) if value is None: return None if isinstance(value, bytes): diff --git a/src/cartsnitch_api/middleware/rate_limit.py b/src/cartsnitch_api/middleware/rate_limit.py index c6d5f21..e736537 100644 --- a/src/cartsnitch_api/middleware/rate_limit.py +++ b/src/cartsnitch_api/middleware/rate_limit.py @@ -121,10 +121,6 @@ if settings.rate_limit_redis_enabled: logger.warning("Failed to connect to Redis for rate limiting, using in-memory: %s", e) _use_redis = False -_public_limiter: RateLimitBackend -_auth_limiter: RateLimitBackend -_auth_strict_limiter: RateLimitBackend - if _use_redis and _redis_client: _public_limiter = RedisSlidingWindow( _redis_client, settings.rate_limit_requests, settings.rate_limit_window_seconds diff --git a/tests/conftest.py b/tests/conftest.py index 1958022..133f726 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -117,7 +117,6 @@ def _register_event_listeners(): event.listen(cls, "before_insert", _set_timestamp_defaults) - TEST_JWT_SECRET = secrets.token_urlsafe(32) TEST_SERVICE_KEY = secrets.token_urlsafe(32) TEST_FERNET_KEY = "7reF42nmTwbdN21PBoubGp7h_FU8qSimstmlaMLoRK8="