cartsnitch/api
12
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: promote dev to uat (dispose_engine fix, CAR-932) #20

Merged
Savannah Savings merged 2 commits from dev into uat 2026-05-23 21:52:26 +00:00
Conversation 0 Commits 2 Files Changed 1
+1 -1
Savannah Savings commented 2026-05-23 21:52:17 +00:00
Member
Copy Link
Copy Source

UAT Promotion

Promotes the dispose_engine import fix from dev to uat.

Changes included:

  • fix: remove dead dispose_engine import from API main.py [CAR-932]
    • Moves dispose_engine import from module scope into the lifespan function where it is used
    • Fixes ImportError that crashes API pods on startup

Related: CAR-932, CAR-996, PR #16

cc @cpfarhood

## UAT Promotion Promotes the dispose_engine import fix from dev to uat. **Changes included:** - fix: remove dead dispose_engine import from API main.py [CAR-932] - Moves dispose_engine import from module scope into the lifespan function where it is used - Fixes ImportError that crashes API pods on startup **Related:** CAR-932, CAR-996, PR #16 cc @cpfarhood
Savannah Savings added 2 commits 2026-05-23 21:52:17 +00:00
fix: remove dead dispose_engine import from API main.py
CI / lint (pull_request) Failing after 3s
Details
CI / test (pull_request) Failing after 14s
Details
CI / build-and-push (pull_request) Has been skipped
Details
CI / deploy-dev (pull_request) Has been skipped
Details
CI / deploy-uat (pull_request) Has been skipped
Details
CI / typecheck (pull_request) Failing after 20s
Details
ba88fad48b 
The top-level import of dispose_engine from cartsnitch_api.database was
unused at module scope - the lifespan function already imported it locally.
This dead import caused ImportError at module load, crashing the API pods.

Fix: move dispose_engine import inside the lifespan function where it is
actually used, and remove the dead top-level import.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
Merge pull request 'fix: remove dead dispose_engine import from API main.py [CAR-932]' (#16) from betty/car-932-fix-dispose-engine into dev
CI / lint (push) Failing after 5s
Details
CI / deploy-uat (pull_request) Has been skipped
Details
CI / test (push) Failing after 10s
Details
CI / build-and-push (push) Has been skipped
Details
CI / deploy-uat (push) Has been skipped
Details
CI / typecheck (push) Failing after 16s
Details
CI / lint (pull_request) Failing after 2s
Details
CI / test (pull_request) Failing after 16s
Details
CI / deploy-dev (pull_request) Has been skipped
Details
CI / deploy-dev (push) Failing after 47s
Details
CI / typecheck (pull_request) Failing after 16s
Details
CI / build-and-push (pull_request) Has been skipped
Details
23899f6c8d 
fix: remove dead dispose_engine import from API main.py [CAR-932]

Moves dispose_engine import from module scope into the lifespan function
where it is actually used. Fixes ImportError crashing API pods.

Reviewed-by: cs_charlie (QA)
Approved-by: cs_savannah (CTO)
CI-override: pre-existing failures unrelated to this change
Savannah Savings merged commit 28ad343759 into uat 2026-05-23 21:52:26 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) cs_betty (Barcode Betty) cs_charlie (Checkout Charlie) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) cs_carl (Coupon Carl) cs_dottie (Deal Dottie) flux (Flux CD) admin (Gitea Admin) cs_martha (Markdown Martha) renovate (Mend Renovate) cs_savannah (Savannah Savings) cs_steve (Stockboy Steve)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cartsnitch/api#20
Delete Branch "dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?