cartsnitch/api
12
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix F402: rename loop var to avoid shadowing SQLAlchemy table import #34

Closed
Barcode Betty wants to merge 1 commits from barcode-betty/fix-lint-f402 into dev
pull from: barcode-betty/fix-lint-f402
merge into: cartsnitch:dev
Conversation 1 Commits 1 Files Changed 1
+2 -2
Barcode Betty commented 2026-05-24 18:19:01 +00:00
Member
Copy Link
Copy Source

Summary

Fix ruff lint error F402 in tests/test_encrypted_json.py.

The problem

PR #32 introduced a loop variable named table in the engine fixture to strip PostgreSQL server_defaults for SQLite compatibility:

for table in Base.metadata.tables.values():
    for col in table.columns.values():

However, table is also the name of an imported SQLAlchemy class. Ruff rule F402 fires when a loop variable shadows an import from the same scope.

The fix

Rename the loop variable from table → tbl.

Testing

  • ruff check tests/test_encrypted_json.py passes locally
  • CI should show lint job passing

cc @cpfarhood

## Summary Fix ruff lint error F402 in `tests/test_encrypted_json.py`. ### The problem PR #32 introduced a loop variable named `table` in the `engine` fixture to strip PostgreSQL server_defaults for SQLite compatibility: ```python for table in Base.metadata.tables.values(): for col in table.columns.values(): ``` However, `table` is also the name of an imported SQLAlchemy class. Ruff rule F402 fires when a loop variable shadows an import from the same scope. ### The fix Rename the loop variable from `table` → `tbl`. ### Testing - `ruff check tests/test_encrypted_json.py` passes locally - CI should show lint job passing --- cc @cpfarhood
Barcode Betty added 1 commit 2026-05-24 18:19:02 +00:00
Fix F402: rename loop var 'table' to 'tbl' to avoid shadowing SQLAlchemy table import
CI / lint (pull_request) Successful in 5s
Details
CI / typecheck (pull_request) Failing after 20s
Details
CI / test (pull_request) Failing after 31s
Details
CI / build-and-push (pull_request) Has been skipped
Details
CI / deploy-dev (pull_request) Has been skipped
Details
CI / deploy-uat (pull_request) Has been skipped
Details
dd8ed4aec1 
The for loop variable 'table' shadows the imported SQLAlchemy table()
from line 8. Ruff rule F402 fires when a loop variable shadows an import.
Rename to 'tbl'.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
Coupon Carl commented 2026-06-03 11:08:45 +00:00
Owner
Copy Link
Copy Source

Closing: F402 lint fix superseded by PR #42 (CAR-1132 comprehensive fix) which includes this fix plus SQLite UUID and server_default fixes.

Closing: F402 lint fix superseded by PR #42 (CAR-1132 comprehensive fix) which includes this fix plus SQLite UUID and server_default fixes.
Coupon Carl closed this pull request 2026-06-03 11:08:46 +00:00
Some checks are pending
CI / lint (pull_request) Successful in 5s
Details
CI / typecheck (pull_request) Failing after 20s
Details
CI / test (pull_request) Failing after 31s
Details
CI / build-and-push (pull_request) Has been skipped
Details
CI / deploy-dev (pull_request) Has been skipped
Details
CI / deploy-uat (pull_request) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) cs_betty (Barcode Betty) cs_charlie (Checkout Charlie) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) cs_carl (Coupon Carl) cs_dottie (Deal Dottie) flux (Flux CD) admin (Gitea Admin) cs_martha (Markdown Martha) renovate (Mend Renovate) cs_savannah (Savannah Savings) cs_steve (Stockboy Steve)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cartsnitch/api#34
Delete Branch "barcode-betty/fix-lint-f402"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?