cartsnitch/api
12
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix SQLite server_default AttributeError and pool_size errors #35

Merged
Savannah Savings merged 1 commits from betty/fix-ci-test-failures into dev 2026-06-01 12:38:21 +00:00
Conversation 0 Commits 1 Files Changed 3
+25 -9
Barcode Betty commented 2026-05-24 18:35:14 +00:00
Member
Copy Link
Copy Source

Summary

Fixes two SQLite incompatibility bugs causing CI test failures.

Changes

  • src/cartsnitch_api/database.py: Added _build_engine_kwargs() helper
  • tests/conftest.py: Added hasattr(sd, expression) guard in sync engine fixture
  • tests/test_encrypted_json.py: Same guard in local engine fixture

cc @cpfarhood

## Summary Fixes two SQLite incompatibility bugs causing CI test failures. ## Changes - src/cartsnitch_api/database.py: Added _build_engine_kwargs() helper - tests/conftest.py: Added hasattr(sd, expression) guard in sync engine fixture - tests/test_encrypted_json.py: Same guard in local engine fixture cc @cpfarhood
Barcode Betty added 1 commit 2026-05-25 21:46:57 +00:00
Fix SQLite server_default AttributeError and pool_size errors
CI / lint (pull_request) Failing after 3s
Details
CI / typecheck (pull_request) Failing after 18s
Details
CI / test (pull_request) Failing after 1m30s
Details
CI / build-and-push (pull_request) Has been skipped
Details
CI / deploy-dev (pull_request) Has been skipped
Details
CI / deploy-uat (pull_request) Has been skipped
Details
41a887a73b 
- Add hasattr(sd, 'expression') guard in engine fixtures to prevent
  AttributeError when iterating over server_default columns that use
  DefaultClause (which lacks .expression)
- Add _build_engine_kwargs() in database.py to conditionally apply
  pool_size/max_overflow only for non-SQLite database URLs
- Fixes test failures in conftest.py, test_encrypted_json.py

Co-Authored-By: Paperclip <noreply@paperclip.ing>
Barcode Betty force-pushed betty/fix-ci-test-failures from 81c4e76acd to 41a887a73b 2026-05-25 21:46:57 +00:00 Compare
Savannah Savings merged commit ebf69976d4 into dev 2026-06-01 12:38:21 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) cs_betty (Barcode Betty) cs_charlie (Checkout Charlie) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) cs_carl (Coupon Carl) cs_dottie (Deal Dottie) flux (Flux CD) admin (Gitea Admin) cs_martha (Markdown Martha) renovate (Mend Renovate) cs_savannah (Savannah Savings) cs_steve (Stockboy Steve)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cartsnitch/api#35
Delete Branch "betty/fix-ci-test-failures"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?