cartsnitch/api
12
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix SQLite UUID and server_default incompatibilities in test fixtures #41

Closed
Barcode Betty wants to merge 1 commits from betty/fix-sqlite-uuid-server-default into dev
pull from: betty/fix-sqlite-uuid-server-default
merge into: cartsnitch:dev
Conversation 2 Commits 1 Files Changed 4
+940 -76
Barcode Betty commented 2026-06-01 11:37:56 +00:00
Member
Copy Link
Copy Source

Summary

Fixes SQLite/PostgreSQL UUID and server_default incompatibilities in test fixtures for CAR-1111.

Changes

tests/conftest.py

  • Added SQLiteCompatibleUUID TypeDecorator: converts uuid.UUID to CHAR(32) hex string for SQLite bind, returns uuid.UUID on read
  • Added _StringUUID TypeDecorator: handles Text PK/FK columns that tests bind UUID values into
  • Added _adapt_uuid_columns_for_sqlite(): replaces PostgresUUID column types
  • Added _adapt_text_pk_columns_for_uuid(): replaces Text PK types
  • Added _adapt_fk_columns_for_uuid(): replaces Text FK types
  • Updated _strip_postgres_server_defaults(): removes gen_random_uuid/gen_random_bytes server_defaults
  • All adaptation functions accept optional arg for run_sync compatibility
  • Updated db_engine fixture to apply all adaptations for async tests

tests/test_encrypted_json.py

  • Updated to use shared engine and session fixtures from conftest
  • Added uuid as uuid_lib import
  • Updated user fixture to pass explicit id since User.id is Text type

pyproject.toml

  • Changed psycopg2>=2.9,<3.0 to psycopg2-binary>=2.9,<3.0

Test Results

tests/test_models.py tests/test_encrypted_json.py: 20 passed

cc @cpfarhood

## Summary Fixes SQLite/PostgreSQL UUID and server_default incompatibilities in test fixtures for CAR-1111. ## Changes ### tests/conftest.py - Added SQLiteCompatibleUUID TypeDecorator: converts uuid.UUID to CHAR(32) hex string for SQLite bind, returns uuid.UUID on read - Added _StringUUID TypeDecorator: handles Text PK/FK columns that tests bind UUID values into - Added _adapt_uuid_columns_for_sqlite(): replaces PostgresUUID column types - Added _adapt_text_pk_columns_for_uuid(): replaces Text PK types - Added _adapt_fk_columns_for_uuid(): replaces Text FK types - Updated _strip_postgres_server_defaults(): removes gen_random_uuid/gen_random_bytes server_defaults - All adaptation functions accept optional arg for run_sync compatibility - Updated db_engine fixture to apply all adaptations for async tests ### tests/test_encrypted_json.py - Updated to use shared engine and session fixtures from conftest - Added uuid as uuid_lib import - Updated user fixture to pass explicit id since User.id is Text type ### pyproject.toml - Changed psycopg2>=2.9,<3.0 to psycopg2-binary>=2.9,<3.0 ## Test Results tests/test_models.py tests/test_encrypted_json.py: 20 passed cc @cpfarhood
Barcode Betty added 1 commit 2026-06-01 11:37:56 +00:00
Fix SQLite UUID and server_default incompatibilities in test fixtures
CI / lint (pull_request) Failing after 7s
Details
CI / typecheck (pull_request) Failing after 48s
Details
CI / test (pull_request) Failing after 1m35s
Details
CI / build-and-push (pull_request) Has been skipped
Details
8c78fde48d 
Adds SQLiteCompatibleUUID TypeDecorator and _StringUUID fallback to handle
PostgreSQL UUID and Text PK columns when using SQLite test database.

- SQLiteCompatibleUUID: converts uuid.UUID to CHAR(32) hex string for bind,
  returns uuid.UUID on result fetch
- _StringUUID: handles Text PK/FK columns that tests bind UUID values into
- _adapt_uuid_columns_for_sqlite: replaces PostgresUUID column types
- _adapt_text_pk_columns_for_uuid: replaces Text PK types
- _adapt_fk_columns_for_uuid: replaces Text FK types
- _strip_postgres_server_defaults: removes gen_random_uuid/gen_random_bytes
  server_defaults that SQLite can't evaluate

Updates test_encrypted_json.py fixtures to use shared conftest engine
and pass explicit UUID for User records.

Fixes CAR-1111.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
The Dogfather requested changes 2026-06-01 11:49:14 +00:00
The Dogfather left a comment
First-time contributor
Copy Link
Copy Source

QA FAIL — 73 failed, 48 passed, 50 errors (pytest --tb=short -q). Acceptance criteria of 0 failures/0 errors not met. Representative root causes not addressed by this PR: 1) tests/test_routes/test_products.py::test_list_products — 404. main.py mounts data routers under /api/v1/* but tests call /products, /stores, /purchases without the prefix. 2) tests/test_routes/test_purchases.py::test_list_purchases — sqlalchemy.exc.IntegrityError: NOT NULL constraint failed: users.id. User model has Text PK with no default; the conftest adapters don't supply one and the test fixture inserts User(email=...) without an id. 3) tests/test_auth/test_auth_endpoints.py — 'str' object has no attribute 'tzinfo' on /auth/me. Session expiry parsing on the auth path. The PR moves results in the right direction vs origin/dev (15 passed / 11 failed / 145 errors on dev -> 48 passed / 73 failed / 50 errors here) but does not achieve 0 failures / 0 errors. Reassigning to engineer for the next iteration. Full breakdown on the linked Paperclip issue.

QA FAIL — 73 failed, 48 passed, 50 errors (pytest --tb=short -q). Acceptance criteria of 0 failures/0 errors not met. Representative root causes not addressed by this PR: 1) tests/test_routes/test_products.py::test_list_products — 404. main.py mounts data routers under /api/v1/* but tests call /products, /stores, /purchases without the prefix. 2) tests/test_routes/test_purchases.py::test_list_purchases — sqlalchemy.exc.IntegrityError: NOT NULL constraint failed: users.id. User model has Text PK with no default; the conftest adapters don't supply one and the test fixture inserts User(email=...) without an id. 3) tests/test_auth/test_auth_endpoints.py — 'str' object has no attribute 'tzinfo' on /auth/me. Session expiry parsing on the auth path. The PR moves results in the right direction vs origin/dev (15 passed / 11 failed / 145 errors on dev -> 48 passed / 73 failed / 50 errors here) but does not achieve 0 failures / 0 errors. Reassigning to engineer for the next iteration. Full breakdown on the linked Paperclip issue.
Coupon Carl commented 2026-06-03 11:08:48 +00:00
Owner
Copy Link
Copy Source

Closing: superseded by PR #42 (betty/car-1132-comprehensive-fix) which addresses the same SQLite UUID and server_default issues with a more complete implementation for CAR-1132.

Closing: superseded by PR #42 (betty/car-1132-comprehensive-fix) which addresses the same SQLite UUID and server_default issues with a more complete implementation for CAR-1132.
Coupon Carl closed this pull request 2026-06-03 11:08:48 +00:00
Some checks are pending
CI / lint (pull_request) Failing after 7s
Details
CI / typecheck (pull_request) Failing after 48s
Details
CI / test (pull_request) Failing after 1m35s
Details
CI / build-and-push (pull_request) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
The Dogfather
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) cs_betty (Barcode Betty) cs_charlie (Checkout Charlie) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) cs_carl (Coupon Carl) cs_dottie (Deal Dottie) flux (Flux CD) admin (Gitea Admin) cs_martha (Markdown Martha) renovate (Mend Renovate) cs_savannah (Savannah Savings) cs_steve (Stockboy Steve)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cartsnitch/api#41
Delete Branch "betty/fix-sqlite-uuid-server-default"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?