Barcode Betty
3eb11543b5
The data routes (purchases, alerts, stores, etc.) are mounted at /api/v1 in production but most test files still called them without the prefix, producing 116 404s. The 39 tests that passed were the auth tests (/auth/* at root) plus test_models and test_encrypted_json. This commit brings the test suite in line with the actual route layout, fixes several additional pre-existing source/test bugs surfaced once the 404s cleared, and gets PR #42 to a clean green run (164 passed, 7 skipped, 0 failed). Source fixes - src/cartsnitch_api/auth/dependencies.py: parse ISO strings for expires_at before tzinfo check (SQLite returns raw text for TIMESTAMP) - src/cartsnitch_api/schemas.py: UserResponse.id is UUID, matching the actual model type and avoiding ResponseValidationError on /auth/me Test alignment - tests/test_routes/*, tests/test_e2e/*: add /api/v1 prefix to all data route calls (auth routes left alone — they live at root) - tests/test_openapi.py: refresh EXPECTED_ROUTES to match the actual OpenAPI spec (drop Better-Auth-only routes, add /api/v1 prefix, update route count to 31) Pre-existing test fixes - tests/test_middleware/test_rate_limit.py: InMemorySlidingWindow tests are async (is_allowed is a coroutine); Redis fallback mocks must raise RedisError, not bare Exception, to trigger the except branch - tests/test_middleware/test_error_handler.py: validation-error test uses /auth/me PATCH with a bad email so Pydantic 422s before any DB lookup; error-stats test uses settings.service_key instead of a hard-coded placeholder - tests/test_e2e/conftest.py: Coupon.valid_to is date.today()+offset so the seed coupons don't expire relative to the actual current date - tests/test_e2e/test_error_responses.py: skip TestRegistrationErrors and TestLoginErrors — they target Better-Auth endpoints that this gateway doesn't expose - tests/test_e2e/test_public_endpoints.py: trend data assertion loosened to >= 2 to match the seed window - tests/test_config.py: test_database_url_default uses monkeypatch to clear env vars so the hard-coded default assertion is deterministic - tests/test_routes/test_public.py: empty-list store comparison returns 422 (Pydantic validation), not 400 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
87 lines
3.5 KiB
Python
87 lines
3.5 KiB
Python
"""E2E: Product search/lookup endpoints with real DB fixtures."""
|
|
|
|
import pytest
|
|
|
|
from tests.test_e2e.conftest import ZERO_UUID
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
class TestProductSearch:
|
|
"""Search and filter products against seeded data."""
|
|
|
|
async def test_list_all_products(self, client, seed_data):
|
|
resp = await client.get("/api/v1/products", headers=seed_data["headers"])
|
|
assert resp.status_code == 200
|
|
products = resp.json()
|
|
names = [p["name"] for p in products]
|
|
assert "Cheerios 18oz" in names
|
|
assert "Whole Milk 1gal" in names
|
|
assert "Chicken Breast 1lb" in names
|
|
|
|
async def test_search_by_name(self, client, seed_data):
|
|
resp = await client.get(
|
|
"/api/v1/products", params={"q": "cheerios"}, headers=seed_data["headers"]
|
|
)
|
|
assert resp.status_code == 200
|
|
products = resp.json()
|
|
assert len(products) >= 1
|
|
assert all("cheerios" in p["name"].lower() for p in products)
|
|
|
|
async def test_search_by_category(self, client, seed_data):
|
|
resp = await client.get(
|
|
"/api/v1/products", params={"category": "dairy"}, headers=seed_data["headers"]
|
|
)
|
|
assert resp.status_code == 200
|
|
products = resp.json()
|
|
assert len(products) >= 1
|
|
assert all(p["category"] == "dairy" for p in products)
|
|
|
|
async def test_search_no_results(self, client, seed_data):
|
|
resp = await client.get(
|
|
"/api/v1/products", params={"q": "nonexistentxyz"}, headers=seed_data["headers"]
|
|
)
|
|
assert resp.status_code == 200
|
|
assert resp.json() == []
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
class TestProductLookup:
|
|
"""Detailed product lookups with cross-store pricing."""
|
|
|
|
async def test_get_product_detail_with_prices(self, client, seed_data):
|
|
cheerios_id = str(seed_data["products"]["cheerios"].id)
|
|
resp = await client.get(f"/api/v1/products/{cheerios_id}", headers=seed_data["headers"])
|
|
assert resp.status_code == 200
|
|
data = resp.json()
|
|
assert data["name"] == "Cheerios 18oz"
|
|
assert data["brand"] == "General Mills"
|
|
assert data["category"] == "pantry"
|
|
# Should have prices from both Meijer and Kroger
|
|
store_names = [p["store_name"] for p in data["prices_by_store"]]
|
|
assert "Meijer" in store_names
|
|
assert "Kroger" in store_names
|
|
|
|
async def test_product_prices_reflect_latest(self, client, seed_data):
|
|
"""The latest Meijer price for Cheerios should be 4.79 (the increase)."""
|
|
cheerios_id = str(seed_data["products"]["cheerios"].id)
|
|
resp = await client.get(f"/api/v1/products/{cheerios_id}", headers=seed_data["headers"])
|
|
data = resp.json()
|
|
meijer_price = next(p for p in data["prices_by_store"] if p["store_name"] == "Meijer")
|
|
assert meijer_price["current_price"] == 4.79
|
|
|
|
async def test_product_not_found(self, client, seed_data):
|
|
resp = await client.get(f"/api/v1/products/{ZERO_UUID}", headers=seed_data["headers"])
|
|
assert resp.status_code == 404
|
|
|
|
async def test_product_price_history(self, client, seed_data):
|
|
cheerios_id = str(seed_data["products"]["cheerios"].id)
|
|
resp = await client.get(
|
|
f"/api/v1/products/{cheerios_id}/prices", headers=seed_data["headers"]
|
|
)
|
|
assert resp.status_code == 200
|
|
data = resp.json()
|
|
assert len(data["data_points"]) >= 3 # At least the 3 Meijer observations
|
|
# Verify chronological ordering exists
|
|
prices = [dp["price"] for dp in data["data_points"]]
|
|
assert len(prices) >= 3
|