CartSnitch Engineer Bot
18ff5795ac
- Revert auth/dependencies.py, auth/routes.py, services/auth.py, schemas.py to Better-Auth session-cookie auth (removed JWT register/login/refresh) - Preserve GET /auth/me/email-in-address endpoint - Fix UUIDString TypeDecorator: process_result_value returns uuid.UUID (not str) so SQLAlchemy 2.0 sentinel tracking matches UUID-to-UUID - Fix seed_data fixture: look up real user_id from session token via sessions table; purchases now reference actual user FK - Update purchase_data fixture to use session-cookie auth - Update test_auth_endpoints, test_auth_validation to cookie-based tests - Remove TestRegistrationErrors and TestLoginErrors (no longer applicable) - Update test_openapi.py expected routes and count - Update test_error_handler.py to use PATCH /auth/me validation Co-Authored-By: Paperclip <noreply@paperclip.ing>
56 lines
1.7 KiB
Python
56 lines
1.7 KiB
Python
"""Tests for structured error responses and error monitoring."""
|
|
|
|
import pytest
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_404_returns_structured_error(client):
|
|
"""Non-existent route should return structured error."""
|
|
resp = await client.get("/nonexistent")
|
|
assert resp.status_code == 404
|
|
body = resp.json()
|
|
assert "detail" in body
|
|
assert "code" in body
|
|
assert body["code"] == "NOT_FOUND"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_validation_error_returns_422_with_field_errors(client, auth_headers):
|
|
"""Invalid request body should return structured validation errors."""
|
|
resp = await client.patch(
|
|
"/auth/me",
|
|
headers=auth_headers,
|
|
json={"display_name": ""},
|
|
)
|
|
assert resp.status_code == 422
|
|
body = resp.json()
|
|
assert body["code"] == "VALIDATION_ERROR"
|
|
assert "errors" in body
|
|
assert isinstance(body["errors"], list)
|
|
assert len(body["errors"]) > 0
|
|
# Each error should have field, message, type
|
|
for err in body["errors"]:
|
|
assert "field" in err
|
|
assert "message" in err
|
|
assert "type" in err
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_error_stats_requires_service_key(client):
|
|
"""Error stats endpoint should require X-Service-Key."""
|
|
resp = await client.get("/internal/error-stats")
|
|
assert resp.status_code == 422 # Missing required header
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_error_stats_with_valid_key(client):
|
|
"""Error stats endpoint returns monitoring data with valid key."""
|
|
resp = await client.get(
|
|
"/internal/error-stats",
|
|
headers={"X-Service-Key": "change-me-in-production"},
|
|
)
|
|
assert resp.status_code == 200
|
|
body = resp.json()
|
|
assert "error_counts" in body
|
|
assert "recent_5xx_count" in body
|