Barcode Betty
5a6f4cd44c
CI / lint (pull_request) Failing after 5s
CI / typecheck (pull_request) Failing after 33s
CI / test (pull_request) Failing after 1m20s
CI / build-and-push (pull_request) Has been skipped
CI / deploy-dev (pull_request) Has been skipped
CI / deploy-uat (pull_request) Has been skipped
- main.py: add docstring inside the lifespan function explaining why dispose_engine is lazy-imported rather than top-level. The original import path (top-level) crashed the container at import time with 'ImportError: cannot import name dispose_engine from cartsnitch_api.database' when database.py was stale or stripped during a CI build. Lazy import keeps the engine disposal behavior while preventing the module-load crash. - tests/test_openapi.py: add test_dispose_engine_importable_from_database that asserts dispose_engine is importable and callable. This is the exact path the deployed UAT image was failing on, captured as a regression test so a future regression lands in CI before deploy. Refs CAR-1135. Co-Authored-By: Paperclip <noreply@paperclip.ing>
81 lines
3.0 KiB
Python
81 lines
3.0 KiB
Python
"""FastAPI app factory for CartSnitch API Gateway."""
|
|
|
|
from contextlib import asynccontextmanager
|
|
|
|
from fastapi import APIRouter, FastAPI
|
|
|
|
from cartsnitch_api.auth.routes import router as auth_router
|
|
from cartsnitch_api.cache import cache_client
|
|
from cartsnitch_api.middleware.cors import add_cors_middleware
|
|
from cartsnitch_api.middleware.error_handler import add_error_handlers, add_error_monitor_middleware
|
|
from cartsnitch_api.middleware.rate_limit import add_rate_limit_middleware
|
|
from cartsnitch_api.middleware.audit import add_audit_middleware
|
|
from cartsnitch_api.routes.alerts import router as alerts_router
|
|
from cartsnitch_api.routes.coupons import router as coupons_router
|
|
from cartsnitch_api.routes.health import router as health_router
|
|
from cartsnitch_api.routes.prices import router as prices_router
|
|
from cartsnitch_api.routes.products import router as products_router
|
|
from cartsnitch_api.routes.public import router as public_router
|
|
from cartsnitch_api.routes.purchases import router as purchases_router
|
|
from cartsnitch_api.routes.scraping import router as scraping_router
|
|
from cartsnitch_api.routes.shopping import router as shopping_router
|
|
from cartsnitch_api.routes.stores import router as stores_router
|
|
from cartsnitch_api.routes.user import router as user_router
|
|
|
|
|
|
@asynccontextmanager
|
|
async def lifespan(app: FastAPI):
|
|
# Lazy import: keep `dispose_engine` out of the top-level imports so a
|
|
# stale or partially-built database.py never breaks module load on
|
|
# container start. The function is required for graceful pool cleanup
|
|
# on shutdown; if the import fails, the cache_client.close() that
|
|
# follows the yield would mask it. See CAR-1135 for the original
|
|
# ImportError that motivated this pattern.
|
|
from cartsnitch_api.database import dispose_engine
|
|
|
|
await cache_client.initialize()
|
|
yield
|
|
await cache_client.close()
|
|
await dispose_engine()
|
|
|
|
|
|
def create_app() -> FastAPI:
|
|
app = FastAPI(
|
|
title="CartSnitch API",
|
|
description="Grocery price tracking and shrinkflation detection API",
|
|
version="0.1.0",
|
|
lifespan=lifespan,
|
|
)
|
|
|
|
# Middleware (order matters — outermost first)
|
|
add_cors_middleware(app)
|
|
add_error_monitor_middleware(app)
|
|
add_rate_limit_middleware(app)
|
|
add_audit_middleware(app)
|
|
|
|
# Exception handlers
|
|
add_error_handlers(app)
|
|
|
|
# Routers
|
|
app.include_router(health_router)
|
|
app.include_router(auth_router)
|
|
|
|
# Data endpoints mounted under /api/v1
|
|
v1_router = APIRouter(prefix="/api/v1")
|
|
v1_router.include_router(user_router)
|
|
v1_router.include_router(stores_router)
|
|
v1_router.include_router(purchases_router)
|
|
v1_router.include_router(products_router)
|
|
v1_router.include_router(prices_router)
|
|
v1_router.include_router(coupons_router)
|
|
v1_router.include_router(shopping_router)
|
|
v1_router.include_router(alerts_router)
|
|
v1_router.include_router(scraping_router)
|
|
v1_router.include_router(public_router)
|
|
app.include_router(v1_router)
|
|
|
|
return app
|
|
|
|
|
|
app = create_app()
|