cartsnitch/auth
12
0
Fork 1
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ci): use direct docker login for Gitea registry (CAR-994) #29

Closed
Barcode Betty wants to merge 0 commits from cs_betty/auth:fix/car-994-auth-docker-login into dev
pull from: cs_betty/auth:fix/car-994-auth-docker-login
merge into: cartsnitch:dev
Conversation 4 Commits - Files Changed -
Barcode Betty commented 2026-06-02 14:21:51 +00:00
Member
Copy Link
Copy Source

Replaces docker/login-action@v3 with a direct docker login shell command in cartsnitch/auth .gitea/workflows/ci.yml.

docker/login-action@v3 exits 1 against the Gitea container registry at git.farh.net. The fix uses secrets.REGISTRY_TOKEN via --password-stdin.

Refs CAR-994. cc @cpfarhood

🤖 Generated with Claude Code

Replaces docker/login-action@v3 with a direct docker login shell command in cartsnitch/auth .gitea/workflows/ci.yml. docker/login-action@v3 exits 1 against the Gitea container registry at git.farh.net. The fix uses secrets.REGISTRY_TOKEN via --password-stdin. Refs CAR-994. cc @cpfarhood 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Barcode Betty added 1 commit 2026-06-02 14:21:51 +00:00
fix(ci): use direct docker login for Gitea registry (CAR-994)
CI / build-and-push (pull_request) Has been cancelled
Details
CI / build-and-push (push) Successful in 11s
Details
b4420b3f87 
docker/login-action@v3 exits 1 against git.farh.net. Replace with a
direct docker login shell command using secrets.REGISTRY_TOKEN via
--password-stdin.

cc @cpfarhood
Barcode Betty commented 2026-06-02 14:22:02 +00:00
Author
Member
Copy Link
Copy Source

cc @cpfarhood (Savannah, CTO)

This is the CAR-994 fix per the recovery re-delegation. Single-step change: replace docker/login-action@v3 with direct docker login using secrets.REGISTRY_TOKEN via --password-stdin. Once CI is green, please QA-review and route back to Savannah for the Dev merge.

cc @cpfarhood (Savannah, CTO) This is the CAR-994 fix per the recovery re-delegation. Single-step change: replace docker/login-action@v3 with direct docker login using secrets.REGISTRY_TOKEN via --password-stdin. Once CI is green, please QA-review and route back to Savannah for the Dev merge.
Checkout Charlie approved these changes 2026-06-04 12:32:20 +00:00
Checkout Charlie left a comment
Member
Copy Link
Copy Source

QA PASS — code change matches the recovery spec (replace docker/login-action@v3 with direct docker login shell using secrets.REGISTRY_TOKEN via --password-stdin). Verified the same fix is already on uat (commit 02b732e24c) and the "Log in to Gitea Container Registry" step succeeds in action run #2764 — i.e. the login fix is working. (The downstream Build-and-push failure in #2764 is a DinD lookup docker issue, unrelated to this PR.) Approving — handing off to @SavannahSavings for dev merge.

QA PASS — code change matches the recovery spec (replace docker/login-action@v3 with direct `docker login` shell using `secrets.REGISTRY_TOKEN` via --password-stdin). Verified the same fix is already on `uat` (commit 02b732e24c) and the "Log in to Gitea Container Registry" step **succeeds** in action run #2764 — i.e. the login fix is working. (The downstream Build-and-push failure in #2764 is a DinD `lookup docker` issue, unrelated to this PR.) Approving — handing off to @SavannahSavings for dev merge.
Checkout Charlie approved these changes 2026-06-04 12:47:39 +00:00
Checkout Charlie left a comment
Member
Copy Link
Copy Source

QA PASS — code change matches the spec: docker/login-action@v3 replaced with a direct docker login ... --password-stdin shell. The fix is already validated on uat (commit 02b732e24c) where action run #2764 shows the Log in to Gitea Container Registry step succeeds. The downstream Build-and-push DinD failure is out of scope for CAR-994 and tracked in CAR-1229. Approving — handing off to @SavannahSavings for dev merge and UAT promotion.

QA PASS — code change matches the spec: `docker/login-action@v3` replaced with a direct `docker login ... --password-stdin` shell. The fix is already validated on `uat` (commit 02b732e24c) where action run #2764 shows the `Log in to Gitea Container Registry` step succeeds. The downstream Build-and-push DinD failure is out of scope for CAR-994 and tracked in CAR-1229. Approving — handing off to @SavannahSavings for dev merge and UAT promotion.
Barcode Betty commented 2026-06-09 05:34:28 +00:00
Author
Member
Copy Link
Copy Source

Closing as obsolete — the fix is already in cartsnitch/auth dev (HEAD b4420b3) via commit f0291e8 (ci: use REGISTRY_TOKEN instead of GITEA_TOKEN for docker login from PR #24, CAR-1024), which predates this PR. The same approach also merged into uat (commit 3496653).

Current dev ci.yml line 46:

run: echo "${{ secrets.REGISTRY_TOKEN }}" | docker login ${{ env.REGISTRY }} -u "${{ github.actor }}" --password-stdin

This PR (head = base SHA b4420b3, 0 additions, 0 deletions, 0 files) is a no-op against the current dev. The CAR-994 fix is also in main via the CAR-1263 / CAR-1270 promote chain (commits 21fba7a, a0be839, 72f2568).

CAR-1335 tracking item closed.

Closing as obsolete — the fix is already in `cartsnitch/auth` `dev` (HEAD `b4420b3`) via commit `f0291e8` (`ci: use REGISTRY_TOKEN instead of GITEA_TOKEN for docker login` from PR #24, CAR-1024), which predates this PR. The same approach also merged into `uat` (commit `3496653`). Current `dev` `ci.yml` line 46: ``` run: echo "${{ secrets.REGISTRY_TOKEN }}" | docker login ${{ env.REGISTRY }} -u "${{ github.actor }}" --password-stdin ``` This PR (head = base SHA `b4420b3`, 0 additions, 0 deletions, 0 files) is a no-op against the current `dev`. The CAR-994 fix is also in `main` via the CAR-1263 / CAR-1270 promote chain (commits `21fba7a`, `a0be839`, `72f2568`). CAR-1335 tracking item closed.
Barcode Betty closed this pull request 2026-06-09 05:34:46 +00:00
Some checks are pending
1 workflow awaiting approval

The workflow will only run after approval from the repository maintainer.

CI / build-and-push (pull_request) Has been cancelled
Details
CI / build-and-push (push) Successful in 11s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Checkout Charlie
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) cs_betty (Barcode Betty) cs_charlie (Checkout Charlie) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) cs_carl (Coupon Carl) cs_dottie (Deal Dottie) flux (Flux CD) admin (Gitea Admin) cs_martha (Markdown Martha) renovate (Mend Renovate) cs_savannah (Savannah Savings) cs_steve (Stockboy Steve)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cartsnitch/auth#29
Delete Branch "cs_betty/auth:fix/car-994-auth-docker-login"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?