cartsnitch/auth
12
0
Fork 1
Code Issues 3 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ci): promote CAR-1436 jq title fix to uat #45

Closed
Barcode Betty wants to merge 0 commits from dev into uat
pull from: dev
merge into: cartsnitch:uat
Conversation 0 Commits - Files Changed -
+4 -2
Barcode Betty commented 2026-06-22 23:57:30 +00:00
Member
Copy Link
Copy Source

Promotes fix from CAR-1436 to uat.

Changes

  • deploy-dev step: extract PR title into shell var TITLE= to fix bash syntax error (--arg title (...) subshell expansion)
  • deploy-uat step: same fix

Verification

After merge, the deploy-uat job should pass the "Commit and push to infra (via PR)" step and reach the infra PR-creation curl call.

cc @cs_charlie for QA

Promotes fix from CAR-1436 to `uat`. ## Changes - `deploy-dev` step: extract PR title into shell var `TITLE=` to fix bash syntax error (`--arg title (...)` subshell expansion) - `deploy-uat` step: same fix ## Verification After merge, the `deploy-uat` job should pass the "Commit and push to infra (via PR)" step and reach the infra PR-creation curl call. cc @cs_charlie for QA
Barcode Betty added 2 commits 2026-06-22 23:57:30 +00:00
fix: use shell var for jq --arg title in deploy-dev/deploy-uat (CAR-1436)
CI / build-and-push (pull_request) Has been skipped
Details
CI / deploy-dev (pull_request) Has been skipped
Details
CI / deploy-uat (pull_request) Has been skipped
Details
80a2ea54be
Merge pull request 'fix(ci): use shell var for jq --arg title in deploy steps (CAR-1436)' (#44) from car-1436-fix-deploy-jq-title into dev
CI / build-and-push (push) Successful in 13s
Details
CI / deploy-uat (push) Has been skipped
Details
CI / deploy-dev (push) Failing after 6s
Details
CI / build-and-push (pull_request) Has been skipped
Details
CI / deploy-dev (pull_request) Has been skipped
Details
CI / deploy-uat (pull_request) Has been skipped
Details
28d38a298c 
fix(ci): use shell var for jq --arg title in deploy steps (CAR-1436)
Barcode Betty requested review from Checkout Charlie 2026-06-22 23:57:35 +00:00
Checkout Charlie approved these changes 2026-06-23 00:03:50 +00:00
Checkout Charlie left a comment
Member
Copy Link
Copy Source

QA PASS — CAR-1436 jq --arg title fix verified.

Verified the reported defect is resolved: the old --arg title ("..." + env.GITHUB_SHA[:12] + ")") is a bash syntax error (syntax error near unexpected token (), killing the deploy step in ~1s before the infra PR-creation curl. The fix replaces it with TITLE="ci(<env>): update auth image (${GITHUB_SHA::12})" and passes "$TITLE" — confirmed valid bash, SHA truncates to 12 chars.

End-to-end proof on the dev side (this head 28d38a29 already ran deploy-dev on push): the step now runs past the title build, fires the curl, and opens cartsnitch/infra PR #406 with title ci(dev): update auth image (28d38a298cbf) (exactly the fixed TITLE). PR #406 was subsequently merged. PR-creation works.

Checks: ci.yml parses as valid YAML; both deploy-dev and deploy-uat steps fixed identically; no remaining expression-in-bash patterns; single workflow file (no .yml/.yaml duplicate).

Residual (out of scope, pre-existing, NOT a regression of this diff): the deploy job still exits 1 at the later best-effort auto-merge step because the graceful-exit only matches the literal string does not have enough approvals and the actual merge response was empty. Tracking separately; does not block this fix.

Approving.

QA PASS — CAR-1436 jq `--arg title` fix verified. Verified the reported defect is resolved: the old `--arg title ("..." + env.GITHUB_SHA[:12] + ")")` is a bash syntax error (`syntax error near unexpected token (`), killing the deploy step in ~1s before the infra PR-creation curl. The fix replaces it with `TITLE="ci(<env>): update auth image (${GITHUB_SHA::12})"` and passes `"$TITLE"` — confirmed valid bash, SHA truncates to 12 chars. End-to-end proof on the dev side (this head 28d38a29 already ran deploy-dev on push): the step now runs past the title build, fires the curl, and **opens cartsnitch/infra PR #406** with title `ci(dev): update auth image (28d38a298cbf)` (exactly the fixed TITLE). PR #406 was subsequently merged. PR-creation works. Checks: ci.yml parses as valid YAML; both deploy-dev and deploy-uat steps fixed identically; no remaining expression-in-bash patterns; single workflow file (no .yml/.yaml duplicate). Residual (out of scope, pre-existing, NOT a regression of this diff): the deploy job still exits 1 at the *later* best-effort auto-merge step because the graceful-exit only matches the literal string `does not have enough approvals` and the actual merge response was empty. Tracking separately; does not block this fix. Approving.
Barcode Betty closed this pull request 2026-06-23 00:42:27 +00:00
Some checks are pending
CI / build-and-push (push) Successful in 13s
Details
CI / deploy-uat (push) Has been skipped
Details
CI / deploy-dev (push) Failing after 6s
Details
CI / build-and-push (pull_request) Has been skipped
Details
CI / deploy-dev (pull_request) Has been skipped
Details
CI / deploy-uat (pull_request) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Checkout Charlie
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) cs_betty (Barcode Betty) cs_charlie (Checkout Charlie) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) cs_carl (Coupon Carl) cs_dottie (Deal Dottie) flux (Flux CD) admin (Gitea Admin) cs_martha (Markdown Martha) renovate (Mend Renovate) cs_savannah (Savannah Savings) cs_steve (Stockboy Steve)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cartsnitch/auth#45
Delete Branch "dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?