Compare commits

..

4 Commits

Author SHA1 Message Date
Coupon Carl 90031d65a3 Merge pull request 'Release: uat→main (UAT PASS Deal Dottie, Security PASS Stockboy Steve)' (#296) from uat into main
CI / lint (push) Successful in 12s
CI / test (push) Successful in 13s
CI / audit (push) Successful in 11s
CI / e2e (push) Successful in 43s
CI / lighthouse (push) Failing after 1m17s
CI / build-and-push-api (push) Successful in 1m43s
CI / build-and-push-receiptwitness (push) Successful in 2m23s
CI / build-and-push-auth (push) Successful in 42s
CI / build-and-push (push) Successful in 41s
CI / deploy-dev (push) Successful in 7s
CI / deploy-uat (push) Successful in 8s
Merge uat→main: UAT PASS (Deal Dottie, uat HEAD 9a811f9e) + Security PASS (Stockboy Steve, CAR-1327)
2026-06-08 13:10:54 +00:00
Savannah Savings 9a811f9e93 Merge pull request 'promote: deploy jobs compute sha tag from $GITHUB_SHA (CAR-1319, CAR-1316)' (#295) from dev into uat
CI / lint (push) Successful in 12s
CI / test (push) Successful in 10s
CI / audit (push) Successful in 9s
CI / e2e (push) Successful in 40s
CI / lighthouse (push) Failing after 1m18s
CI / build-and-push-receiptwitness (push) Successful in 2m19s
CI / build-and-push-api (push) Successful in 1m27s
CI / build-and-push-auth (push) Successful in 1m1s
CI / build-and-push (push) Successful in 1m1s
CI / deploy-dev (push) Has been skipped
CI / deploy-uat (push) Successful in 6s
CI / deploy-dev (pull_request) Has been skipped
CI / deploy-uat (pull_request) Has been skipped
CI / test (pull_request) Successful in 13s
CI / audit (pull_request) Successful in 12s
CI / e2e (pull_request) Successful in 44s
CI / build-and-push (pull_request) Has been skipped
CI / lint (pull_request) Successful in 13s
CI / build-and-push-api (pull_request) Has been skipped
CI / build-and-push-receiptwitness (pull_request) Has been skipped
CI / build-and-push-auth (pull_request) Has been skipped
CI / lighthouse (pull_request) Failing after 1m41s
2026-06-08 12:41:45 +00:00
Savannah Savings 6abbc2f04e Merge pull request 'fix(ci): deploy jobs compute sha tag from $GITHUB_SHA (CAR-1316, CAR-1195)' (#292) from betty/car-1319-sha-tag-fix into dev
CI / test (push) Successful in 13s
CI / lint (push) Successful in 13s
CI / audit (push) Successful in 10s
CI / e2e (push) Successful in 54s
CI / lighthouse (push) Failing after 1m23s
CI / build-and-push-api (push) Successful in 1m34s
CI / build-and-push-receiptwitness (push) Successful in 2m14s
CI / build-and-push-auth (push) Successful in 38s
CI / build-and-push (push) Successful in 1m4s
CI / deploy-uat (push) Has been skipped
CI / deploy-dev (push) Successful in 9s
CI / lint (pull_request) Successful in 10s
CI / test (pull_request) Successful in 12s
CI / audit (pull_request) Successful in 11s
CI / e2e (pull_request) Successful in 43s
CI / build-and-push-api (pull_request) Has been skipped
CI / build-and-push-receiptwitness (pull_request) Has been skipped
CI / build-and-push-auth (pull_request) Has been skipped
CI / lighthouse (pull_request) Failing after 1m20s
CI / build-and-push (pull_request) Has been skipped
CI / deploy-dev (pull_request) Has been skipped
CI / deploy-uat (pull_request) Has been skipped
2026-06-08 12:34:06 +00:00
Barcode Betty 04529666fc fix(ci): deploy jobs compute sha tag from $GITHUB_SHA (CAR-1316, CAR-1195)
CI / audit (pull_request) Successful in 10s
CI / lint (pull_request) Successful in 14s
CI / test (pull_request) Successful in 15s
CI / build-and-push-receiptwitness (pull_request) Has been skipped
CI / build-and-push-api (pull_request) Has been skipped
CI / build-and-push-auth (pull_request) Has been skipped
CI / e2e (pull_request) Successful in 40s
CI / build-and-push (pull_request) Has been skipped
CI / deploy-dev (pull_request) Has been skipped
CI / deploy-uat (pull_request) Has been skipped
CI / lighthouse (pull_request) Failing after 1m14s
The four `build-and-push*` jobs declared a job-level output
`sha_tag: sha-${{ github.sha }}` (literal prefix concatenated with
an expression). Gitea Actions does NOT substitute ${{ github.sha }}
inside that concatenated value, so the literal string
`sha-${{ github.sha }}` propagated into needs.<job>.outputs.sha_tag.

Each deploy job's 'Determine image tag' step then expanded
`echo "tag=${{ needs.<job>.outputs.sha_tag }}" >> "$GITHUB_OUTPUT"`
into `echo "tag=sha-${{ github.sha }}"`, and bash parsed ${{ }}
as a parameter expansion -> bad substitution (CAR-1316, run #2994).

Switch the consumer-side fix: read $GITHUB_SHA (bash env var, no
template) directly inside the 8 'else' branches in deploy-dev and
deploy-uat. Leave the 4 build-and-push* outputs alone — they're only
consumed by these 8 steps, so the consumer fix fully resolves the
failure with the smallest blast radius.

Refs: CAR-1316, CAR-1195, CAR-1194.
2026-06-07 11:28:41 +00:00
+8 -8
View File
@@ -488,7 +488,7 @@ jobs:
if [ "${{ github.ref }}" == "refs/heads/main" ]; then
echo "tag=${{ needs.build-and-push.outputs.calver_tag }}" >> "$GITHUB_OUTPUT"
else
echo "tag=${{ needs.build-and-push.outputs.sha_tag }}" >> "$GITHUB_OUTPUT"
echo "tag=sha-${GITHUB_SHA}" >> "$GITHUB_OUTPUT"
fi
- name: Update frontend image tag
@@ -503,7 +503,7 @@ jobs:
if [ "${{ github.ref }}" == "refs/heads/main" ]; then
echo "tag=${{ needs.build-and-push-receiptwitness.outputs.calver_tag }}" >> "$GITHUB_OUTPUT"
else
echo "tag=${{ needs.build-and-push-receiptwitness.outputs.sha_tag }}" >> "$GITHUB_OUTPUT"
echo "tag=sha-${GITHUB_SHA}" >> "$GITHUB_OUTPUT"
fi
- name: Update receiptwitness image tag
@@ -518,7 +518,7 @@ jobs:
if [ "${{ github.ref }}" == "refs/heads/main" ]; then
echo "tag=${{ needs.build-and-push-api.outputs.calver_tag }}" >> "$GITHUB_OUTPUT"
else
echo "tag=${{ needs.build-and-push-api.outputs.sha_tag }}" >> "$GITHUB_OUTPUT"
echo "tag=sha-${GITHUB_SHA}" >> "$GITHUB_OUTPUT"
fi
- name: Update api image tag
@@ -533,7 +533,7 @@ jobs:
if [ "${{ github.ref }}" == "refs/heads/main" ]; then
echo "tag=${{ needs.build-and-push-auth.outputs.calver_tag }}" >> "$GITHUB_OUTPUT"
else
echo "tag=${{ needs.build-and-push-auth.outputs.sha_tag }}" >> "$GITHUB_OUTPUT"
echo "tag=sha-${GITHUB_SHA}" >> "$GITHUB_OUTPUT"
fi
- name: Update auth image tag
@@ -634,7 +634,7 @@ jobs:
if [ "${{ github.ref }}" == "refs/heads/main" ]; then
echo "tag=${{ needs.build-and-push.outputs.calver_tag }}" >> "$GITHUB_OUTPUT"
else
echo "tag=${{ needs.build-and-push.outputs.sha_tag }}" >> "$GITHUB_OUTPUT"
echo "tag=sha-${GITHUB_SHA}" >> "$GITHUB_OUTPUT"
fi
- name: Update frontend image tag
@@ -649,7 +649,7 @@ jobs:
if [ "${{ github.ref }}" == "refs/heads/main" ]; then
echo "tag=${{ needs.build-and-push-receiptwitness.outputs.calver_tag }}" >> "$GITHUB_OUTPUT"
else
echo "tag=${{ needs.build-and-push-receiptwitness.outputs.sha_tag }}" >> "$GITHUB_OUTPUT"
echo "tag=sha-${GITHUB_SHA}" >> "$GITHUB_OUTPUT"
fi
- name: Update receiptwitness image tag
@@ -664,7 +664,7 @@ jobs:
if [ "${{ github.ref }}" == "refs/heads/main" ]; then
echo "tag=${{ needs.build-and-push-api.outputs.calver_tag }}" >> "$GITHUB_OUTPUT"
else
echo "tag=${{ needs.build-and-push-api.outputs.sha_tag }}" >> "$GITHUB_OUTPUT"
echo "tag=sha-${GITHUB_SHA}" >> "$GITHUB_OUTPUT"
fi
- name: Update api image tag
@@ -679,7 +679,7 @@ jobs:
if [ "${{ github.ref }}" == "refs/heads/main" ]; then
echo "tag=${{ needs.build-and-push-auth.outputs.calver_tag }}" >> "$GITHUB_OUTPUT"
else
echo "tag=${{ needs.build-and-push-auth.outputs.sha_tag }}" >> "$GITHUB_OUTPUT"
echo "tag=sha-${GITHUB_SHA}" >> "$GITHUB_OUTPUT"
fi
- name: Update auth image tag