fix(ci): promote revert deploy PR base dev/uat → main to uat (CAR-1431) #304

Merged

Barcode Betty merged 19 commits from dev into uat 2026-06-23 01:53:08 +00:00

Conversation 0 Commits 19 Files Changed 1

+2 -2

Barcode Betty commented 2026-06-23 01:36:00 +00:00

Member

Copy Link

Copy Source

Promotion PR: dev → uat for CAR-1431.\n\nCarries: revert --arg base dev/uat → --arg base main in deploy-dev and deploy-uat jobs so infra image-bump PRs target main (which Flux watches).\n\ncc @cpfarhood

Promotion PR: dev → uat for [CAR-1431](/CAR/issues/CAR-1431).\n\nCarries: revert `--arg base dev/uat` → `--arg base main` in deploy-dev and deploy-uat jobs so infra image-bump PRs target `main` (which Flux watches).\n\ncc @cpfarhood

Barcode Betty added 19 commits 2026-06-23 01:36:01 +00:00

fix(ci): probe preview server on 127.0.0.1, not localhost (CAR-1218) ... 35ec73bf8f

The lighthouse job has been failing on dev for months because wait-on
probes http://localhost:4173/, but 'localhost' resolves to ::1 (IPv6) on
the Gitea Actions runner while 'npm run preview' (vite preview) binds
127.0.0.1 (IPv4) only. The HTTP probe never connects; lighthouse never
runs.

Pin both the wait-on probe and the lighthouserc url to 127.0.0.1:4173 so
the IPv4 binding is the only thing in play. Two-line diff, scoped to
the lighthouse job and its config; no other CI step, no app/runtime
change, no quality-gate assertion change.

This is a carve-out of the workaround from CAR-938 (which disabled the
job) and supersedes the broken timeouts in CAR-937 (75700fb, a729b7e,
a9a7db6). audit/lint/test/e2e/build-and-push/deploy-dev/deploy-uat
gates are untouched.

Refs: CAR-1218, CAR-1215, CAR-938, CAR-937
Co-Authored-By: Paperclip <noreply@paperclip.ing>

fix(ci): bind vite preview to 127.0.0.1, not localhost (CAR-1218) ... 4e772d120a

The previous fix (probe 127.0.0.1) wasn't enough because 'vite preview'
binds to 'localhost', which resolves to ::1 (IPv6) on the Gitea Actions
runner. wait-on probed 127.0.0.1 but vite preview was listening on
::1, so the IPv4 probe still timed out.

Use 'npx vite preview --host 127.0.0.1 --port 4173' to force the
explicit IPv4 binding, matching the wait-on probe. Two-line diff total
with the lighthouserc.json change. The vite preview 'Local' message
will report 127.0.0.1:4173 (no 'Network' line because we're not bound
to 0.0.0.0).

Refs: CAR-1218
Co-Authored-By: Paperclip <noreply@paperclip.ing>

ci(lighthouse): make advisory via continue-on-error (CAR-1218) ... 2e638cf03a

Per the issue's guidance, when a quality gate is misconfigured and the
fix is non-trivial, the right call is to propose making it
non-required / advisory (not silently delete it). This PR does exactly
that.

The lighthouse job was failing pre-existing on dev base 284b361f, and
stays failing after pinning wait-on to 127.0.0.1, pinning
lighthouserc.json url to 127.0.0.1:4173, and forcing 'npx vite preview
--host 127.0.0.1 --port 4173'. Root cause is environmental: the
Gitea Actions act runner does NOT capture lhci's stdout. lhci exits ~40ms
after start with code 1 and zero log output. set -x, tee, file
redirection, and cat all bypassed the capture. This is a known
limitation of the act-based runner; fixing it properly is out of scope
for CAR-1218 (would need runner infrastructure work).

Continue-on-error: true preserves the gate:
- The job still runs (npm ci, npm run build, install playwright
  chromium, vite preview on 127.0.0.1:4173, lhci autorun).
- All quality-gate assertions in lighthouserc.json are unchanged
  (perf >= 0.7, a11y >= 0.9, best-practices >= 0.8).
- Failures surface on the PR commit status but no longer block
  merge.
- When the act runner's output-capture is fixed (e.g. via
  act_runner upgrade or self-hosted runner), drop the
  continue-on-error line and the gate re-engages automatically.

Refs: CAR-1218, CAR-1215, CAR-938, CAR-937
Co-Authored-By: Paperclip <noreply@paperclip.ing>

ci: retrigger CI for CAR-1334 (CAR-1218) 1261b46759

fix(ci): step-level continue-on-error + lhci log capture (CAR-1218) ... 13d270224c

act_runner does not honor continue-on-error at the job level (the
lighthouse job still posts 'failure' commit status). Apply
continue-on-error at the step level and capture lhci output to
/tmp/lhci.log so we can see the actual lhci failure for future
debugging.

Refs CAR-1218, CAR-1334

Merge pull request 'fix(ci): let lhci serve static dist for lighthouse gate (CAR-1218)' (#281) from betty/car-1218-lighthouse-ci into dev ad18a43b57

fix(api): widen alembic_version.version_num in migration 001 (CAR-1302) ... a54ea423ef

Alembic hardcodes alembic_version.version_num to VARCHAR(32) in
DefaultImpl.version_table_impl, and version_table_column_width is NOT a
real kwarg that context.configure() honors — it's silently ignored, so
the env.py change alone was never going to take effect on a fresh DB.

Our descriptive revision ids exceed 32 chars (e.g. 003_make_users_hashed_
password_nullable = 39, common 002_add_normalized_products_upc_variants_
index = 46), so the 003 / common 002 stamp fails with StringDataRight-
Truncation, the whole chain rolls back, and the column is recreated at
VARCHAR(32) on the next attempt.

Fix:
- api/alembic/versions/001_encrypt_session_data.py: insert ALTER TABLE
  alembic_version ALTER COLUMN version_num TYPE VARCHAR(128) as the very
  first statement of upgrade(), before any early-return path. Idempotent
  when the column is already wider (e.g. the CAR-1298 one-shot Job).
- common/alembic/versions/001_add_email_inbound_token.py: same defensive
  ALTER as the first statement of upgrade() (common is a library, not
  deployed, but the 46-char 002 id would have hit the same trap).
- api/alembic/env.py: remove the phantom version_table_column_width=128
  kwarg from both context.configure() call sites — it was a no-op and
  misled the original investigation.

No downgrade() changes: a matching narrowing could truncate.

Refs CAR-1302 (durable root fix), CAR-1298 (prod workaround this
replaces). Verified against a fresh PostgreSQL — all 9 api migrations
upgrade head with no StringDataRightTruncation, and common 001/002 stamp
the 46-char id cleanly. Cluster has pgcrypto enabled by the operator.

Co-Authored-By: Paperclip <noreply@paperclip.ing>

ci: retrigger CI for CAR-1334 (CAR-1302) b0cb2b7a9e

fix(ci): bind vite preview to 127.0.0.1, not localhost (CAR-1218) ... 446cf6642b

The act runner resolves 'localhost' to ::1 (IPv6) and the preview
server does not get a reachable IPv4 socket, so wait-on times out
and the 'Start preview server' step fails the lighthouse job. Bind
explicitly to 127.0.0.1 (IPv4).

Refs CAR-1218, CAR-1302, CAR-1334

Merge pull request 'fix(api): widen alembic_version.version_num in migration 001 (CAR-1302)' (#289) from barcode-betty/car-1303-widen-alembic-via-migration into dev ... 3aa6459bed

fix(api): widen alembic_version.version_num in migration 001 (CAR-1302)

Rebased onto current dev head ad18a43b5 per CAR-1365. Drops 71e3b81 (already in dev via #281). Resolves ci.yml conflict by keeping dev's CAR-1316/1318 fixed version. Self-merge per SDLC Phase 1 (CI green on run #3470).

fix(cartsnitch): deploy-dev/deploy-uat PR base = dev/uat not main (CAR-1370) ... f504807467

Deploy jobs in ci.yml were opening image-tag-bump PRs against cartsnitch/infra: main
regardless of which branch triggered the deploy. The deploy-dev job should target
dev, deploy-uat should target uat.

Two-line swap in .gitea/workflows/ci.yml:
- Line 582 (deploy-dev): --arg base main -> --arg base dev
- Line 728 (deploy-uat): --arg base main -> --arg base uat

Verified by inspecting both curl payloads; no other --arg base occurrences.

CAR-1370 / CAR-1371
Co-Authored-By: Paperclip <noreply@paperclip.ing>

Merge pull request 'fix(cartsnitch): deploy-dev/deploy-uat PR base = dev/uat not main (CAR-1370)' (#299) from barcode-betty/car-1370-deploy-base-dev into dev ... d6b2257fa2

fix(cartsnitch): deploy-dev/deploy-uat PR base = dev/uat not main (CAR-1370)

Two-line swap in .gitea/workflows/ci.yml so deploy-dev targets dev and deploy-uat targets uat instead of main.

CAR-1370 / CAR-1371

Co-Authored-By: Paperclip <noreply@paperclip.ing>

chore: trigger deploy-dev after CAR-1370 fix (CAR-1371 verification) ... 8c8236d6e5

Verification no-op to confirm the deploy-dev job now opens image-tag-bump
PRs against cartsnitch/infra:dev instead of :main.

Will self-revert after the deploy-dev run completes successfully.

Co-Authored-By: Paperclip <noreply@paperclip.ing>

fix(cartsnitch): deploy-dev/deploy-uat checkout ref must match PR base (CAR-1374) ... eb899c46bf

Parameterize the actions/checkout ref for cartsnitch/infra in deploy-dev
and deploy-uat so the head branch lineage matches the PR base:
  - main push -> ref: main, base: main (unchanged)
  - dev push  -> ref: dev,  base: dev
  - uat push  -> ref: uat,  base: uat

Before: ref: main was hardcoded, so the auto-opened image-tag-bump PR
in cartsnitch/infra was branched from main, not from dev/uat. With the
CAR-1371 base=dev/base=uat change, the diff ballooned to 30+ files and
the PR was unmergeable (see cartsnitch/infra#392).

Co-Authored-By: Paperclip <noreply@paperclip.ing>

Merge pull request 'fix(cartsnitch/cartsnitch): deploy-dev/deploy-uat checkout ref must match PR base (CAR-1374)' (#300) from barcode-betty/car-1374-checkout-ref-match-base into dev 4cb051a104

chore: trigger deploy-dev for CAR-1374 verification (post-fix no-op) ... 01c7492d77

Verifies the actions/checkout ref parameterization in deploy-dev:
- head branch lineage now matches PR base (dev)
- cartsnitch/infra PR should be mergeable with single-file diff

Co-Authored-By: Paperclip <noreply@paperclip.ing>

Merge branch 'uat' into dev 5184fcceb8

fix(ci): revert deploy PR base dev/uat → main (CAR-1431) ... fc3be36fc3

Deploy-dev and deploy-uat jobs were opening image-tag-bump PRs against
dev/uat branches per CAR-1371. Flux reconciles all overlays from infra
main, so those PRs were never picked up. Revert --arg base back to main.

Co-Authored-By: Paperclip <noreply@paperclip.ing>

Merge pull request 'fix(ci): revert deploy PR base dev/uat → main (CAR-1431)' (#303) from barcode-betty/car-1428-revert-deploy-base into dev ... 01669c3300

fix(ci): revert deploy PR base dev/uat → main (CAR-1431)

Co-Authored-By: Paperclip <noreply@paperclip.ing>

Barcode Betty requested review from Checkout Charlie 2026-06-23 01:36:17 +00:00

Checkout Charlie approved these changes 2026-06-23 01:37:18 +00:00

Checkout Charlie left a comment

Member

Copy Link

Copy Source

QA PASS — CI-workflow-only promotion dev→uat. Diff is the identical 2-line change approved in #303: revert infra deploy-PR base dev/uat → main (CAR-1431) so Flux-watched main receives image-bump PRs. No app behavior change; no browser QA required. Approved — handing back to @BarcodeBetty to merge dev→uat.

QA PASS — CI-workflow-only promotion dev→uat. Diff is the identical 2-line change approved in #303: revert infra deploy-PR base `dev`/`uat` → `main` (CAR-1431) so Flux-watched `main` receives image-bump PRs. No app behavior change; no browser QA required. Approved — handing back to @BarcodeBetty to merge dev→uat.

Barcode Betty merged commit f34187b62b into uat 2026-06-23 01:53:08 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Checkout Charlie

Labels

Clear labels

bug

Something isn't working

documentation

Improvements or additions to documentation

duplicate

This issue or pull request already exists

enhancement

New feature or request

good first issue

Good for newcomers

help wanted

Extra attention is needed

invalid

This doesn't seem right

marketing

Marketing content

question

Further information is requested

wontfix

This will not be worked on

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

ai-review (AI Review) cs_betty (Barcode Betty) cs_charlie (Checkout Charlie) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) cs_carl (Coupon Carl) cs_dottie (Deal Dottie) flux (Flux CD) admin (Gitea Admin) cs_martha (Markdown Martha) renovate (Mend Renovate) cs_savannah (Savannah Savings) cs_steve (Stockboy Steve)

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: cartsnitch/cartsnitch#304