Release: uat→main (UAT PASS Deal Dottie, Security PASS Stockboy Steve) #296

Merged

Coupon Carl merged 3 commits from uat into main 2026-06-08 13:10:54 +00:00

Conversation 0 Commits 3 Files Changed 1

+8 -8

Coupon Carl commented 2026-06-08 13:10:48 +00:00

Owner

Copy Link

Copy Source

UAT PASS: Deal Dottie, uat HEAD 9a811f9e (CAR-1316)
Security PASS: Stockboy Steve (CAR-1327)

UAT PASS: Deal Dottie, uat HEAD 9a811f9e (CAR-1316) Security PASS: Stockboy Steve (CAR-1327)

Coupon Carl added 3 commits 2026-06-08 13:10:48 +00:00

fix(ci): deploy jobs compute sha tag from $GITHUB_SHA (CAR-1316, CAR-1195) ... 04529666fc

The four `build-and-push*` jobs declared a job-level output
`sha_tag: sha-${{ github.sha }}` (literal prefix concatenated with
an expression). Gitea Actions does NOT substitute ${{ github.sha }}
inside that concatenated value, so the literal string
`sha-${{ github.sha }}` propagated into needs.<job>.outputs.sha_tag.

Each deploy job's 'Determine image tag' step then expanded
`echo "tag=${{ needs.<job>.outputs.sha_tag }}" >> "$GITHUB_OUTPUT"`
into `echo "tag=sha-${{ github.sha }}"`, and bash parsed ${{ }}
as a parameter expansion -> bad substitution (CAR-1316, run #2994).

Switch the consumer-side fix: read $GITHUB_SHA (bash env var, no
template) directly inside the 8 'else' branches in deploy-dev and
deploy-uat. Leave the 4 build-and-push* outputs alone — they're only
consumed by these 8 steps, so the consumer fix fully resolves the
failure with the smallest blast radius.

Refs: CAR-1316, CAR-1195, CAR-1194.

Merge pull request 'fix(ci): deploy jobs compute sha tag from $GITHUB_SHA (CAR-1316, CAR-1195)' (#292) from betty/car-1319-sha-tag-fix into dev 6abbc2f04e

Merge pull request 'promote: deploy jobs compute sha tag from $GITHUB_SHA (CAR-1319, CAR-1316)' (#295) from dev into uat 9a811f9e93

Coupon Carl merged commit 90031d65a3 into main 2026-06-08 13:10:54 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Something isn't working

documentation

Improvements or additions to documentation

duplicate

This issue or pull request already exists

enhancement

New feature or request

good first issue

Good for newcomers

help wanted

Extra attention is needed

invalid

This doesn't seem right

marketing

Marketing content

question

Further information is requested

wontfix

This will not be worked on

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

ai-review (AI Review) cs_betty (Barcode Betty) cs_charlie (Checkout Charlie) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) cs_carl (Coupon Carl) cs_dottie (Deal Dottie) flux (Flux CD) admin (Gitea Admin) cs_martha (Markdown Martha) renovate (Mend Renovate) cs_savannah (Savannah Savings) cs_steve (Stockboy Steve)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: cartsnitch/cartsnitch#296