From 0bb4b7d18361cdaae29ef3e890d9e4fd8d8e1d09 Mon Sep 17 00:00:00 2001 From: Stockboy Steve Date: Mon, 30 Mar 2026 19:23:57 +0000 Subject: [PATCH] fix(lighthouse): set LHCI_CHROME_PATH and lower thresholds per CTO feedback - Set LHCI_CHROME_PATH to Playwright chromium binary path so LHCI healthcheck can find Chrome - Lower thresholds: performance=0.5, accessibility=0.7 (error), seo=0.7 - SEO threshold was missing, now added --- .github/workflows/ci.yml | 2 ++ lighthouserc.json | 7 ++++--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index eb46767..62a77f6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -62,6 +62,8 @@ jobs: npm install -g playwright npx playwright install chromium - name: Run Lighthouse CI + env: + LHCI_CHROME_PATH: /home/runner/.cache/ms-playwright/chromium-1208/chrome-linux/chrome run: | npm install -g @lhci/cli lhci autorun diff --git a/lighthouserc.json b/lighthouserc.json index be6793d..0ef986a 100644 --- a/lighthouserc.json +++ b/lighthouserc.json @@ -8,9 +8,10 @@ "assert": { "preset": "lighthouse:no-pwa", "assertions": { - "categories:performance": ["warn", { "minScore": 0.7 }], - "categories:accessibility": ["error", { "minScore": 0.9 }], - "categories:best-practices": ["warn", { "minScore": 0.8 }] + "categories:performance": ["warn", { "minScore": 0.5 }], + "categories:accessibility": ["error", { "minScore": 0.7 }], + "categories:best-practices": ["warn", { "minScore": 0.8 }], + "categories:seo": ["warn", { "minScore": 0.7 }] } }, "upload": {