From 0f8aa2fe47b610fc60e38cda83ccf75802a96755 Mon Sep 17 00:00:00 2001 From: Barcode Betty Date: Mon, 30 Mar 2026 20:19:36 +0000 Subject: [PATCH] fix(ci): address CTO review feedback on PR #64 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Fix refs_heads_main typo → refs/heads/main in build-and-push-auth metadata - Fix ci(ev) typo → ci(dev) in deploy-dev commit message - Add preview server step before lhci autorun in lighthouse job Addresses: CAR-199 Co-Authored-By: Paperclip --- .github/workflows/ci.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 39bfa6a..ad18153 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -61,6 +61,10 @@ jobs: run: | npm install -g playwright npx playwright install --with-deps chromium + - name: Start preview server + run: | + npm run preview & + npx wait-on http://localhost:4173/ --timeout 30000 - name: Run Lighthouse CI run: | CHROME_PATH=$(find /home/runner/.cache/ms-playwright -name chrome -type f 2>/dev/null | head -1) @@ -171,7 +175,7 @@ jobs: tags: | type=sha,prefix=sha- type=raw,value=${{ steps.calver.outputs.version }},enable=${{ github.ref == 'refs/heads/main' }} - type=raw,value=latest,enable=${{ github.ref == 'refs/heads_main' }} + type=raw,value=latest,enable=${{ github.ref == 'refs/heads/main' }} - name: Build and push auth Docker image uses: docker/build-push-action@v6 @@ -222,5 +226,5 @@ jobs: git config user.name "cartsnitch-ci[bot]" git config user.email "cartsnitch-ci[bot]@users.noreply.github.com" git add apps/overlays/dev/kustomization.yaml - git commit -m "ci(ev): update cartsnitch and auth images to ${{ needs.build-and-push.outputs.calver_tag }}" + git commit -m "ci(dev): update cartsnitch and auth images to ${{ needs.build-and-push.outputs.calver_tag }}" git push origin main