cs_betty/cartsnitch-fork-test
1
0
Fork 0
forked from cartsnitch/cartsnitch
Code Pull Requests Activity

fix(api): widen alembic_version.version_num in migration 001 (CAR-1302)

Browse Source 
Alembic hardcodes alembic_version.version_num to VARCHAR(32) in
DefaultImpl.version_table_impl, and version_table_column_width is NOT a
real kwarg that context.configure() honors — it's silently ignored, so
the env.py change alone was never going to take effect on a fresh DB.

Our descriptive revision ids exceed 32 chars (e.g. 003_make_users_hashed_
password_nullable = 39, common 002_add_normalized_products_upc_variants_
index = 46), so the 003 / common 002 stamp fails with StringDataRight-
Truncation, the whole chain rolls back, and the column is recreated at
VARCHAR(32) on the next attempt.

Fix:
- api/alembic/versions/001_encrypt_session_data.py: insert ALTER TABLE
  alembic_version ALTER COLUMN version_num TYPE VARCHAR(128) as the very
  first statement of upgrade(), before any early-return path. Idempotent
  when the column is already wider (e.g. the CAR-1298 one-shot Job).
- common/alembic/versions/001_add_email_inbound_token.py: same defensive
  ALTER as the first statement of upgrade() (common is a library, not
  deployed, but the 46-char 002 id would have hit the same trap).
- api/alembic/env.py: remove the phantom version_table_column_width=128
  kwarg from both context.configure() call sites — it was a no-op and
  misled the original investigation.

No downgrade() changes: a matching narrowing could truncate.

Refs CAR-1302 (durable root fix), CAR-1298 (prod workaround this
replaces). Verified against a fresh PostgreSQL — all 9 api migrations
upgrade head with no StringDataRightTruncation, and common 001/002 stamp
the 46-char id cleanly. Cluster has pgcrypto enabled by the operator.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
Barcode Betty
2026-06-06 16:51:56 +00:00
parent 993302c72c
commit 2d025db1be
3 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
api/alembic/versions/001_encrypt_session_data.py
+9
View File
@@ -33,6 +33,15 @@ def _is_fernet_token(value: str) -> bool:
def upgrade() -> None:
# Alembic hardcodes alembic_version.version_num to VARCHAR(32)
# (DefaultImpl.version_table_impl) and exposes no option to widen it
# (version_table_column_width is NOT a real kwarg — it is silently ignored).
# Our descriptive revision ids exceed 32 chars (e.g.
# 003_make_users_hashed_password_nullable = 39), so widen the column as the
# very first migration statement, before any early-return path below.
# Idempotent: a no-op when already wider (e.g. pre-created by the CAR-1298 Job).
op.execute("ALTER TABLE alembic_version ALTER COLUMN version_num TYPE VARCHAR(128)")
conn = op.get_bind()
inspector = sa.inspect(conn)