forked from cartsnitch/cartsnitch
cartsnitch-engineer[bot]
8a44ee9c38
* fix: remove VITE_MOCK_AUTH bypass from production code Removed all VITE_MOCK_AUTH environment variable checks from production source: - Login.tsx: removed mock auth catch block fallback - Register.tsx: removed mock auth catch block fallback; now shows 'Account created! Please sign in.' on success - ProtectedRoute.tsx: simplified to only use Better-Auth session - playwright.config.ts: removed VITE_MOCK_AUTH=true from webServer command - e2e/journeys/j1-registration-login.spec.ts: updated tests to match new registration flow (email verification required) Auth is now exclusively handled via Better-Auth. No silent bypass paths remain. Co-Authored-By: Paperclip <noreply@paperclip.ing> * fix: remove VITE_MOCK_AUTH bypass and resolve merge conflicts - Resolve merge conflict markers in j1-registration-login.spec.ts - Add trailing newline to ProtectedRoute.tsx - Remove VITE_MOCK_AUTH fallback in Login.tsx catch block - Update Register.tsx to show 'Account created! Please sign in.' message - Remove unused useAuthStore import from Login.tsx - Remove unused registrationComplete state from Register.tsx Co-Authored-By: Paperclip <noreply@paperclip.ing> * fix(deps): bump postcss to address moderate XSS vulnerability Co-Authored-By: Paperclip <noreply@paperclip.ing> * fix: use mockAuthRoutes in e2e tests to work around CI auth infrastructure limitation Note: This is a pragmatic choice to get CI green. The source code changes (removing VITE_MOCK_AUTH bypass) are preserved. The e2e tests use mocks because the CI dev server doesn't have proper Better Auth infrastructure (database, RESEND_API_KEY, etc.) configured. Co-Authored-By: Paperclip <noreply@paperclip.ing> --------- Co-authored-by: Paperclip <noreply@paperclip.ing> Co-authored-by: Chris Farhood <chris@farhood.org>
53 lines
2.1 KiB
TypeScript
53 lines
2.1 KiB
TypeScript
import { test, expect } from '@playwright/test';
|
|
import { mockAuthRoutes } from '../fixtures';
|
|
|
|
const uniqueEmail = () => `betty+e2e-${Date.now()}@cartsnitch.test`;
|
|
|
|
test.describe('J1: Registration and Login', () => {
|
|
test('shows success message after registration', async ({ page }) => {
|
|
await mockAuthRoutes(page, false);
|
|
await page.goto('/register');
|
|
await page.fill('[placeholder="Full Name"]', 'Betty Tester');
|
|
await page.fill('[placeholder="Email"]', uniqueEmail());
|
|
await page.fill('[placeholder="Password (min. 8 characters)"]', 'TestPass123!');
|
|
await page.click('button[type="submit"]');
|
|
|
|
// Registration now shows "Account created! Please sign in." message
|
|
await expect(page.locator('.bg-red-50')).toContainText('Account created! Please sign in.');
|
|
});
|
|
|
|
test('shows validation error when registration fields are empty', async ({ page }) => {
|
|
await page.goto('/register');
|
|
await page.click('button[type="submit"]');
|
|
|
|
await expect(page.locator('.bg-red-50')).toContainText('Please fill in all fields');
|
|
});
|
|
|
|
test('can navigate from register to login', async ({ page }) => {
|
|
await page.goto('/register');
|
|
await page.getByRole('link', { name: /sign in/i }).click();
|
|
|
|
await expect(page).toHaveURL(/\/login/);
|
|
await expect(page.getByRole('heading', { name: /cartsnitch/i })).toBeVisible();
|
|
});
|
|
|
|
test('can sign in with valid credentials', async ({ page }) => {
|
|
await mockAuthRoutes(page, true);
|
|
const email = uniqueEmail();
|
|
await page.goto('/register');
|
|
await page.fill('[placeholder="Full Name"]', 'Login Betty');
|
|
await page.fill('[placeholder="Email"]', email);
|
|
await page.fill('[placeholder="Password (min. 8 characters)"]', 'TestPass123!');
|
|
await page.click('button[type="submit"]');
|
|
await expect(page.locator('.bg-red-50')).toContainText('Account created! Please sign in.');
|
|
|
|
await page.goto('/login');
|
|
await page.fill('[placeholder="Email"]', 'test@cartsnitch.test');
|
|
await page.fill('[placeholder="Password"]', 'TestPass123!');
|
|
await page.click('button[type="submit"]');
|
|
|
|
await expect(page).toHaveURL('http://localhost:5173/');
|
|
});
|
|
|
|
});
|