forked from farhoodlabs/paperclip
Polish operator UI task controls (#5427)
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies > - Operators spend most of their day scanning skills, routines, inbox groups, and activity cards > - Several small UI rough edges made those surfaces harder to scan or easier to crash on real API payloads > - These fixes are grouped together because they are low-risk operator quality-of-life improvements rather than separate control-plane contracts > - This pull request polishes skills metadata, routine run-now access, grouped issue creation defaults, monitor activity rendering, and activity row identity layout > - The benefit is a smoother board workflow with fewer small interruptions while keeping the change set compact ## What Changed - Improves company skill source display and the used-by agent list. - Truncates long skill source paths and adds a copy affordance. - Adds a row-level run-now button to the routines table. - Adds grouped issue creation defaults for inbox issue groups and aligns grouped add buttons to the right. - Fixes `IssueMonitorActivityCard` when `monitorNextCheckAt` arrives as an ISO string. - Polishes activity row actor avatar/name layout by using the shared avatar primitive. ## Verification - `pnpm run preflight:workspace-links && pnpm exec vitest run ui/src/pages/Routines.test.tsx ui/src/components/IssuesList.test.tsx ui/src/lib/inbox.test.ts ui/src/components/IssueMonitorActivityCard.test.tsx` — 91 passed. - The routines test emitted the pre-existing Radix warning about missing `DialogTitle`/description in dialog content; tests still passed. - Pairwise merge checks against the other two PR branches reported no textual conflicts. ## Risks - Low: changes are UI-focused and covered by targeted component/lib tests. - Low-to-medium: activity row layout changes could affect dense feed scanability; the implementation uses the shared avatar component and keeps truncation behavior. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex coding agent, GPT-5 model family (`gpt-5`), tool-enabled Paperclip heartbeat environment. Context window and internal reasoning mode are not exposed by the runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
This commit is contained in:
@@ -13,6 +13,7 @@ import type {
|
||||
import {
|
||||
DEFAULT_INBOX_ISSUE_COLUMNS,
|
||||
buildGroupedInboxSections,
|
||||
buildInboxIssueGroupCreateDefaults,
|
||||
buildInboxKeyboardNavEntries,
|
||||
buildInboxDismissedAtByKey,
|
||||
computeInboxBadgeData,
|
||||
@@ -1379,6 +1380,61 @@ describe("inbox helpers", () => {
|
||||
]);
|
||||
});
|
||||
|
||||
it("builds new issue defaults from inbox project, assignee, and workspace groups", () => {
|
||||
const projectIssue = makeIssue("project", true);
|
||||
projectIssue.projectId = "project-1";
|
||||
|
||||
const executionIssue = makeIssue("exec", false);
|
||||
executionIssue.projectId = "project-1";
|
||||
executionIssue.projectWorkspaceId = "project-workspace-1";
|
||||
executionIssue.executionWorkspaceId = "execution-workspace-1";
|
||||
|
||||
const agentIssue = makeIssue("agent", false);
|
||||
agentIssue.assigneeAgentId = "agent-1";
|
||||
|
||||
const options = {
|
||||
executionWorkspaceById: new Map([
|
||||
[
|
||||
"execution-workspace-1",
|
||||
{
|
||||
name: "Feature Branch",
|
||||
mode: "isolated_workspace" as const,
|
||||
projectWorkspaceId: "project-workspace-1",
|
||||
},
|
||||
],
|
||||
]),
|
||||
projectWorkspaceById: new Map([
|
||||
["project-workspace-1", { name: "Primary workspace", projectId: "project-1" }],
|
||||
]),
|
||||
};
|
||||
|
||||
expect(buildInboxIssueGroupCreateDefaults(
|
||||
"project:project-1",
|
||||
"project",
|
||||
[{ kind: "issue", timestamp: 1, issue: projectIssue }],
|
||||
options,
|
||||
)).toEqual({ projectId: "project-1" });
|
||||
|
||||
expect(buildInboxIssueGroupCreateDefaults(
|
||||
"workspace:execution:execution-workspace-1",
|
||||
"workspace",
|
||||
[{ kind: "issue", timestamp: 1, issue: executionIssue }],
|
||||
options,
|
||||
)).toEqual({
|
||||
executionWorkspaceId: "execution-workspace-1",
|
||||
executionWorkspaceMode: "reuse_existing",
|
||||
projectId: "project-1",
|
||||
projectWorkspaceId: "project-workspace-1",
|
||||
});
|
||||
|
||||
expect(buildInboxIssueGroupCreateDefaults(
|
||||
"assignee:agent:agent-1",
|
||||
"assignee",
|
||||
[{ kind: "issue", timestamp: 1, issue: agentIssue }],
|
||||
options,
|
||||
)).toEqual({ assigneeAgentId: "agent-1" });
|
||||
});
|
||||
|
||||
it("persists inbox grouping preferences", () => {
|
||||
saveInboxWorkItemGroupBy("workspace");
|
||||
expect(loadInboxWorkItemGroupBy()).toBe("workspace");
|
||||
|
||||
Reference in New Issue
Block a user