forked from farhoodlabs/paperclip
Devin Foley
1f70fd9a22
## Thinking Path > - Paperclip orchestrates AI agents across isolated execution workspaces; the local cwd is the only persistence boundary between runs. > - Workspace lifecycle (worktree_prepare → execute → workspace_finalize) and the wake/accept flow are what guarantee that dependent issues see a consistent worktree. > - PAPA-380 / PAPA-431 / PAPA-432 / PAPA-440 surfaced three holes in that contract: silent env reuse across assignees, dependent wakes firing before finalize, and `issue.interaction.accept` advancing before finalize landed. > - PAPA-441 / PAPA-442 then needed to document the "no remote git" contract and prevent future adapter/runtime code from quietly reintroducing `git push` as a backdoor sync. > - This pull request lands those server fixes, the static `check-no-git-push` enforcement, the AUTHORING.md cross-link, and the Cody-review follow-ups on the PAPA-430 thread. > - The benefit is that finalize is a real barrier — board accepts, dependent wakes, and operator-set env all respect it — and adapter code can't bypass it via raw `git push`. ## What Changed - **server (PAPA-380, PAPA-431):** `execution-workspace-policy` refuses silent env reuse when the assignee's resolved env disagrees with the workspace it would inherit. The inheritance protection is now scoped to the actual inheritance signal — explicit issue-level `environmentId` is honored even when the agent's default env is `null`. - **server (PAPA-432):** `heartbeat.ts` gates dependent wakes on `listUnfinalizedExecutionWorkspaceIds`, and writes a `workspace_finalize` row on the succeeded path. Write failures now surface instead of being swallowed so dependents aren't silently stranded behind a missing row. - **server (PAPA-440):** `issue-thread-interactions.acceptInteraction` adds a workspace_finalize precondition for `request_confirmation` (not `suggest_tasks`). Accept returns 409 if finalize hasn't succeeded for the latest workspace operation. - **ci (PAPA-442):** new `scripts/check-no-git-push.mjs` static check scans `packages/adapters/`, `packages/adapter-utils/`, `server/src/`, and `cli/src/` for any `git push` invocation (string or args-array). Wired into the `policy` PR job and `test:release-registry`. Operators can opt in per-call with `// paperclip:allow-git-push: <reason>`. Release scripts are out of scope by design. - **docs (PAPA-441):** `AUTHORING.md` documents the no-remote-git contract and cross-links the static check so adapter authors learn the rule and the enforcement together. - **review follow-up (PAPA-430, Cody):** three fixes — env resolver bug, accept-gate scope (request_confirmation only), and finalize record write on the succeeded path. ## Verification - `pnpm exec vitest run server/src/__tests__/execution-workspace-policy.test.ts server/src/__tests__/issue-thread-interactions-service.test.ts` → 33/33 pass - `node scripts/check-no-git-push.test.mjs` → check covers string form, args-array form, comment exclusions, and per-line allow-comment. - Manual: server compiles; the policy job runs the check in <1s before heavier jobs. ## Risks - **Behavioral shift in accept:** boards accepting `request_confirmation` while finalize is in-flight now get 409s. This is intentional — they can retry — but it changes timing on a hot path. `suggest_tasks` is unaffected. - **Workspace policy:** the env-reuse refusal is a new error path. Issues that previously silently reused an env from a different-assignee workspace will now fail-loud; the resolver still honors explicit issue-level `executionWorkspaceSettings.environmentId`. - **CI rule:** any future legitimate `git push` in scoped dirs must be marked with the allow-comment, which is the intended ergonomic. ## Model Used - Claude Opus 4.7 (`claude-opus-4-7`, extended thinking), via Claude Code in the Paperclip executor adapter. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots (N/A — server/CI/docs only) - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge Closes related issues: PAPA-430, PAPA-380, PAPA-431, PAPA-432, PAPA-440, PAPA-441, PAPA-442 --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
664 lines
14 KiB
JSON
664 lines
14 KiB
JSON
{
|
|
"version": "7",
|
|
"dialect": "postgresql",
|
|
"entries": [
|
|
{
|
|
"idx": 0,
|
|
"version": "7",
|
|
"when": 1771300567463,
|
|
"tag": "0000_mature_masked_marvel",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 1,
|
|
"version": "7",
|
|
"when": 1771349039633,
|
|
"tag": "0001_fast_northstar",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 2,
|
|
"version": "7",
|
|
"when": 1771349403162,
|
|
"tag": "0002_big_zaladane",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 3,
|
|
"version": "7",
|
|
"when": 1771456737635,
|
|
"tag": "0003_shallow_quentin_quire",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 4,
|
|
"version": "7",
|
|
"when": 1771545600000,
|
|
"tag": "0004_issue_identifiers",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 5,
|
|
"version": "7",
|
|
"when": 1771545601000,
|
|
"tag": "0005_chief_luke_cage",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 6,
|
|
"version": "7",
|
|
"when": 1771545602000,
|
|
"tag": "0006_overjoyed_mister_sinister",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 7,
|
|
"version": "7",
|
|
"when": 1771545603000,
|
|
"tag": "0007_new_quentin_quire",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 8,
|
|
"version": "7",
|
|
"when": 1771534160426,
|
|
"tag": "0008_amused_zzzax",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 9,
|
|
"version": "7",
|
|
"when": 1771534211029,
|
|
"tag": "0009_fast_jackal",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 10,
|
|
"version": "7",
|
|
"when": 1771605173513,
|
|
"tag": "0010_stale_justin_hammer",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 11,
|
|
"version": "7",
|
|
"when": 1771616419708,
|
|
"tag": "0011_windy_corsair",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 12,
|
|
"version": "7",
|
|
"when": 1771619674673,
|
|
"tag": "0012_perpetual_ser_duncan",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 13,
|
|
"version": "7",
|
|
"when": 1771623691139,
|
|
"tag": "0013_dashing_wasp",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 14,
|
|
"version": "7",
|
|
"when": 1771691806349,
|
|
"tag": "0014_many_mikhail_rasputin",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 15,
|
|
"version": "7",
|
|
"when": 1771865100000,
|
|
"tag": "0015_project_color_archived",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 16,
|
|
"version": "7",
|
|
"when": 1771955900000,
|
|
"tag": "0016_agent_icon",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 17,
|
|
"version": "7",
|
|
"when": 1771883888199,
|
|
"tag": "0017_tiresome_gabe_jones",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 18,
|
|
"version": "7",
|
|
"when": 1771897769629,
|
|
"tag": "0018_flat_sleepwalker",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 19,
|
|
"version": "7",
|
|
"when": 1772029333401,
|
|
"tag": "0019_public_victor_mancha",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 20,
|
|
"version": "7",
|
|
"when": 1772032176413,
|
|
"tag": "0020_white_anita_blake",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 21,
|
|
"version": "7",
|
|
"when": 1772122471656,
|
|
"tag": "0021_chief_vindicator",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 22,
|
|
"version": "7",
|
|
"when": 1772186400000,
|
|
"tag": "0022_company_brand_color",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 23,
|
|
"version": "7",
|
|
"when": 1772139727599,
|
|
"tag": "0023_fair_lethal_legion",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 24,
|
|
"version": "7",
|
|
"when": 1772806603601,
|
|
"tag": "0024_far_beast",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 25,
|
|
"version": "7",
|
|
"when": 1772807461603,
|
|
"tag": "0025_nasty_salo",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 26,
|
|
"version": "7",
|
|
"when": 1773089625430,
|
|
"tag": "0026_lying_pete_wisdom",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 27,
|
|
"version": "7",
|
|
"when": 1773150731736,
|
|
"tag": "0027_tranquil_tenebrous",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 28,
|
|
"version": "7",
|
|
"when": 1773432085646,
|
|
"tag": "0028_harsh_goliath",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 29,
|
|
"version": "7",
|
|
"when": 1773417600000,
|
|
"tag": "0029_plugin_tables",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 30,
|
|
"version": "7",
|
|
"when": 1773670925214,
|
|
"tag": "0030_rich_magneto",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 31,
|
|
"version": "7",
|
|
"when": 1773511922713,
|
|
"tag": "0031_zippy_magma",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 32,
|
|
"version": "7",
|
|
"when": 1773542934499,
|
|
"tag": "0032_pretty_doctor_octopus",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 33,
|
|
"version": "7",
|
|
"when": 1773664961967,
|
|
"tag": "0033_shiny_black_tarantula",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 34,
|
|
"version": "7",
|
|
"when": 1773697572188,
|
|
"tag": "0034_fat_dormammu",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 35,
|
|
"version": "7",
|
|
"when": 1773698696169,
|
|
"tag": "0035_marvelous_satana",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 36,
|
|
"version": "7",
|
|
"when": 1773756213455,
|
|
"tag": "0036_cheerful_nitro",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 37,
|
|
"version": "7",
|
|
"when": 1773756922363,
|
|
"tag": "0037_friendly_eddie_brock",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 38,
|
|
"version": "7",
|
|
"when": 1773931592563,
|
|
"tag": "0038_careless_iron_monger",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 39,
|
|
"version": "7",
|
|
"when": 1773926116580,
|
|
"tag": "0039_fat_magneto",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 40,
|
|
"version": "7",
|
|
"when": 1773927102783,
|
|
"tag": "0040_eager_shotgun",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 41,
|
|
"version": "7",
|
|
"when": 1774011294562,
|
|
"tag": "0041_curly_maria_hill",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 42,
|
|
"version": "7",
|
|
"when": 1774031825634,
|
|
"tag": "0042_spotty_the_renegades",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 43,
|
|
"version": "7",
|
|
"when": 1774008910991,
|
|
"tag": "0043_reflective_captain_universe",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 44,
|
|
"version": "7",
|
|
"when": 1774269579794,
|
|
"tag": "0044_illegal_toad",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 45,
|
|
"version": "7",
|
|
"when": 1774530504348,
|
|
"tag": "0045_workable_shockwave",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 46,
|
|
"version": "7",
|
|
"when": 1774960197878,
|
|
"tag": "0046_smooth_sentinels",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 47,
|
|
"version": "7",
|
|
"when": 1775137972687,
|
|
"tag": "0047_overjoyed_groot",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 48,
|
|
"version": "7",
|
|
"when": 1775145655557,
|
|
"tag": "0048_flashy_marrow",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 49,
|
|
"version": "7",
|
|
"when": 1775349863293,
|
|
"tag": "0049_flawless_abomination",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 50,
|
|
"version": "7",
|
|
"when": 1775487782768,
|
|
"tag": "0050_stiff_luckman",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 51,
|
|
"version": "7",
|
|
"when": 1775524651831,
|
|
"tag": "0051_young_korg",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 52,
|
|
"version": "7",
|
|
"when": 1775571715162,
|
|
"tag": "0052_mushy_trauma",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 53,
|
|
"version": "7",
|
|
"when": 1775604018515,
|
|
"tag": "0053_sharp_wild_child",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 54,
|
|
"version": "7",
|
|
"when": 1775750400000,
|
|
"tag": "0054_draft_routines",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 55,
|
|
"version": "7",
|
|
"when": 1775825256196,
|
|
"tag": "0055_kind_weapon_omega",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 56,
|
|
"version": "7",
|
|
"when": 1776084034244,
|
|
"tag": "0056_spooky_ultragirl",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 57,
|
|
"version": "7",
|
|
"when": 1776309613598,
|
|
"tag": "0057_tidy_join_requests",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 58,
|
|
"version": "7",
|
|
"when": 1776542245004,
|
|
"tag": "0058_wealthy_starbolt",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 59,
|
|
"version": "7",
|
|
"when": 1776542246000,
|
|
"tag": "0059_plugin_database_namespaces",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 60,
|
|
"version": "7",
|
|
"when": 1776717606743,
|
|
"tag": "0060_orange_annihilus",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 61,
|
|
"version": "7",
|
|
"when": 1776785165389,
|
|
"tag": "0061_lively_thor_girl",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 62,
|
|
"version": "7",
|
|
"when": 1776780000000,
|
|
"tag": "0062_routine_run_dispatch_fingerprint",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 63,
|
|
"version": "7",
|
|
"when": 1776780001000,
|
|
"tag": "0063_issue_thread_interactions",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 64,
|
|
"version": "7",
|
|
"when": 1776780002000,
|
|
"tag": "0064_issue_thread_interaction_idempotency",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 65,
|
|
"version": "7",
|
|
"when": 1776903900000,
|
|
"tag": "0065_environments",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 66,
|
|
"version": "7",
|
|
"when": 1776903901000,
|
|
"tag": "0066_issue_tree_holds",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 67,
|
|
"version": "7",
|
|
"when": 1776904200000,
|
|
"tag": "0067_agent_default_environment",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 68,
|
|
"version": "7",
|
|
"when": 1776959400000,
|
|
"tag": "0068_environment_local_driver_unique",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 69,
|
|
"version": "7",
|
|
"when": 1776780003000,
|
|
"tag": "0069_liveness_recovery_dedupe",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 70,
|
|
"version": "7",
|
|
"when": 1776780004000,
|
|
"tag": "0070_active_run_output_watchdog",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 71,
|
|
"version": "7",
|
|
"when": 1777131234000,
|
|
"tag": "0071_default_hire_approval_off",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 72,
|
|
"version": "7",
|
|
"when": 1777305216238,
|
|
"tag": "0072_large_sandman",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 73,
|
|
"version": "7",
|
|
"when": 1777382021347,
|
|
"tag": "0073_shiny_salo",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 74,
|
|
"version": "7",
|
|
"when": 1777384535070,
|
|
"tag": "0074_striped_genesis",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 75,
|
|
"version": "7",
|
|
"when": 1777572332006,
|
|
"tag": "0075_cultured_sebastian_shaw",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 76,
|
|
"version": "7",
|
|
"when": 1777675301279,
|
|
"tag": "0076_useful_elektra",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 77,
|
|
"version": "7",
|
|
"when": 1777933347806,
|
|
"tag": "0077_unusual_karnak",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 78,
|
|
"version": "7",
|
|
"when": 1778004024976,
|
|
"tag": "0078_white_darwin",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 79,
|
|
"version": "7",
|
|
"when": 1777821410992,
|
|
"tag": "0079_company_search_document_indexes",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 80,
|
|
"version": "7",
|
|
"when": 1777849000000,
|
|
"tag": "0080_company_search_fuzzystrmatch",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 81,
|
|
"version": "7",
|
|
"when": 1778067785040,
|
|
"tag": "0081_optimal_dormammu",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 82,
|
|
"version": "7",
|
|
"when": 1778067785041,
|
|
"tag": "0082_dry_vision",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 83,
|
|
"version": "7",
|
|
"when": 1778074536410,
|
|
"tag": "0083_company_secret_provider_configs",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 84,
|
|
"version": "7",
|
|
"when": 1778355326070,
|
|
"tag": "0084_issue_recovery_actions",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 85,
|
|
"version": "7",
|
|
"when": 1778787362162,
|
|
"tag": "0085_tranquil_the_executioner",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 86,
|
|
"version": "7",
|
|
"when": 1778976000000,
|
|
"tag": "0086_routine_env_runtime_contract",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 87,
|
|
"version": "7",
|
|
"when": 1779360000000,
|
|
"tag": "0087_backfill_environment_manage_human_defaults",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 88,
|
|
"version": "7",
|
|
"when": 1779446400000,
|
|
"tag": "0088_backfill_principal_access_compatibility",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 89,
|
|
"version": "7",
|
|
"when": 1779129600000,
|
|
"tag": "0089_cloud_upstreams",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 90,
|
|
"version": "7",
|
|
"when": 1779573019125,
|
|
"tag": "0090_resource_memberships",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 91,
|
|
"version": "7",
|
|
"when": 1778810394522,
|
|
"tag": "0091_old_swarm",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 92,
|
|
"version": "7",
|
|
"when": 1779999768200,
|
|
"tag": "0092_mighty_puma",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 93,
|
|
"version": "7",
|
|
"when": 1780040470886,
|
|
"tag": "0093_giant_green_goblin",
|
|
"breakpoints": true
|
|
}
|
|
]
|
|
} |