forked from farhoodlabs/paperclip
320fd5d23b
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies. > - Operators need to find work, documents, agents, projects, comments, and activity across a company without jumping through separate surfaces. > - The existing Command-K flow was useful for fast navigation but not enough for deeper company-wide discovery. > - Search also needs company-scoped backend contracts, query cost controls, and indexed document matching so it stays safe as company data grows. > - This pull request adds a full company search API and a dedicated board search page that Command-K can hand off to. > - The benefit is a single searchable control-plane surface with richer result context, recents, highlights, and test coverage across server and UI behavior. ## What Changed - Added a company-scoped search endpoint/service with query validation, rate limiting, text matching, fuzzy title matching, and result typing shared through `@paperclipai/shared`. - Added idempotent search migrations for document search indexes and fuzzy matching support. - Added the full `/companies/:companyKey/search` UI, search result row components, highlighted snippets, recent searches, and sidebar/Command-K handoff. - Added Storybook coverage for search surfaces and Vitest coverage for server search behavior, rate limiting, route generation, Command-K behavior, and the search page. - Addressed Greptile findings by renaming the no-match SQL helper, applying search pagination after cross-type merge sorting, and lazy-initializing the default search service so unrelated route-test mocks do not need to know about it. - Merged current `public-gh/master` and renumbered the search migrations behind upstream `0078_white_darwin`: search indexes are now `0079_company_search_document_indexes` and fuzzy matching is `0080_company_search_fuzzystrmatch`. ## Verification - `git fetch public-gh master` - `git diff --check public-gh/master...HEAD` - `git diff --name-only public-gh/master...HEAD | rg '^pnpm-lock\.yaml$' || true` produced no output before opening the PR. - `pnpm run preflight:workspace-links && pnpm exec vitest run server/src/__tests__/company-search-service.test.ts server/src/__tests__/company-search-rate-limit-routes.test.ts ui/src/pages/Search.test.tsx ui/src/components/CommandPalette.test.tsx ui/src/lib/company-routes.test.ts` passed: 5 files, 25 tests. - `pnpm --filter @paperclipai/shared typecheck && pnpm --filter @paperclipai/db typecheck && pnpm --filter @paperclipai/server typecheck && pnpm --filter @paperclipai/ui typecheck` passed. - `pnpm exec vitest run server/src/__tests__/company-search-service.test.ts server/src/__tests__/company-search-rate-limit-routes.test.ts && pnpm --filter @paperclipai/server typecheck` passed after Greptile pagination fixes. - `pnpm exec vitest run server/src/__tests__/issue-agent-mutation-ownership-routes.test.ts server/src/__tests__/company-search-rate-limit-routes.test.ts server/src/__tests__/company-search-service.test.ts && pnpm --filter @paperclipai/server typecheck` passed after the CI mock fix. - After resolving the migration conflict with current `public-gh/master`: `pnpm --filter @paperclipai/db typecheck && pnpm exec vitest run server/src/__tests__/company-search-service.test.ts server/src/__tests__/company-search-rate-limit-routes.test.ts && pnpm --filter @paperclipai/server typecheck` passed. - DB migration numbering check passed as part of `@paperclipai/db` typecheck. - UI states are covered by the added Storybook stories in `ui/storybook/stories/search.stories.tsx`. - GitHub reports the PR merge state as `CLEAN` on head `18e54fa8`. - GitHub PR checks are green on head `18e54fa8`: policy, verify, serialized server shards 1/4 through 4/4, e2e, canary dry run, Snyk, and Greptile Review. ## Risks - Search ranking and snippets are new user-facing behavior, so reviewers should check whether result ordering feels right on real company data. - Search touches broad company data, so company scoping and query cost/rate-limit behavior should be reviewed carefully. - The migrations add search indexes/extensions; they are idempotent with `IF NOT EXISTS` for users who may have applied an earlier branch migration number. > ROADMAP.md checked. This PR adds a focused board search surface and does not duplicate an open roadmap item. ## Model Used - OpenAI Codex, GPT-5 coding agent, tool-enabled shell/git/GitHub CLI session with medium reasoning effort. Existing branch commits were produced across prior agent sessions; this packaging pass verified, opened the PR, addressed Greptile findings, resolved migration conflicts after upstream PRs landed, and got PR checks green. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
632 lines
23 KiB
TypeScript
632 lines
23 KiB
TypeScript
import { useCallback, useEffect, useMemo, useRef, useState } from "react";
|
||
import { useQuery } from "@tanstack/react-query";
|
||
import { Search as SearchIcon, AlertTriangle, FileQuestion, Plus, X } from "lucide-react";
|
||
import {
|
||
COMPANY_SEARCH_DEFAULT_LIMIT,
|
||
COMPANY_SEARCH_SCOPES,
|
||
type CompanySearchResponse,
|
||
type CompanySearchResult,
|
||
type CompanySearchScope,
|
||
} from "@paperclipai/shared";
|
||
import { Tabs, TabsContent } from "@/components/ui/tabs";
|
||
import { Input } from "@/components/ui/input";
|
||
import { Button } from "@/components/ui/button";
|
||
import { Skeleton } from "@/components/ui/skeleton";
|
||
import { Badge } from "@/components/ui/badge";
|
||
import { cn } from "@/lib/utils";
|
||
import { useNavigate, useSearchParams } from "@/lib/router";
|
||
import { useCompany } from "../context/CompanyContext";
|
||
import { useBreadcrumbs } from "../context/BreadcrumbContext";
|
||
import { useDialogActions } from "../context/DialogContext";
|
||
import { searchApi } from "../api/search";
|
||
import { agentsApi } from "../api/agents";
|
||
import { queryKeys } from "../lib/queryKeys";
|
||
import { loadRecentSearches, pushRecentSearch } from "../lib/recent-searches";
|
||
import { PageTabBar, type PageTabItem } from "../components/PageTabBar";
|
||
import { IssueGroupHeader } from "../components/IssueGroupHeader";
|
||
import { SearchResultRow } from "../components/search/SearchResultRow";
|
||
import type { Agent } from "@paperclipai/shared";
|
||
|
||
const SEARCH_DEBOUNCE_MS = 250;
|
||
const IDENTIFIER_PATTERN = /^[A-Z]+-\d+$/;
|
||
|
||
const SCOPE_LABELS: Record<CompanySearchScope, string> = {
|
||
all: "All",
|
||
issues: "Issues",
|
||
comments: "Comments",
|
||
documents: "Documents",
|
||
agents: "Agents",
|
||
projects: "Projects",
|
||
};
|
||
|
||
type SubGroupKey = "issues" | "comments" | "documents" | "agents" | "projects";
|
||
|
||
const SUBGROUP_ORDER: SubGroupKey[] = ["issues", "comments", "documents", "agents", "projects"];
|
||
|
||
const SUBGROUP_LABELS: Record<SubGroupKey, string> = {
|
||
issues: "Issues",
|
||
comments: "Comments",
|
||
documents: "Documents",
|
||
agents: "Agents",
|
||
projects: "Projects",
|
||
};
|
||
|
||
function classifyResult(result: CompanySearchResult): SubGroupKey {
|
||
if (result.type === "agent") return "agents";
|
||
if (result.type === "project") return "projects";
|
||
const matched = new Set(result.matchedFields);
|
||
if (matched.has("title") || matched.has("identifier") || matched.has("description")) return "issues";
|
||
if (matched.has("comment")) return "comments";
|
||
if (matched.has("document")) return "documents";
|
||
return "issues";
|
||
}
|
||
|
||
function buildSubgroups(results: CompanySearchResult[]): Array<{ key: SubGroupKey; results: CompanySearchResult[] }> {
|
||
const buckets = new Map<SubGroupKey, CompanySearchResult[]>();
|
||
for (const result of results) {
|
||
const key = classifyResult(result);
|
||
const list = buckets.get(key) ?? [];
|
||
list.push(result);
|
||
buckets.set(key, list);
|
||
}
|
||
return SUBGROUP_ORDER.filter((key) => (buckets.get(key)?.length ?? 0) > 0).map((key) => ({
|
||
key,
|
||
results: buckets.get(key) ?? [],
|
||
}));
|
||
}
|
||
|
||
function isCompanySearchScope(value: string | null): value is CompanySearchScope {
|
||
return Boolean(value) && (COMPANY_SEARCH_SCOPES as readonly string[]).includes(value as string);
|
||
}
|
||
|
||
function describeScope(scope: CompanySearchScope) {
|
||
if (scope === "all") return "All scopes";
|
||
return SCOPE_LABELS[scope];
|
||
}
|
||
|
||
export function buildSearchUrl(href: string, query: string, scope: CompanySearchScope): string {
|
||
const url = new URL(href);
|
||
if (query.length === 0) {
|
||
url.searchParams.delete("q");
|
||
} else {
|
||
url.searchParams.set("q", query);
|
||
}
|
||
if (scope === "all") {
|
||
url.searchParams.delete("scope");
|
||
} else {
|
||
url.searchParams.set("scope", scope);
|
||
}
|
||
return `${url.pathname}${url.search}${url.hash}`;
|
||
}
|
||
|
||
function shapeError(error: unknown): { message: string; status?: number } {
|
||
if (!error) return { message: "Unknown error" };
|
||
if (error instanceof Error) {
|
||
const status = (error as Error & { status?: number }).status;
|
||
return { message: error.message, status: typeof status === "number" ? status : undefined };
|
||
}
|
||
return { message: String(error) };
|
||
}
|
||
|
||
export function Search() {
|
||
const { selectedCompanyId } = useCompany();
|
||
const { setBreadcrumbs } = useBreadcrumbs();
|
||
const { openNewIssue } = useDialogActions();
|
||
const navigate = useNavigate();
|
||
const [searchParams] = useSearchParams();
|
||
|
||
const urlQuery = searchParams.get("q") ?? "";
|
||
const urlScopeRaw = searchParams.get("scope");
|
||
const urlScope: CompanySearchScope = isCompanySearchScope(urlScopeRaw) ? urlScopeRaw : "all";
|
||
|
||
const [draftQuery, setDraftQuery] = useState(urlQuery);
|
||
const [committedQuery, setCommittedQuery] = useState(urlQuery);
|
||
const [scope, setScope] = useState<CompanySearchScope>(urlScope);
|
||
const inputRef = useRef<HTMLInputElement | null>(null);
|
||
const lastUrlSyncRef = useRef<string>("");
|
||
const lastIdentifierRedirectRef = useRef<string>("");
|
||
const [recentSearches, setRecentSearches] = useState<string[]>([]);
|
||
|
||
useEffect(() => {
|
||
setBreadcrumbs([{ label: "Search" }]);
|
||
}, [setBreadcrumbs]);
|
||
|
||
useEffect(() => {
|
||
if (!selectedCompanyId) return;
|
||
setRecentSearches(loadRecentSearches(selectedCompanyId));
|
||
}, [selectedCompanyId]);
|
||
|
||
// Pull URL changes back into local state (e.g. browser back/forward).
|
||
useEffect(() => {
|
||
setDraftQuery(urlQuery);
|
||
setCommittedQuery(urlQuery);
|
||
}, [urlQuery]);
|
||
|
||
useEffect(() => {
|
||
setScope(urlScope);
|
||
}, [urlScope]);
|
||
|
||
// Debounce the draft query into committedQuery and write to URL via replaceState.
|
||
useEffect(() => {
|
||
if (draftQuery === committedQuery) return;
|
||
const handle = window.setTimeout(() => {
|
||
setCommittedQuery(draftQuery);
|
||
if (typeof window !== "undefined") {
|
||
const next = buildSearchUrl(window.location.href, draftQuery, scope);
|
||
if (next !== `${window.location.pathname}${window.location.search}${window.location.hash}` && next !== lastUrlSyncRef.current) {
|
||
lastUrlSyncRef.current = next;
|
||
window.history.replaceState(window.history.state, "", next);
|
||
}
|
||
}
|
||
}, SEARCH_DEBOUNCE_MS);
|
||
return () => window.clearTimeout(handle);
|
||
}, [draftQuery, committedQuery, scope]);
|
||
|
||
const handleScopeChange = useCallback(
|
||
(next: string) => {
|
||
if (!isCompanySearchScope(next) || next === scope) return;
|
||
setScope(next);
|
||
if (typeof window !== "undefined") {
|
||
const url = buildSearchUrl(window.location.href, committedQuery, next);
|
||
window.history.pushState(window.history.state, "", url);
|
||
}
|
||
},
|
||
[committedQuery, scope],
|
||
);
|
||
|
||
const trimmedQuery = committedQuery.trim();
|
||
const queryEnabled = !!selectedCompanyId && trimmedQuery.length > 0;
|
||
|
||
const { data, isFetching, error, refetch } = useQuery<CompanySearchResponse>({
|
||
queryKey: queryKeys.companySearch.search(
|
||
selectedCompanyId ?? "__no-company__",
|
||
trimmedQuery,
|
||
scope,
|
||
COMPANY_SEARCH_DEFAULT_LIMIT,
|
||
0,
|
||
),
|
||
queryFn: () =>
|
||
searchApi.search(selectedCompanyId!, {
|
||
q: trimmedQuery,
|
||
scope,
|
||
limit: COMPANY_SEARCH_DEFAULT_LIMIT,
|
||
}),
|
||
enabled: queryEnabled,
|
||
placeholderData: (previousData) => previousData,
|
||
});
|
||
|
||
const { data: agents } = useQuery({
|
||
queryKey: queryKeys.agents.list(selectedCompanyId!),
|
||
queryFn: () => agentsApi.list(selectedCompanyId!),
|
||
enabled: !!selectedCompanyId,
|
||
});
|
||
|
||
const agentsById = useMemo<ReadonlyMap<string, Pick<Agent, "id" | "name">>>(() => {
|
||
const map = new Map<string, Pick<Agent, "id" | "name">>();
|
||
for (const agent of agents ?? []) map.set(agent.id, agent);
|
||
return map;
|
||
}, [agents]);
|
||
|
||
// Persist recent searches once we have a successful response with a non-empty query.
|
||
useEffect(() => {
|
||
if (!selectedCompanyId) return;
|
||
if (!data || !trimmedQuery) return;
|
||
const next = pushRecentSearch(selectedCompanyId, trimmedQuery);
|
||
setRecentSearches(next);
|
||
}, [data, trimmedQuery, selectedCompanyId]);
|
||
|
||
// Identifier shortcut: when q matches PAP-123 and the API returns an exact identifier match, redirect to it.
|
||
useEffect(() => {
|
||
if (!data) return;
|
||
const upper = trimmedQuery.toUpperCase();
|
||
if (!IDENTIFIER_PATTERN.test(upper)) return;
|
||
if (lastIdentifierRedirectRef.current === upper) return;
|
||
const exact = data.results.find(
|
||
(result) => result.type === "issue" && result.issue?.identifier?.toUpperCase() === upper,
|
||
);
|
||
if (!exact?.issue) return;
|
||
lastIdentifierRedirectRef.current = upper;
|
||
// Strip the comment/document deep-link suffix so an exact identifier match
|
||
// lands on the issue root, not the top-scored snippet.
|
||
const baseHref = exact.href.split("#")[0] ?? exact.href;
|
||
const navigateHref = baseHref.startsWith("/") ? baseHref : `/${baseHref}`;
|
||
navigate(navigateHref, { replace: true });
|
||
}, [data, navigate, trimmedQuery]);
|
||
|
||
const handleClear = useCallback(() => {
|
||
setDraftQuery("");
|
||
setCommittedQuery("");
|
||
inputRef.current?.focus();
|
||
if (typeof window !== "undefined") {
|
||
const next = buildSearchUrl(window.location.href, "", scope);
|
||
window.history.replaceState(window.history.state, "", next);
|
||
}
|
||
}, [scope]);
|
||
|
||
const focusInput = useCallback(() => {
|
||
inputRef.current?.focus();
|
||
}, []);
|
||
|
||
// Global "/" focus shortcut.
|
||
useEffect(() => {
|
||
function handler(event: KeyboardEvent) {
|
||
if (event.key !== "/" || event.metaKey || event.ctrlKey || event.altKey) return;
|
||
const target = event.target as HTMLElement | null;
|
||
const tag = target?.tagName?.toLowerCase();
|
||
if (target?.isContentEditable || tag === "input" || tag === "textarea") return;
|
||
event.preventDefault();
|
||
focusInput();
|
||
}
|
||
window.addEventListener("keydown", handler);
|
||
return () => window.removeEventListener("keydown", handler);
|
||
}, [focusInput]);
|
||
|
||
const counts = data?.countsByType ?? { issue: 0, agent: 0, project: 0 };
|
||
const totalResults = data?.results.length ?? 0;
|
||
|
||
const tabItems = useMemo<PageTabItem[]>(() => {
|
||
function pill(value: number) {
|
||
if (!data) return null;
|
||
return (
|
||
<Badge variant="outline" className="ml-1.5 px-1.5 py-0 text-[10px] tabular-nums font-normal">
|
||
{value}
|
||
</Badge>
|
||
);
|
||
}
|
||
const issuesTotal = counts.issue ?? 0;
|
||
return COMPANY_SEARCH_SCOPES.map((value) => {
|
||
let count: number | null = null;
|
||
if (value === "all") count = (counts.issue ?? 0) + (counts.agent ?? 0) + (counts.project ?? 0);
|
||
else if (value === "issues") count = issuesTotal;
|
||
else if (value === "agents") count = counts.agent ?? 0;
|
||
else if (value === "projects") count = counts.project ?? 0;
|
||
return {
|
||
value,
|
||
label: (
|
||
<span className="flex items-center">
|
||
{SCOPE_LABELS[value as CompanySearchScope]}
|
||
{count !== null ? pill(count) : null}
|
||
</span>
|
||
),
|
||
} satisfies PageTabItem;
|
||
});
|
||
}, [counts, data]);
|
||
|
||
const subgroups = useMemo(() => buildSubgroups(data?.results ?? []), [data?.results]);
|
||
|
||
const showInitialState = !trimmedQuery;
|
||
const isLoading = queryEnabled && isFetching && !data;
|
||
const hasResults = !!data && totalResults > 0;
|
||
const isEmpty = !!data && !isFetching && totalResults === 0;
|
||
const hasError = !!error && !isLoading;
|
||
const apiError = hasError ? shapeError(error) : null;
|
||
const apiMessage = data?.results === undefined && data ? null : null;
|
||
void apiMessage;
|
||
|
||
function navigateIssuesFallback() {
|
||
navigate(`/issues?q=${encodeURIComponent(trimmedQuery)}`);
|
||
}
|
||
|
||
function handleRecentClick(value: string) {
|
||
setDraftQuery(value);
|
||
setCommittedQuery(value);
|
||
if (typeof window !== "undefined") {
|
||
const next = buildSearchUrl(window.location.href, value, scope);
|
||
window.history.replaceState(window.history.state, "", next);
|
||
}
|
||
}
|
||
|
||
function showAllScope() {
|
||
if (scope === "all") return;
|
||
handleScopeChange("all");
|
||
}
|
||
|
||
return (
|
||
<div className="flex h-full min-h-0 flex-col" data-page="search">
|
||
<div className="border-b border-border px-4 py-3 sm:px-6">
|
||
<h1 className="sr-only">Search</h1>
|
||
<div className="relative">
|
||
<SearchIcon className="pointer-events-none absolute left-3 top-1/2 h-4 w-4 -translate-y-1/2 text-muted-foreground" />
|
||
<Input
|
||
ref={inputRef}
|
||
autoFocus
|
||
value={draftQuery}
|
||
onChange={(event) => setDraftQuery(event.currentTarget.value)}
|
||
onKeyDown={(event) => {
|
||
if (event.key === "Escape") {
|
||
if (draftQuery.length > 0) {
|
||
event.preventDefault();
|
||
handleClear();
|
||
} else {
|
||
event.currentTarget.blur();
|
||
}
|
||
}
|
||
}}
|
||
placeholder="Search issues, comments, documents, agents, projects…"
|
||
aria-label="Search query"
|
||
className="h-10 pl-9 pr-20 text-sm"
|
||
/>
|
||
{draftQuery.length > 0 ? (
|
||
<button
|
||
type="button"
|
||
onClick={handleClear}
|
||
aria-label="Clear search"
|
||
className="absolute right-12 top-1/2 inline-flex h-6 w-6 -translate-y-1/2 items-center justify-center rounded-full text-muted-foreground hover:bg-accent/50"
|
||
>
|
||
<X className="h-3.5 w-3.5" />
|
||
</button>
|
||
) : null}
|
||
<kbd
|
||
aria-hidden
|
||
className="pointer-events-none absolute right-3 top-1/2 -translate-y-1/2 rounded border border-border bg-muted px-1.5 py-0.5 text-[10px] font-medium text-muted-foreground"
|
||
>
|
||
⌘K
|
||
</kbd>
|
||
</div>
|
||
</div>
|
||
|
||
<Tabs value={scope} onValueChange={handleScopeChange} className="flex h-full min-h-0 flex-col">
|
||
<div className="border-b border-border px-2 sm:px-4">
|
||
<PageTabBar items={tabItems} value={scope} onValueChange={handleScopeChange} align="start" />
|
||
</div>
|
||
|
||
{COMPANY_SEARCH_SCOPES.map((scopeValue) => (
|
||
<TabsContent
|
||
key={scopeValue}
|
||
value={scopeValue}
|
||
className="flex h-full min-h-0 flex-col overflow-y-auto"
|
||
>
|
||
{scopeValue === scope ? (
|
||
<SearchTabContent
|
||
showInitialState={showInitialState}
|
||
isLoading={isLoading}
|
||
hasResults={hasResults}
|
||
hasError={hasError}
|
||
apiError={apiError}
|
||
isEmpty={isEmpty}
|
||
trimmedQuery={trimmedQuery}
|
||
scope={scope}
|
||
showAllScope={showAllScope}
|
||
navigateIssuesFallback={navigateIssuesFallback}
|
||
openNewIssue={() => openNewIssue({ title: trimmedQuery })}
|
||
refetch={() => void refetch()}
|
||
recentSearches={recentSearches}
|
||
onRecentClick={handleRecentClick}
|
||
subgroups={subgroups}
|
||
totalResults={totalResults}
|
||
isFetching={isFetching && !!data}
|
||
agentsById={agentsById}
|
||
/>
|
||
) : null}
|
||
</TabsContent>
|
||
))}
|
||
</Tabs>
|
||
</div>
|
||
);
|
||
}
|
||
|
||
interface SearchTabContentProps {
|
||
showInitialState: boolean;
|
||
isLoading: boolean;
|
||
hasResults: boolean;
|
||
hasError: boolean;
|
||
apiError: { message: string; status?: number } | null;
|
||
isEmpty: boolean;
|
||
trimmedQuery: string;
|
||
scope: CompanySearchScope;
|
||
showAllScope: () => void;
|
||
navigateIssuesFallback: () => void;
|
||
openNewIssue: () => void;
|
||
refetch: () => void;
|
||
recentSearches: string[];
|
||
onRecentClick: (query: string) => void;
|
||
subgroups: Array<{ key: SubGroupKey; results: CompanySearchResult[] }>;
|
||
totalResults: number;
|
||
isFetching: boolean;
|
||
agentsById: ReadonlyMap<string, Pick<Agent, "id" | "name">>;
|
||
}
|
||
|
||
function SearchTabContent({
|
||
showInitialState,
|
||
isLoading,
|
||
hasResults,
|
||
hasError,
|
||
apiError,
|
||
isEmpty,
|
||
trimmedQuery,
|
||
scope,
|
||
showAllScope,
|
||
navigateIssuesFallback,
|
||
openNewIssue,
|
||
refetch,
|
||
recentSearches,
|
||
onRecentClick,
|
||
subgroups,
|
||
totalResults,
|
||
isFetching,
|
||
agentsById,
|
||
}: SearchTabContentProps) {
|
||
if (showInitialState) {
|
||
return (
|
||
<div className="mx-auto flex w-full max-w-2xl flex-col gap-4 px-4 py-10 sm:px-6">
|
||
<div>
|
||
<h2 className="text-lg font-semibold">Type to search company memory.</h2>
|
||
<p className="mt-1 text-sm text-muted-foreground">
|
||
Issues, comments, plan documents, agents, projects — same surface, ranked by relevance.
|
||
</p>
|
||
</div>
|
||
{recentSearches.length > 0 ? (
|
||
<div>
|
||
<div className="mb-2 text-[11px] font-semibold uppercase tracking-wide text-muted-foreground">
|
||
Recent searches
|
||
</div>
|
||
<ul className="flex flex-col divide-y divide-border rounded-md border border-border">
|
||
{recentSearches.map((entry) => (
|
||
<li key={entry}>
|
||
<button
|
||
type="button"
|
||
onClick={() => onRecentClick(entry)}
|
||
className="flex w-full items-center gap-2 px-3 py-2 text-left text-sm hover:bg-accent/40"
|
||
>
|
||
<SearchIcon className="h-3.5 w-3.5 text-muted-foreground" />
|
||
<span className="flex-1 truncate">{entry}</span>
|
||
</button>
|
||
</li>
|
||
))}
|
||
</ul>
|
||
</div>
|
||
) : null}
|
||
<ul className="space-y-1 text-xs text-muted-foreground">
|
||
<li>
|
||
<span className="font-medium text-foreground">Identifier lookup:</span> type{" "}
|
||
<code className="rounded bg-muted px-1 py-0.5 text-[11px]">PAP-123</code> to jump straight to an issue.
|
||
</li>
|
||
<li>
|
||
<span className="font-medium text-foreground">Quoted phrases:</span> wrap a phrase in quotes to match the
|
||
exact sequence.
|
||
</li>
|
||
<li>
|
||
<span className="font-medium text-foreground">⌘K:</span> reopens the command palette pre-seeded with your
|
||
current query.
|
||
</li>
|
||
</ul>
|
||
</div>
|
||
);
|
||
}
|
||
|
||
if (hasError) {
|
||
const status = apiError?.status;
|
||
return (
|
||
<div className="mx-auto flex w-full max-w-xl flex-col items-center justify-center gap-3 px-4 py-12 text-center">
|
||
<AlertTriangle className="h-10 w-10 text-destructive" aria-hidden />
|
||
<div className="text-base font-semibold">Couldn’t run that search</div>
|
||
<p className="text-sm text-muted-foreground">
|
||
{status ? `The server returned ${status}.` : "The request failed."} Your input and filters are still here, so
|
||
you can retry or fall back to the Issues filter.
|
||
</p>
|
||
<div className="flex flex-wrap items-center justify-center gap-2">
|
||
<Button onClick={refetch} variant="default" size="sm">
|
||
Retry
|
||
</Button>
|
||
<Button onClick={navigateIssuesFallback} variant="outline" size="sm">
|
||
Open Issues filter view
|
||
</Button>
|
||
</div>
|
||
</div>
|
||
);
|
||
}
|
||
|
||
if (isLoading) {
|
||
return (
|
||
<div className="flex flex-col gap-2 px-2 py-3 sm:px-4">
|
||
<div className="px-3 text-xs text-muted-foreground" data-testid="search-loading">
|
||
Searching for “{trimmedQuery}”…
|
||
</div>
|
||
<div className="flex flex-col">
|
||
<div className="px-3 py-2">
|
||
<Skeleton className="h-3 w-24" />
|
||
</div>
|
||
{Array.from({ length: 5 }).map((_, index) => (
|
||
<div key={index} className="flex items-start gap-3 px-3 py-2">
|
||
<Skeleton className="mt-1 h-4 w-4 rounded-full" />
|
||
<div className="flex flex-1 flex-col gap-1.5">
|
||
<Skeleton className="h-3 w-3/4" />
|
||
<Skeleton className="h-3 w-1/2" />
|
||
</div>
|
||
</div>
|
||
))}
|
||
</div>
|
||
</div>
|
||
);
|
||
}
|
||
|
||
if (isEmpty) {
|
||
return (
|
||
<div className="mx-auto flex w-full max-w-xl flex-col items-center justify-center gap-3 px-4 py-12 text-center">
|
||
<FileQuestion className="h-10 w-10 text-muted-foreground" aria-hidden />
|
||
<div className="text-base font-semibold">No results for “{trimmedQuery}”</div>
|
||
<p className="text-sm text-muted-foreground">
|
||
We couldn’t find a match in {describeScope(scope).toLowerCase()}. Try widening the scope or rephrasing your
|
||
query.
|
||
</p>
|
||
<div className="flex flex-wrap items-center justify-center gap-2">
|
||
{scope !== "all" ? (
|
||
<Button onClick={showAllScope} size="sm" variant="outline">
|
||
Search all scopes
|
||
</Button>
|
||
) : null}
|
||
<Button onClick={openNewIssue} size="sm" variant="default">
|
||
<Plus className="mr-1.5 h-4 w-4" />
|
||
Create issue from this query
|
||
</Button>
|
||
<Button onClick={navigateIssuesFallback} size="sm" variant="ghost">
|
||
Open Issues filter view
|
||
</Button>
|
||
</div>
|
||
<ul className="mt-2 space-y-0.5 text-xs text-muted-foreground">
|
||
<li>Try fewer tokens or a single distinctive term.</li>
|
||
<li>
|
||
Use an identifier shortcut like <code className="rounded bg-muted px-1 py-0.5">PAP-123</code>.
|
||
</li>
|
||
<li>Wrap multi-word phrases in quotes.</li>
|
||
</ul>
|
||
</div>
|
||
);
|
||
}
|
||
|
||
if (!hasResults) return null;
|
||
|
||
return (
|
||
<div className="flex w-full max-w-[960px] flex-col px-2 sm:px-4" data-testid="search-results">
|
||
<div className="flex items-center justify-between py-2 text-[11px] uppercase tracking-wide text-muted-foreground">
|
||
<span>
|
||
{totalResults === 1 ? "1 result" : `${totalResults} results`} · sorted by relevance
|
||
</span>
|
||
{isFetching ? <span aria-live="polite" className="normal-case tracking-normal">Updating…</span> : null}
|
||
</div>
|
||
<div className="flex flex-col pb-10">
|
||
{scope === "all" ? (
|
||
subgroups.map((group, groupIndex) => (
|
||
<section
|
||
key={group.key}
|
||
aria-label={SUBGROUP_LABELS[group.key]}
|
||
className={cn("flex flex-col", groupIndex > 0 && "mt-6")}
|
||
>
|
||
<IssueGroupHeader
|
||
label={SUBGROUP_LABELS[group.key]}
|
||
trailing={
|
||
<span className="text-xs font-normal tabular-nums text-muted-foreground">
|
||
{group.results.length}
|
||
</span>
|
||
}
|
||
className="pt-2 pb-1 text-[11px] tracking-wider text-muted-foreground"
|
||
/>
|
||
<div className="flex flex-col gap-y-1">
|
||
{group.results.map((result) => (
|
||
<SearchResultRow
|
||
key={`${result.type}:${result.id}:${result.href}`}
|
||
result={result}
|
||
agentsById={agentsById}
|
||
/>
|
||
))}
|
||
</div>
|
||
</section>
|
||
))
|
||
) : (
|
||
<div className="flex flex-col gap-y-1">
|
||
{subgroups
|
||
.flatMap((group) => group.results)
|
||
.map((result) => (
|
||
<SearchResultRow
|
||
key={`${result.type}:${result.id}:${result.href}`}
|
||
result={result}
|
||
agentsById={agentsById}
|
||
/>
|
||
))}
|
||
</div>
|
||
)}
|
||
</div>
|
||
</div>
|
||
);
|
||
}
|