forked from farhoodlabs/paperclip
Dotta
d0e9cc76f2
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies > - The issue thread is the operator's durable audit trail for what changed and why > - Workspace changes and stale disposition notices need to be visible in that same timeline without noisy or misleading rendering > - The local branch already contained backend activity details, timeline conversion, and UI rendering work for those events > - This pull request isolates the issue-thread activity work into a standalone branch against `origin/master` > - The benefit is a focused audit-trail PR that can merge independently of the sidebar/operator UI polish branch ## What Changed - Adds readable workspace-change activity details to issue update activity events. - Surfaces workspace-change events in issue chat/timeline rendering. - Makes the existing issue comment migration idempotent. - Folds and renders stale disposition notices inline so they match activity-log styling and spacing. - Adds focused route, timeline, and issue-thread system notice coverage. ## Verification - `pnpm install --frozen-lockfile` - `pnpm exec vitest run server/src/__tests__/issue-activity-events-routes.test.ts ui/src/lib/issue-timeline-events.test.ts ui/src/components/IssueChatThreadSystemNotice.test.tsx` — 3 files passed, 22 tests passed. - Confirmed the PR changes 9 files and does not include `pnpm-lock.yaml` or `.github/workflows/*`. - `pnpm exec vitest run server/src/__tests__/issue-closed-workspace-routes.test.ts` — 1 file passed, 4 tests passed. - `pnpm exec vitest run server/src/__tests__/issue-activity-events-routes.test.ts ui/src/lib/issue-timeline-events.test.ts ui/src/components/IssueChatThreadSystemNotice.test.tsx server/src/services/recovery/successful-run-handoff.test.ts packages/shared/src/validators/issue.test.ts` — 5 files passed, 54 tests passed. - `pnpm --filter @paperclipai/shared typecheck && pnpm --filter @paperclipai/server typecheck && pnpm --filter @paperclipai/ui typecheck`. - `pnpm --filter @paperclipai/ui typecheck` after adding the Storybook screenshot fixture. - Captured Storybook screenshots for the new UI rendering paths: - Collapsed stale notice + workspace-change row: `docs/pr-screenshots/pr-5356/issue-thread-notices-collapsed.png` - Expanded stale notice details: `docs/pr-screenshots/pr-5356/issue-thread-notices-expanded.png` ### Screenshots Collapsed stale notice with workspace-change row:  Expanded stale notice details:  ## Risks - Moderate risk: this touches issue activity serialization and issue-thread rendering, both of which are central operator surfaces. - Migration risk is low: the only migration change makes an existing migration idempotent. - No new migrations are introduced, so there is no cross-PR migration ordering requirement. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5 coding agent, shell/tool-use enabled, used to split the existing branch, verify the isolated PR branch, and create this PR. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
294 lines
7.6 KiB
TypeScript
294 lines
7.6 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import type { ActivityEvent } from "@paperclipai/shared";
|
|
import { extractIssueTimelineEvents } from "./issue-timeline-events";
|
|
|
|
describe("extractIssueTimelineEvents", () => {
|
|
it("extracts and sorts status and assignee changes from issue updates", () => {
|
|
const events = extractIssueTimelineEvents([
|
|
{
|
|
id: "evt-2",
|
|
companyId: "company-1",
|
|
actorType: "user",
|
|
actorId: "local-board",
|
|
action: "issue.updated",
|
|
entityType: "issue",
|
|
entityId: "issue-1",
|
|
agentId: null,
|
|
runId: null,
|
|
createdAt: new Date("2026-03-31T12:02:00.000Z"),
|
|
details: {
|
|
assigneeAgentId: "agent-2",
|
|
assigneeUserId: null,
|
|
_previous: {
|
|
assigneeAgentId: "agent-1",
|
|
assigneeUserId: null,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
id: "evt-1",
|
|
companyId: "company-1",
|
|
actorType: "user",
|
|
actorId: "local-board",
|
|
action: "issue.updated",
|
|
entityType: "issue",
|
|
entityId: "issue-1",
|
|
agentId: null,
|
|
runId: null,
|
|
createdAt: new Date("2026-03-31T12:01:00.000Z"),
|
|
details: {
|
|
status: "in_progress",
|
|
_previous: {
|
|
status: "todo",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
id: "evt-ignored",
|
|
companyId: "company-1",
|
|
actorType: "user",
|
|
actorId: "local-board",
|
|
action: "issue.comment_added",
|
|
entityType: "issue",
|
|
entityId: "issue-1",
|
|
agentId: null,
|
|
runId: null,
|
|
createdAt: new Date("2026-03-31T12:03:00.000Z"),
|
|
details: {
|
|
commentId: "comment-1",
|
|
},
|
|
},
|
|
] satisfies ActivityEvent[]);
|
|
|
|
expect(events).toEqual([
|
|
{
|
|
id: "evt-1",
|
|
createdAt: new Date("2026-03-31T12:01:00.000Z"),
|
|
actorType: "user",
|
|
actorId: "local-board",
|
|
runId: null,
|
|
statusChange: {
|
|
from: "todo",
|
|
to: "in_progress",
|
|
},
|
|
},
|
|
{
|
|
id: "evt-2",
|
|
createdAt: new Date("2026-03-31T12:02:00.000Z"),
|
|
actorType: "user",
|
|
actorId: "local-board",
|
|
runId: null,
|
|
assigneeChange: {
|
|
from: {
|
|
agentId: "agent-1",
|
|
userId: null,
|
|
},
|
|
to: {
|
|
agentId: "agent-2",
|
|
userId: null,
|
|
},
|
|
},
|
|
},
|
|
]);
|
|
});
|
|
|
|
it("uses reopenedFrom when a reopen update omits _previous", () => {
|
|
const events = extractIssueTimelineEvents([
|
|
{
|
|
id: "evt-reopen",
|
|
companyId: "company-1",
|
|
actorType: "agent",
|
|
actorId: "agent-1",
|
|
action: "issue.updated",
|
|
entityType: "issue",
|
|
entityId: "issue-1",
|
|
agentId: "agent-1",
|
|
runId: "run-1",
|
|
createdAt: new Date("2026-03-31T12:01:00.000Z"),
|
|
details: {
|
|
status: "todo",
|
|
reopened: true,
|
|
reopenedFrom: "done",
|
|
source: "comment",
|
|
},
|
|
},
|
|
] satisfies ActivityEvent[]);
|
|
|
|
expect(events).toEqual([
|
|
{
|
|
id: "evt-reopen",
|
|
createdAt: new Date("2026-03-31T12:01:00.000Z"),
|
|
actorType: "agent",
|
|
actorId: "agent-1",
|
|
runId: "run-1",
|
|
statusChange: {
|
|
from: "done",
|
|
to: "todo",
|
|
},
|
|
},
|
|
]);
|
|
});
|
|
|
|
it("marks explicit follow-up timeline updates", () => {
|
|
const events = extractIssueTimelineEvents([
|
|
{
|
|
id: "evt-follow-up",
|
|
companyId: "company-1",
|
|
actorType: "agent",
|
|
actorId: "agent-1",
|
|
action: "issue.updated",
|
|
entityType: "issue",
|
|
entityId: "issue-1",
|
|
agentId: "agent-1",
|
|
runId: "run-1",
|
|
createdAt: new Date("2026-03-31T12:01:00.000Z"),
|
|
details: {
|
|
status: "todo",
|
|
reopened: true,
|
|
reopenedFrom: "done",
|
|
source: "comment",
|
|
commentId: "comment-1",
|
|
resumeIntent: true,
|
|
followUpRequested: true,
|
|
},
|
|
},
|
|
] satisfies ActivityEvent[]);
|
|
|
|
expect(events).toEqual([
|
|
{
|
|
id: "evt-follow-up",
|
|
createdAt: new Date("2026-03-31T12:01:00.000Z"),
|
|
actorType: "agent",
|
|
actorId: "agent-1",
|
|
runId: "run-1",
|
|
commentId: "comment-1",
|
|
followUpRequested: true,
|
|
statusChange: {
|
|
from: "done",
|
|
to: "todo",
|
|
},
|
|
},
|
|
]);
|
|
});
|
|
|
|
it("extracts workspace changes from issue update activity", () => {
|
|
const events = extractIssueTimelineEvents([
|
|
{
|
|
id: "evt-workspace",
|
|
companyId: "company-1",
|
|
actorType: "user",
|
|
actorId: "local-board",
|
|
action: "issue.updated",
|
|
entityType: "issue",
|
|
entityId: "issue-1",
|
|
agentId: null,
|
|
runId: null,
|
|
createdAt: new Date("2026-03-31T12:01:00.000Z"),
|
|
details: {
|
|
projectWorkspaceId: "workspace-2",
|
|
workspaceChange: {
|
|
from: {
|
|
label: "Main workspace",
|
|
projectWorkspaceId: "workspace-1",
|
|
executionWorkspaceId: null,
|
|
mode: "shared_workspace",
|
|
},
|
|
to: {
|
|
label: "Feature branch",
|
|
projectWorkspaceId: "workspace-2",
|
|
executionWorkspaceId: null,
|
|
mode: "shared_workspace",
|
|
},
|
|
},
|
|
_previous: {
|
|
projectWorkspaceId: "workspace-1",
|
|
},
|
|
},
|
|
},
|
|
] satisfies ActivityEvent[]);
|
|
|
|
expect(events).toEqual([
|
|
{
|
|
id: "evt-workspace",
|
|
createdAt: new Date("2026-03-31T12:01:00.000Z"),
|
|
actorType: "user",
|
|
actorId: "local-board",
|
|
runId: null,
|
|
workspaceChange: {
|
|
from: {
|
|
label: "Main workspace",
|
|
projectWorkspaceId: "workspace-1",
|
|
executionWorkspaceId: null,
|
|
mode: "shared_workspace",
|
|
},
|
|
to: {
|
|
label: "Feature branch",
|
|
projectWorkspaceId: "workspace-2",
|
|
executionWorkspaceId: null,
|
|
mode: "shared_workspace",
|
|
},
|
|
},
|
|
},
|
|
]);
|
|
});
|
|
|
|
it("synthesizes non-status follow-up rows from comment activity", () => {
|
|
const events = extractIssueTimelineEvents([
|
|
{
|
|
id: "evt-comment-follow-up",
|
|
companyId: "company-1",
|
|
actorType: "agent",
|
|
actorId: "agent-1",
|
|
action: "issue.comment_added",
|
|
entityType: "issue",
|
|
entityId: "issue-1",
|
|
agentId: "agent-1",
|
|
runId: "run-1",
|
|
createdAt: new Date("2026-03-31T12:01:00.000Z"),
|
|
details: {
|
|
commentId: "comment-1",
|
|
resumeIntent: true,
|
|
followUpRequested: true,
|
|
},
|
|
},
|
|
] satisfies ActivityEvent[]);
|
|
|
|
expect(events).toEqual([
|
|
{
|
|
id: "evt-comment-follow-up",
|
|
createdAt: new Date("2026-03-31T12:01:00.000Z"),
|
|
actorType: "agent",
|
|
actorId: "agent-1",
|
|
runId: "run-1",
|
|
commentId: "comment-1",
|
|
followUpRequested: true,
|
|
},
|
|
]);
|
|
});
|
|
|
|
it("ignores issue updates without visible status, assignee, or workspace transitions", () => {
|
|
const events = extractIssueTimelineEvents([
|
|
{
|
|
id: "evt-title",
|
|
companyId: "company-1",
|
|
actorType: "user",
|
|
actorId: "local-board",
|
|
action: "issue.updated",
|
|
entityType: "issue",
|
|
entityId: "issue-1",
|
|
agentId: null,
|
|
runId: null,
|
|
createdAt: new Date("2026-03-31T12:01:00.000Z"),
|
|
details: {
|
|
title: "New title",
|
|
_previous: {
|
|
title: "Old title",
|
|
},
|
|
},
|
|
},
|
|
] satisfies ActivityEvent[]);
|
|
|
|
expect(events).toEqual([]);
|
|
});
|
|
});
|