forked from farhoodlabs/paperclip
32a9165ddf
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies > - The control plane depends on authenticated routes enforcing company boundaries and role permissions correctly > - This branch also touches the issue detail and markdown editing flows operators use while handling advisory and triage work > - Partial issue cache seeds and fragile rich-editor parsing could leave important issue content missing or blank at the moment an operator needed it > - Blocked issues becoming actionable again should wake their assignee automatically instead of silently staying idle > - This pull request rebases the advisory follow-up branch onto current `master`, hardens authenticated route authorization, and carries the issue-detail/editor reliability fixes forward with regression tests > - The benefit is tighter authz on sensitive routes plus more reliable issue/advisory editing and wakeup behavior on top of the latest base ## What Changed - Hardened authenticated route authorization across agent, activity, approval, access, project, plugin, health, execution-workspace, portability, and related server paths, with new cross-tenant and runtime-authz regression coverage. - Switched issue detail queries from `initialData` to placeholder-based hydration so list/quicklook seeds still refetch full issue bodies. - Normalized advisory-style HTML images before mounting the markdown editor and strengthened fallback behavior when the rich editor silently fails or rejects the content. - Woke assigned agents when blocked issues move back to `todo`, with route coverage for reopen and unblock transitions. - Rebasing note: this branch now sits cleanly on top of the latest `master` tip used for the PR base. ## Verification - `pnpm exec vitest run ui/src/lib/issueDetailQuery.test.tsx ui/src/components/MarkdownEditor.test.tsx server/src/__tests__/issue-comment-reopen-routes.test.ts server/src/__tests__/activity-routes.test.ts server/src/__tests__/agent-cross-tenant-authz-routes.test.ts` - Confirmed `pnpm-lock.yaml` is not part of the PR diff. - Rebased the branch onto current `public-gh/master` before publishing. ## Risks - Broad authz tightening may expose existing flows that were relying on permissive board or agent access and now need explicit grants. - Markdown editor fallback changes could affect focus or rendering in edge-case content that mixes HTML-like advisory markup with normal markdown. - This verification was intentionally scoped to touched regressions and did not run the full repository suite. ## Model Used - OpenAI Codex, GPT-5-based coding agent in the Codex CLI environment with tool use for terminal, git, and GitHub operations. The exact runtime model identifier is not exposed inside this session. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, it is behavior-only and does not need before/after screenshots - [x] I have updated relevant documentation to reflect my changes, or no documentation changes were needed for these internal fixes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
183 lines
5.4 KiB
TypeScript
183 lines
5.4 KiB
TypeScript
import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
|
|
import express from "express";
|
|
import request from "supertest";
|
|
import type { Db } from "@paperclipai/db";
|
|
import { serverVersion } from "../version.js";
|
|
import { healthRoutes } from "../routes/health.js";
|
|
|
|
const mockReadPersistedDevServerStatus = vi.hoisted(() => vi.fn());
|
|
|
|
vi.mock("../dev-server-status.js", () => ({
|
|
readPersistedDevServerStatus: mockReadPersistedDevServerStatus,
|
|
toDevServerHealthStatus: vi.fn(),
|
|
}));
|
|
|
|
function createApp(db?: Db) {
|
|
const app = express();
|
|
app.use("/health", healthRoutes(db));
|
|
return app;
|
|
}
|
|
|
|
describe("GET /health", () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks();
|
|
mockReadPersistedDevServerStatus.mockReturnValue(undefined);
|
|
});
|
|
|
|
afterEach(() => {
|
|
vi.restoreAllMocks();
|
|
});
|
|
|
|
it("returns 200 with status ok", async () => {
|
|
const app = createApp();
|
|
|
|
const res = await request(app).get("/health");
|
|
expect(res.status).toBe(200);
|
|
expect(res.body).toEqual({ status: "ok", version: serverVersion });
|
|
}, 15_000);
|
|
|
|
it("returns 200 when the database probe succeeds", async () => {
|
|
const db = {
|
|
execute: vi.fn().mockResolvedValue([{ "?column?": 1 }]),
|
|
} as unknown as Db;
|
|
const app = createApp(db);
|
|
|
|
const res = await request(app).get("/health");
|
|
|
|
expect(res.status).toBe(200);
|
|
expect(res.body).toMatchObject({ status: "ok", version: serverVersion });
|
|
});
|
|
|
|
it("returns 503 when the database probe fails", async () => {
|
|
const db = {
|
|
execute: vi.fn().mockRejectedValue(new Error("connect ECONNREFUSED")),
|
|
} as unknown as Db;
|
|
const app = createApp(db);
|
|
|
|
const res = await request(app).get("/health");
|
|
|
|
expect(res.status).toBe(503);
|
|
expect(res.body).toEqual({
|
|
status: "unhealthy",
|
|
version: serverVersion,
|
|
error: "database_unreachable",
|
|
});
|
|
});
|
|
|
|
it("redacts detailed metadata for anonymous requests in authenticated mode", async () => {
|
|
const devServerStatus = await import("../dev-server-status.js");
|
|
vi.spyOn(devServerStatus, "readPersistedDevServerStatus").mockReturnValue(undefined);
|
|
const { healthRoutes } = await import("../routes/health.js");
|
|
const db = {
|
|
execute: vi.fn().mockResolvedValue([{ "?column?": 1 }]),
|
|
select: vi.fn(() => ({
|
|
from: vi.fn(() => ({
|
|
where: vi.fn().mockResolvedValue([{ count: 1 }]),
|
|
})),
|
|
})),
|
|
} as unknown as Db;
|
|
const app = express();
|
|
app.use((req, _res, next) => {
|
|
(req as any).actor = { type: "none", source: "none" };
|
|
next();
|
|
});
|
|
app.use(
|
|
"/health",
|
|
healthRoutes(db, {
|
|
deploymentMode: "authenticated",
|
|
deploymentExposure: "public",
|
|
authReady: true,
|
|
companyDeletionEnabled: false,
|
|
}),
|
|
);
|
|
|
|
const res = await request(app).get("/health");
|
|
|
|
expect(res.status).toBe(200);
|
|
expect(res.body).toEqual({
|
|
status: "ok",
|
|
deploymentMode: "authenticated",
|
|
bootstrapStatus: "ready",
|
|
bootstrapInviteActive: false,
|
|
});
|
|
});
|
|
|
|
it("redacts detailed metadata when authenticated mode is reached without auth middleware", async () => {
|
|
const devServerStatus = await import("../dev-server-status.js");
|
|
vi.spyOn(devServerStatus, "readPersistedDevServerStatus").mockReturnValue(undefined);
|
|
const { healthRoutes } = await import("../routes/health.js");
|
|
const db = {
|
|
execute: vi.fn().mockResolvedValue([{ "?column?": 1 }]),
|
|
select: vi.fn(() => ({
|
|
from: vi.fn(() => ({
|
|
where: vi.fn().mockResolvedValue([{ count: 1 }]),
|
|
})),
|
|
})),
|
|
} as unknown as Db;
|
|
const app = express();
|
|
app.use(
|
|
"/health",
|
|
healthRoutes(db, {
|
|
deploymentMode: "authenticated",
|
|
deploymentExposure: "public",
|
|
authReady: true,
|
|
companyDeletionEnabled: false,
|
|
}),
|
|
);
|
|
|
|
const res = await request(app).get("/health");
|
|
|
|
expect(res.status).toBe(200);
|
|
expect(res.body).toEqual({
|
|
status: "ok",
|
|
deploymentMode: "authenticated",
|
|
bootstrapStatus: "ready",
|
|
bootstrapInviteActive: false,
|
|
});
|
|
});
|
|
|
|
it("keeps detailed metadata for authenticated requests in authenticated mode", async () => {
|
|
const devServerStatus = await import("../dev-server-status.js");
|
|
vi.spyOn(devServerStatus, "readPersistedDevServerStatus").mockReturnValue(undefined);
|
|
const { healthRoutes } = await import("../routes/health.js");
|
|
const db = {
|
|
execute: vi.fn().mockResolvedValue([{ "?column?": 1 }]),
|
|
select: vi.fn(() => ({
|
|
from: vi.fn(() => ({
|
|
where: vi.fn().mockResolvedValue([{ count: 1 }]),
|
|
})),
|
|
})),
|
|
} as unknown as Db;
|
|
const app = express();
|
|
app.use((req, _res, next) => {
|
|
(req as any).actor = { type: "board", userId: "user-1", source: "session" };
|
|
next();
|
|
});
|
|
app.use(
|
|
"/health",
|
|
healthRoutes(db, {
|
|
deploymentMode: "authenticated",
|
|
deploymentExposure: "public",
|
|
authReady: true,
|
|
companyDeletionEnabled: false,
|
|
}),
|
|
);
|
|
|
|
const res = await request(app).get("/health");
|
|
|
|
expect(res.status).toBe(200);
|
|
expect(res.body).toMatchObject({
|
|
status: "ok",
|
|
version: serverVersion,
|
|
deploymentMode: "authenticated",
|
|
deploymentExposure: "public",
|
|
authReady: true,
|
|
bootstrapStatus: "ready",
|
|
bootstrapInviteActive: false,
|
|
features: {
|
|
companyDeletionEnabled: false,
|
|
},
|
|
});
|
|
});
|
|
});
|