Files
paperclip/server/src/__tests__/logger-tz.test.ts
T
Dotta 7f893ac4ec [codex] Harden execution reliability and heartbeat tooling (#3679)
## Thinking Path

> - Paperclip orchestrates AI agents for zero-human companies
> - Reliable execution depends on heartbeat routing, issue lifecycle
semantics, telemetry, and a fast enough local verification loop to keep
regressions visible
> - The remaining commits on this branch were mostly server/runtime
correctness fixes plus test and documentation follow-ups in that area
> - Those changes are logically separate from the UI-focused
issue-detail and workspace/navigation branches even when they touch
overlapping issue APIs
> - This pull request groups the execution reliability, heartbeat,
telemetry, and tooling changes into one standalone branch
> - The benefit is a focused review of the control-plane correctness
work, including the follow-up fix that restored the implicit
comment-reopen helpers after branch splitting

## What Changed

- Hardened issue/heartbeat execution behavior, including self-review
stage skipping, deferred mention wakes during active execution, stranded
execution recovery, active-run scoping, assignee resolution, and
blocked-to-todo wake resumption
- Reduced noisy polling/logging overhead by trimming issue run payloads,
compacting persisted run logs, silencing high-volume request logs, and
capping heartbeat-run queries in dashboard/inbox surfaces
- Expanded telemetry and status semantics with adapter/model fields on
task completion plus clearer status guidance in docs/onboarding material
- Updated test infrastructure and verification defaults with faster
route-test module isolation, cheaper default `pnpm test`, e2e isolation
from local state, and repo verification follow-ups
- Included docs/release housekeeping from the branch and added a small
follow-up commit restoring the implicit comment-reopen helpers that were
dropped during branch reconstruction

## Verification

- `pnpm vitest run
server/src/__tests__/issue-comment-reopen-routes.test.ts
server/src/__tests__/issue-telemetry-routes.test.ts`
- `pnpm vitest run server/src/__tests__/http-log-policy.test.ts
server/src/__tests__/heartbeat-run-log.test.ts
server/src/__tests__/health.test.ts`
- `server/src/__tests__/activity-service.test.ts`,
`server/src/__tests__/heartbeat-comment-wake-batching.test.ts`, and
`server/src/__tests__/heartbeat-process-recovery.test.ts` were attempted
on this host but the embedded Postgres harness reported
init-script/data-dir problems and skipped or failed to start, so they
are noted as environment-limited

## Risks

- Medium: this branch changes core issue/heartbeat routing and
reopen/wakeup behavior, so regressions would affect agent execution flow
rather than isolated UI polish
- Because it also updates verification infrastructure, reviewers should
pay attention to whether the new tests are asserting the right failure
modes and not just reshaping harness behavior

## Model Used

- OpenAI Codex coding agent (GPT-5-class runtime in Codex CLI; exact
deployed model ID is not exposed in this environment), reasoning
enabled, tool use and local code execution enabled

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [ ] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [ ] If this change affects the UI, I have included before/after
screenshots
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] I will address all Greptile and reviewer comments before
requesting merge

---------

Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-04-14 13:34:52 -05:00

98 lines
3.3 KiB
TypeScript

import { describe, expect, it, vi, beforeEach } from "vitest";
/**
* Regression test for https://github.com/paperclipai/paperclip/issues/2879
*
* pino-pretty's `translateTime: "HH:MM:ss"` formats all timestamps in UTC
* regardless of the process's TZ env var. The `SYS:` prefix instructs
* pino-pretty to use the local system timezone, so operators in non-UTC
* zones see correct wall-clock times in their logs.
*
* We verify that:
* 1. The logger module initialises pino-pretty with "SYS:HH:MM:ss".
* 2. The pino-pretty SYS: prefix resolves to a timezone-sensitive format
* string — confirmed via pino-pretty's own asynchronous formatter, which
* applies translateTime to a known epoch under different TZ values.
*/
const mockTransport = vi.hoisted(() => vi.fn(() => ({ write: vi.fn() })));
const mockPino = vi.hoisted(() => {
const fn = vi.fn(() => ({
info: vi.fn(),
debug: vi.fn(),
error: vi.fn(),
warn: vi.fn(),
child: vi.fn(),
}));
(fn as any).transport = mockTransport;
return fn;
});
// Mock fs so the module-level mkdirSync call is a no-op in tests.
vi.mock("node:fs", async (importOriginal) => {
const actual = await importOriginal<typeof import("node:fs")>();
return { ...actual, mkdirSync: vi.fn() };
});
vi.mock("pino", () => ({
default: mockPino,
}));
vi.mock("pino-http", () => ({
pinoHttp: vi.fn(() => vi.fn()),
}));
vi.mock("../config-file.js", () => ({
readConfigFile: vi.fn(() => null),
}));
vi.mock("../home-paths.js", () => ({
resolveHomeAwarePath: vi.fn((p: string) => p),
resolveDefaultLogsDir: vi.fn(() => "/tmp/paperclip-test-logs"),
}));
describe("logger translateTime respects TZ environment variable", () => {
beforeEach(() => {
vi.clearAllMocks();
});
it("configures pino-pretty with SYS:HH:MM:ss so timestamps honour the TZ env var", async () => {
await import("../middleware/logger.js");
expect(mockTransport).toHaveBeenCalledOnce();
const { targets } = mockTransport.mock.calls[0][0] as {
targets: Array<{ options: Record<string, unknown> }>;
};
for (const target of targets) {
expect(target.options.translateTime).toBe("SYS:HH:MM:ss");
}
});
it("SYS: prefix produces timezone-sensitive output: UTC epoch formats differently under UTC vs UTC+8", () => {
// Verifies the contract that SYS: relies on: formatting the same epoch
// with different explicit timezones (mirroring what the process TZ env
// var does at the OS level) must yield different results.
const EPOCH_MS = 946_684_800_000; // 2000-01-01 00:00:00 UTC
const fmtUtc = new Intl.DateTimeFormat("en-GB", {
timeZone: "UTC",
hour: "2-digit",
minute: "2-digit",
second: "2-digit",
hour12: false,
}).format(EPOCH_MS);
const fmtSgt = new Intl.DateTimeFormat("en-GB", {
timeZone: "Asia/Singapore", // UTC+8
hour: "2-digit",
minute: "2-digit",
second: "2-digit",
hour12: false,
}).format(EPOCH_MS);
// UTC midnight = 00:00:00; the same instant in SGT = 08:00:00.
// SYS: picks up whichever of these the process TZ is set to — which is
// exactly what the fix enables by switching from HH:MM:ss (UTC-only).
expect(fmtUtc).toBe("00:00:00");
expect(fmtSgt).toBe("08:00:00");
expect(fmtUtc).not.toBe(fmtSgt);
});
});