forked from farhoodlabs/paperclip
ea7f53fd7d
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies > - Each agent uses an adapter that drives a CLI (Claude, Gemini, Codex, etc.) > - The Gemini adapter parses a JSONL transcript stream the CLI emits to learn what the model said > - Gemini CLI v0.38 changed the transcript shape: assistant text now comes through `type=message` with `role`/`content` and terminal status comes through `type=status` / `type=stats` > - The existing parser was written against the older `type=assistant` / `type=result` shape, so post-v0.38 outputs left the parsed summary empty and downgraded the SSH hello probe to "unexpected output" > - This pull request updates every Gemini consumer (server parser, UI parser, CLI formatter) to accept the v0.38 shape while keeping the legacy shape working > - The benefit is the Gemini adapter handles current upstream output without losing backward compatibility, with explicit test coverage for both shapes ## What Changed - `packages/adapters/gemini-local/src/server/parse.ts` recognizes `type=message` events with role/content and stops downgrading them - `packages/adapters/gemini-local/src/ui/parse-stdout.ts` mirrors the parser changes for the live UI transcript - `packages/adapters/gemini-local/src/cli/format-event.ts` formats the new event shape correctly for CLI output - `parse.test.ts` and `parse-stdout.test.ts` add v0.38 coverage; `gemini-local-adapter.test.ts` and `execute.remote.test.ts` switch happy-path fixtures to the current real wire format and keep dedicated tests for the older schema ## Verification - `pnpm vitest run --no-coverage --project @paperclipai/adapter-gemini-local` — full suite passes including new v0.38 cases and preserved legacy cases - `pnpm typecheck` clean ## Risks Low risk — additive event handling. Legacy event shape path is preserved with its own tests, so existing fixtures continue to parse identically. ## Model Used Claude Opus 4.7 (1M context) ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots — N/A (no UI) - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge
204 lines
5.8 KiB
TypeScript
204 lines
5.8 KiB
TypeScript
import { describe, expect, it, vi } from "vitest";
|
|
import {
|
|
isGeminiTurnLimitResult,
|
|
isGeminiUnknownSessionError,
|
|
parseGeminiJsonl,
|
|
} from "@paperclipai/adapter-gemini-local/server";
|
|
import { parseGeminiStdoutLine } from "@paperclipai/adapter-gemini-local/ui";
|
|
import { printGeminiStreamEvent } from "@paperclipai/adapter-gemini-local/cli";
|
|
|
|
describe("gemini_local parser", () => {
|
|
it("extracts session, summary, usage, cost, and terminal error message from v0.38 stream-json output", () => {
|
|
const stdout = [
|
|
JSON.stringify({ type: "system", subtype: "init", session_id: "gemini-session-1", model: "gemini-2.5-pro" }),
|
|
JSON.stringify({
|
|
type: "message",
|
|
role: "assistant",
|
|
content: "hello",
|
|
}),
|
|
JSON.stringify({
|
|
type: "result",
|
|
status: "success",
|
|
session_id: "gemini-session-1",
|
|
stats: {
|
|
input_tokens: 12,
|
|
cached_input_tokens: 3,
|
|
output_tokens: 7,
|
|
},
|
|
total_cost_usd: 0.00123,
|
|
}),
|
|
JSON.stringify({ type: "error", message: "model access denied" }),
|
|
].join("\n");
|
|
|
|
const parsed = parseGeminiJsonl(stdout);
|
|
expect(parsed.sessionId).toBe("gemini-session-1");
|
|
expect(parsed.summary).toBe("hello");
|
|
expect(parsed.usage).toEqual({
|
|
inputTokens: 12,
|
|
cachedInputTokens: 3,
|
|
outputTokens: 7,
|
|
});
|
|
expect(parsed.costUsd).toBeCloseTo(0.00123, 6);
|
|
expect(parsed.errorMessage).toBe("model access denied");
|
|
});
|
|
|
|
it("extracts structured questions", () => {
|
|
const stdout = [
|
|
JSON.stringify({
|
|
type: "assistant",
|
|
message: {
|
|
content: [
|
|
{ type: "output_text", text: "I have a question." },
|
|
{
|
|
type: "question",
|
|
prompt: "Which model?",
|
|
choices: [
|
|
{ key: "pro", label: "Gemini Pro", description: "Better" },
|
|
{ key: "flash", label: "Gemini Flash" },
|
|
],
|
|
},
|
|
],
|
|
},
|
|
}),
|
|
].join("\n");
|
|
|
|
const parsed = parseGeminiJsonl(stdout);
|
|
expect(parsed.summary).toBe("I have a question.");
|
|
expect(parsed.question).toEqual({
|
|
prompt: "Which model?",
|
|
choices: [
|
|
{ key: "pro", label: "Gemini Pro", description: "Better" },
|
|
{ key: "flash", label: "Gemini Flash", description: undefined },
|
|
],
|
|
});
|
|
});
|
|
});
|
|
|
|
describe("gemini_local stale session detection", () => {
|
|
it("treats missing session messages as an unknown session error", () => {
|
|
expect(isGeminiUnknownSessionError("", "unknown session id abc")).toBe(true);
|
|
expect(isGeminiUnknownSessionError("", "checkpoint latest not found")).toBe(true);
|
|
});
|
|
});
|
|
|
|
describe("gemini_local turn-limit detection", () => {
|
|
it("detects structured turn-limit signals and exit code 53", () => {
|
|
expect(isGeminiTurnLimitResult({ status: "turn_limit" })).toBe(true);
|
|
expect(isGeminiTurnLimitResult({ stopReason: "max_turns_exhausted" })).toBe(true);
|
|
expect(isGeminiTurnLimitResult(null, 53)).toBe(true);
|
|
});
|
|
|
|
it("checks every structured stop field for turn-limit exhaustion", () => {
|
|
expect(
|
|
isGeminiTurnLimitResult({
|
|
status: "success",
|
|
stopReason: "turn_limit_exhausted",
|
|
}),
|
|
).toBe(true);
|
|
});
|
|
|
|
it("does not detect turn-limit exhaustion from unstructured error text", () => {
|
|
expect(isGeminiTurnLimitResult({ error: "max_turns reached" })).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe("gemini_local ui stdout parser", () => {
|
|
it("parses v0.38 assistant message and result events", () => {
|
|
const ts = "2026-03-08T00:00:00.000Z";
|
|
|
|
expect(
|
|
parseGeminiStdoutLine(
|
|
JSON.stringify({
|
|
type: "message",
|
|
role: "assistant",
|
|
content: "I checked the repo.",
|
|
}),
|
|
ts,
|
|
),
|
|
).toEqual([
|
|
{ kind: "assistant", ts, text: "I checked the repo." },
|
|
]);
|
|
|
|
expect(
|
|
parseGeminiStdoutLine(
|
|
JSON.stringify({
|
|
type: "result",
|
|
status: "success",
|
|
text: "Done",
|
|
stats: {
|
|
input_tokens: 10,
|
|
output_tokens: 5,
|
|
cached_input_tokens: 2,
|
|
},
|
|
total_cost_usd: 0.00042,
|
|
}),
|
|
ts,
|
|
),
|
|
).toEqual([
|
|
{
|
|
kind: "result",
|
|
ts,
|
|
text: "Done",
|
|
inputTokens: 10,
|
|
outputTokens: 5,
|
|
cachedTokens: 2,
|
|
costUsd: 0.00042,
|
|
subtype: "success",
|
|
isError: false,
|
|
errors: [],
|
|
},
|
|
]);
|
|
});
|
|
});
|
|
|
|
function stripAnsi(value: string): string {
|
|
return value.replace(/\x1b\[[0-9;]*m/g, "");
|
|
}
|
|
|
|
describe("gemini_local cli formatter", () => {
|
|
it("prints init, v0.38 assistant, result, and error events", () => {
|
|
const spy = vi.spyOn(console, "log").mockImplementation(() => {});
|
|
let joined = "";
|
|
|
|
try {
|
|
printGeminiStreamEvent(
|
|
JSON.stringify({ type: "system", subtype: "init", session_id: "gemini-session-1", model: "gemini-2.5-pro" }),
|
|
false,
|
|
);
|
|
printGeminiStreamEvent(
|
|
JSON.stringify({
|
|
type: "message",
|
|
role: "assistant",
|
|
content: "hello",
|
|
}),
|
|
false,
|
|
);
|
|
printGeminiStreamEvent(
|
|
JSON.stringify({
|
|
type: "result",
|
|
status: "success",
|
|
stats: {
|
|
input_tokens: 10,
|
|
output_tokens: 5,
|
|
cached_input_tokens: 2,
|
|
},
|
|
total_cost_usd: 0.00042,
|
|
}),
|
|
false,
|
|
);
|
|
printGeminiStreamEvent(
|
|
JSON.stringify({ type: "error", message: "boom" }),
|
|
false,
|
|
);
|
|
joined = spy.mock.calls.map((call) => stripAnsi(call.join(" "))).join("\n");
|
|
} finally {
|
|
spy.mockRestore();
|
|
}
|
|
|
|
expect(joined).toContain("Gemini init");
|
|
expect(joined).toContain("assistant: hello");
|
|
expect(joined).toContain("tokens: in=10 out=5 cached=2 cost=$0.000420");
|
|
expect(joined).toContain("error: boom");
|
|
});
|
|
});
|