forked from farhoodlabs/paperclip
012a738729
## Thinking Path > - Paperclip orchestrates AI-agent companies through company-scoped issues, comments, and execution context. > - The issue detail page is the board surface where operators and agents inspect a task in its parent/child workflow. > - Ordered sub-issues need a low-friction way to move through work without returning to the parent list after every issue. > - Existing issue detail navigation only covered sibling transitions and did not continue into a parent issue's first ordered child. > - This pull request adds ordered previous/next navigation for issue detail views and extends it to continue from a parent or last sibling into the first direct child. > - The benefit is a smoother review/execution path through hierarchical work while preserving hidden issue filtering and dependency-aware ordering. ## What Changed - Added `IssueSiblingNavigation` and route-state handling so issue detail footers can link to previous/next ordered issues. - Extended sub-issue ordering helpers to build navigation from siblings plus direct children, including root-parent and last-sibling-to-first-child cases. - Added page, component, and library tests for ordered sibling navigation, child fallback navigation, hidden issues, and link rendering. - Fixed the quicklook blur/click race Greptile found by deferring close until after portaled link clicks can complete, with a regression test. - Polished the navigation landmark label so it remains accurate when the next target is a direct child rather than a sibling. ## Verification - `pnpm exec vitest run src/components/IssueLinkQuicklook.test.tsx src/lib/issue-detail-subissues.test.ts src/components/IssueSiblingNavigation.test.tsx src/pages/IssueDetail.test.tsx --config vitest.config.ts` from `ui/` - 31 tests passed. - `pnpm --filter @paperclipai/ui typecheck` - passed. - `git diff --check` - passed. - GitHub PR checks on latest head `34046be2` - passed: Greptile Review, verify, e2e, Canary Dry Run, policy, Snyk, and serialized server shards. - Screenshots: not captured in this heartbeat; this PR is a draft and the changed states are covered by focused component/page tests. ## Risks - Low risk; this is a UI navigation addition with no database or API contract changes. - The main behavioral risk is navigation ordering drift if `workflowSort` expectations change later. - The IssueDetail navigation now waits for child issue loading, which avoids stale child fallback links but can delay footer navigation briefly while data loads. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected - check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5 coding agent with repository tool use and shell execution. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
91 lines
3.3 KiB
TypeScript
91 lines
3.3 KiB
TypeScript
import { ChevronLeft, ChevronRight } from "lucide-react";
|
|
import type { Issue } from "@paperclipai/shared";
|
|
import type { IssueSiblingNavigation as IssueSiblingNavigationState } from "@/lib/issue-detail-subissues";
|
|
import { createIssueDetailPath, withIssueDetailHeaderSeed } from "@/lib/issueDetailBreadcrumb";
|
|
import { cn } from "@/lib/utils";
|
|
import { Link } from "@/lib/router";
|
|
import { StatusIcon } from "./StatusIcon";
|
|
|
|
type IssueSiblingNavigationProps = {
|
|
navigation: IssueSiblingNavigationState | null;
|
|
linkState?: unknown;
|
|
};
|
|
|
|
export function IssueSiblingNavigation({ navigation, linkState }: IssueSiblingNavigationProps) {
|
|
if (!navigation) return null;
|
|
|
|
return (
|
|
<nav
|
|
aria-label="Sub-issue navigation"
|
|
className="mt-4 flex flex-col gap-3 sm:mt-6 sm:grid sm:grid-cols-2"
|
|
>
|
|
{navigation.previous ? (
|
|
<SiblingLink direction="previous" issue={navigation.previous} linkState={linkState} />
|
|
) : null}
|
|
{navigation.next ? (
|
|
<SiblingLink
|
|
direction="next"
|
|
issue={navigation.next}
|
|
linkState={linkState}
|
|
className={!navigation.previous ? "sm:col-start-2" : undefined}
|
|
/>
|
|
) : null}
|
|
</nav>
|
|
);
|
|
}
|
|
|
|
function SiblingLink({
|
|
direction,
|
|
issue,
|
|
linkState,
|
|
className,
|
|
}: {
|
|
direction: "previous" | "next";
|
|
issue: Issue;
|
|
linkState?: unknown;
|
|
className?: string;
|
|
}) {
|
|
const issuePathId = issue.identifier ?? issue.id;
|
|
const label = direction === "previous" ? "Previous" : "Next";
|
|
const ariaDirection = direction === "previous" ? "Previous sub-issue" : "Next sub-issue";
|
|
const identifier = issue.identifier ?? issue.id.slice(0, 8);
|
|
const Icon = direction === "previous" ? ChevronLeft : ChevronRight;
|
|
|
|
return (
|
|
<Link
|
|
to={createIssueDetailPath(issuePathId)}
|
|
state={withIssueDetailHeaderSeed(linkState, issue)}
|
|
issuePrefetch={issue}
|
|
issueQuicklookSide="top"
|
|
issueQuicklookAlign={direction === "previous" ? "start" : "end"}
|
|
aria-label={`${ariaDirection}: ${identifier} - ${issue.title}`}
|
|
className={cn(
|
|
"group min-w-0 rounded-lg border border-border bg-card px-3 py-2.5 text-left no-underline transition-colors hover:bg-accent/50 focus-visible:outline-none focus-visible:ring-[3px] focus-visible:ring-ring",
|
|
direction === "next" && "sm:text-right",
|
|
className,
|
|
)}
|
|
>
|
|
<div className="min-w-0 space-y-1.5">
|
|
<div className={cn(
|
|
"flex items-center gap-1.5 text-xs text-muted-foreground transition-colors group-hover:text-foreground",
|
|
direction === "next" && "sm:justify-end",
|
|
)}>
|
|
{direction === "previous" ? <Icon className="h-3.5 w-3.5 shrink-0" /> : null}
|
|
<span>{label}</span>
|
|
{direction === "next" ? <Icon className="h-3.5 w-3.5 shrink-0" /> : null}
|
|
</div>
|
|
<div className={cn(
|
|
"flex min-w-0 items-center gap-1.5 text-xs font-mono text-muted-foreground transition-colors group-hover:text-foreground",
|
|
direction === "next" && "sm:justify-end",
|
|
)}>
|
|
<StatusIcon status={issue.status} blockerAttention={issue.blockerAttention} />
|
|
<span className="shrink-0">{identifier}</span>
|
|
</div>
|
|
<div className="truncate text-sm text-foreground">
|
|
{issue.title}
|
|
</div>
|
|
</div>
|
|
</Link>
|
|
);
|
|
}
|