forked from farhoodlabs/paperclip
0c6f9bdcf8
## Thinking Path > - Paperclip orchestrates AI agents through visible, governable task and routine workflows. > - The routines UI includes the routine detail page, properties panel, history tab, and shared sidebar components. > - PR #5703 changed that workflow by widening the routine properties panel and moving revision inspection/comparison into dialogs. > - The product direction for that change is being paused for now, so the safest path is a direct revert instead of partial edits. > - This pull request reverts merge commit `74cb560c41305ac3283067d1ec8d3060ffdc28cb` from #5703. > - The benefit is restoring the prior routines UI behavior while keeping the revert easy to review and re-apply later if needed. ## What Changed - Reverted #5703: `fix(ui): improve routine properties panel and history UX`. - Restored the previous routine properties panel sizing, panel context API, routine detail layout, and routine history rendering behavior. - Removed the reverted sidebar pane test additions and restored the previous focused routine history test expectations. ## Verification - `git diff --check origin/master..HEAD` - `pnpm vitest run ui/src/components/RoutineHistoryTab.test.tsx` - `pnpm --filter @paperclipai/ui typecheck` ### Screenshots This is a direct revert of #5703. The visual state after this PR corresponds to the "Before" screenshots from #5703, and the state being removed corresponds to the "After" screenshots from #5703. #### Trigger Panel Width | Before this revert | After this revert | | --- | --- | | <img width="1742" height="1288" alt="triggers-before-this-revert" src="https://github.com/user-attachments/assets/9e818978-283c-49a3-9401-879be550c67b" /> | <img width="1741" height="1289" alt="triggers-after-this-revert" src="https://github.com/user-attachments/assets/2a391769-c355-4219-8da3-d1ea18698430" /> | #### History Panel | Before this revert | After this revert | | --- | --- | | <img width="1741" height="1290" alt="history-before-this-revert" src="https://github.com/user-attachments/assets/4c139238-8494-4438-89e1-4277d05bc3aa" /> | <img width="1739" height="1289" alt="history-after-this-revert" src="https://github.com/user-attachments/assets/eaea4f3d-bb65-4af6-b67f-3ba3026fe0c9" /> | ## Risks - Low technical risk: this is a clean Git revert of a recently merged UI-only PR. - Product risk: the routine properties panel and revision history return to the older, narrower workflow that #5703 was improving. - Re-application risk: future work that wants the #5703 behavior back should re-apply it deliberately rather than cherry-picking around this revert. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5 coding agent, tool-enabled with local shell and GitHub CLI access. Context window size was not exposed in this session. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge Co-authored-by: Paperclip <noreply@paperclip.ing>
86 lines
2.8 KiB
TypeScript
86 lines
2.8 KiB
TypeScript
import { useCallback, useEffect, useState } from "react";
|
|
import { ArrowDown } from "lucide-react";
|
|
import { usePanel } from "../context/PanelContext";
|
|
import { cn } from "../lib/utils";
|
|
|
|
function resolveScrollTarget() {
|
|
const mainContent = document.getElementById("main-content");
|
|
|
|
if (mainContent instanceof HTMLElement) {
|
|
const overflowY = window.getComputedStyle(mainContent).overflowY;
|
|
const usesOwnScroll =
|
|
(overflowY === "auto" || overflowY === "scroll" || overflowY === "overlay")
|
|
&& mainContent.scrollHeight > mainContent.clientHeight + 1;
|
|
|
|
if (usesOwnScroll) {
|
|
return { type: "element" as const, element: mainContent };
|
|
}
|
|
}
|
|
|
|
return { type: "window" as const };
|
|
}
|
|
|
|
function distanceFromBottom(target: ReturnType<typeof resolveScrollTarget>) {
|
|
if (target.type === "element") {
|
|
return target.element.scrollHeight - target.element.scrollTop - target.element.clientHeight;
|
|
}
|
|
|
|
const scroller = document.scrollingElement ?? document.documentElement;
|
|
return scroller.scrollHeight - window.scrollY - window.innerHeight;
|
|
}
|
|
|
|
/**
|
|
* Floating scroll-to-bottom button that follows the active page scroller.
|
|
* On desktop that is `#main-content`; on mobile it falls back to window/page scroll.
|
|
*/
|
|
export function ScrollToBottom() {
|
|
const [visible, setVisible] = useState(false);
|
|
const { panelVisible, panelContent } = usePanel();
|
|
|
|
useEffect(() => {
|
|
const check = () => {
|
|
setVisible(distanceFromBottom(resolveScrollTarget()) > 300);
|
|
};
|
|
|
|
const mainContent = document.getElementById("main-content");
|
|
|
|
check();
|
|
mainContent?.addEventListener("scroll", check, { passive: true });
|
|
window.addEventListener("scroll", check, { passive: true });
|
|
window.addEventListener("resize", check);
|
|
|
|
return () => {
|
|
mainContent?.removeEventListener("scroll", check);
|
|
window.removeEventListener("scroll", check);
|
|
window.removeEventListener("resize", check);
|
|
};
|
|
}, []);
|
|
|
|
const scroll = useCallback(() => {
|
|
const target = resolveScrollTarget();
|
|
|
|
if (target.type === "element") {
|
|
target.element.scrollTo({ top: target.element.scrollHeight, behavior: "smooth" });
|
|
return;
|
|
}
|
|
|
|
const scroller = document.scrollingElement ?? document.documentElement;
|
|
window.scrollTo({ top: scroller.scrollHeight, behavior: "smooth" });
|
|
}, []);
|
|
|
|
if (!visible) return null;
|
|
|
|
return (
|
|
<button
|
|
onClick={scroll}
|
|
className={cn(
|
|
"fixed bottom-[calc(1.5rem+5rem+env(safe-area-inset-bottom))] right-6 z-40 flex h-9 w-9 items-center justify-center rounded-full border border-border bg-background shadow-md hover:bg-accent transition-[background-color,right] duration-200 md:bottom-6",
|
|
panelVisible && panelContent && "md:right-[calc(320px+1.5rem)]",
|
|
)}
|
|
aria-label="Scroll to bottom"
|
|
>
|
|
<ArrowDown className="h-4 w-4" />
|
|
</button>
|
|
);
|
|
}
|