forked from farhoodlabs/paperclip
90117827eb
## Thinking Path > - Paperclip is the board UI and control plane for supervising AI-agent companies. > - Operators repeatedly use mobile navigation, issue creation, inbox scanning, and markdown reading surfaces. > - Small layout and interaction rough edges add friction to those high-frequency workflows. > - The branch included a set of related board UI polish changes that were too small to review as many separate PRs. > - This pull request groups the remaining mobile/navigation/markdown polish into one standalone branch. > - The benefit is smoother board operation without mixing in unrelated backend feature work. ## What Changed - Tightened company settings navigation behavior on mobile. - Fixed mobile new issue dialog height and moved issue priority into the overflow controls on small screens. - Restored browser controls for home-screen app mode. - Fixed plugin-route sidebar selection on nested page loads. - Added markdown preformatted-block wrapping controls and coverage. - Kept updated issue list pages sorted by updated time in the board UI. ## Verification - `pnpm --filter @paperclipai/plugin-sdk build` - `NODE_ENV=test pnpm exec vitest run ui/src/components/Layout.test.tsx ui/src/components/MarkdownBody.test.tsx ui/src/components/MarkdownBody.wrap.test.tsx ui/src/components/NewIssueDialog.test.tsx ui/src/components/access/CompanySettingsNav.test.tsx ui/src/lib/pwa-install-mode.test.ts ui/src/pages/Inbox.test.tsx` The targeted UI tests passed. React emitted existing act-wrapping warnings in a few test files, but there were no test failures. ## Risks - Medium-low: changes span several UI surfaces, but they are mostly layout/interaction polish with targeted component tests. - Visual screenshots are not newly captured in this split PR; follow-up review should include browser/visual QA before marking ready. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI GPT-5 Codex via `codex_local`, tool-enabled coding session; exact context window not exposed by this runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
117 lines
3.9 KiB
TypeScript
117 lines
3.9 KiB
TypeScript
// @vitest-environment jsdom
|
|
|
|
import { createRoot } from "react-dom/client";
|
|
import { flushSync } from "react-dom";
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
import { CompanySettingsNav, getCompanySettingsTab } from "./CompanySettingsNav";
|
|
|
|
let currentPathname = "/company/settings";
|
|
const navigateMock = vi.hoisted(() => vi.fn());
|
|
const pageTabBarMock = vi.hoisted(() => vi.fn());
|
|
|
|
vi.mock("@/lib/router", () => ({
|
|
useLocation: () => ({ pathname: currentPathname, search: "", hash: "" }),
|
|
useNavigate: () => navigateMock,
|
|
}));
|
|
|
|
vi.mock("@/components/ui/tabs", () => ({
|
|
Tabs: ({ children }: { children: React.ReactNode }) => <div data-testid="tabs-root">{children}</div>,
|
|
}));
|
|
|
|
vi.mock("@/components/PageTabBar", () => ({
|
|
PageTabBar: (props: {
|
|
items: Array<{ value: string; label: string }>;
|
|
value?: string;
|
|
onValueChange?: (value: string) => void;
|
|
}) => {
|
|
pageTabBarMock(props);
|
|
|
|
return (
|
|
<div>
|
|
<div data-testid="active-tab">{props.value}</div>
|
|
<button type="button" onClick={() => props.onValueChange?.("invites")}>
|
|
switch-tab
|
|
</button>
|
|
</div>
|
|
);
|
|
},
|
|
}));
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
(globalThis as any).IS_REACT_ACT_ENVIRONMENT = true;
|
|
|
|
async function act(callback: () => void | Promise<void>) {
|
|
let result: void | Promise<void> = undefined;
|
|
flushSync(() => {
|
|
result = callback();
|
|
});
|
|
await result;
|
|
}
|
|
|
|
describe("CompanySettingsNav", () => {
|
|
let container: HTMLDivElement;
|
|
|
|
beforeEach(() => {
|
|
container = document.createElement("div");
|
|
document.body.appendChild(container);
|
|
currentPathname = "/company/settings";
|
|
});
|
|
|
|
afterEach(() => {
|
|
container.remove();
|
|
document.body.innerHTML = "";
|
|
vi.clearAllMocks();
|
|
});
|
|
|
|
it("maps company settings routes to the expected shared tab value", () => {
|
|
expect(getCompanySettingsTab("/company/settings")).toBe("general");
|
|
expect(getCompanySettingsTab("/PAP/company/settings")).toBe("general");
|
|
expect(getCompanySettingsTab("/company/settings/environments")).toBe("environments");
|
|
expect(getCompanySettingsTab("/PAP/company/settings/environments")).toBe("environments");
|
|
expect(getCompanySettingsTab("/company/settings/cloud-upstream")).toBe("cloud-upstream");
|
|
expect(getCompanySettingsTab("/company/settings/members")).toBe("members");
|
|
expect(getCompanySettingsTab("/PAP/company/settings/members")).toBe("members");
|
|
expect(getCompanySettingsTab("/company/settings/access")).toBe("members");
|
|
expect(getCompanySettingsTab("/PAP/company/settings/access")).toBe("members");
|
|
expect(getCompanySettingsTab("/company/settings/invites")).toBe("invites");
|
|
expect(getCompanySettingsTab("/PAP/company/settings/secrets")).toBe("secrets");
|
|
});
|
|
|
|
it("renders the active tab and navigates when a different tab is selected", async () => {
|
|
currentPathname = "/PAP/company/settings/members";
|
|
const root = createRoot(container);
|
|
|
|
await act(async () => {
|
|
root.render(<CompanySettingsNav />);
|
|
});
|
|
|
|
expect(container.textContent).toContain("members");
|
|
expect(pageTabBarMock).toHaveBeenCalledWith(
|
|
expect.objectContaining({
|
|
value: "members",
|
|
items: [
|
|
{ value: "general", label: "General" },
|
|
{ value: "environments", label: "Environments" },
|
|
{ value: "cloud-upstream", label: "Cloud upstream" },
|
|
{ value: "members", label: "Members" },
|
|
{ value: "invites", label: "Invites" },
|
|
{ value: "secrets", label: "Secrets" },
|
|
],
|
|
}),
|
|
);
|
|
|
|
const button = container.querySelector("button");
|
|
expect(button).not.toBeNull();
|
|
|
|
await act(async () => {
|
|
button?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
|
|
expect(navigateMock).toHaveBeenCalledWith("/company/settings/invites");
|
|
|
|
await act(async () => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
});
|