Files
paperclip/ui/src/lib/issue-tree.test.ts
T
Darren Davison 7623f679cf fix: count all descendants in collapsed badge and prune stale localStorage IDs
Address two Greptile review comments:

1. Collapsed parent badge now shows total descendant count at all depths
   rather than direct-child count only. Add `countDescendants` utility to
   issue-tree.ts (recursive, uses existing childMap) and replace
   `children.length` with it in the titleSuffix badge.

2. Add a useEffect that prunes stale IDs from `collapsedParents` whenever
   the issues prop changes. Deleted or reassigned issues previously left
   orphan IDs in localStorage indefinitely; the effect filters to only IDs
   that appear as a parentId in the current issue list and persists the
   cleaned array via updateView.

Add four unit tests for countDescendants: leaf node, single-level,
multi-level, and unknown ID.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
2026-04-05 12:02:49 +01:00

131 lines
4.4 KiB
TypeScript

import { describe, expect, it } from "vitest";
import type { Issue } from "@paperclipai/shared";
import { buildIssueTree, countDescendants } from "./issue-tree";
function makeIssue(id: string, parentId: string | null = null): Issue {
return {
id,
identifier: id.toUpperCase(),
companyId: "company-1",
projectId: null,
projectWorkspaceId: null,
goalId: null,
parentId,
title: `Issue ${id}`,
description: null,
status: "todo",
priority: "medium",
assigneeAgentId: null,
assigneeUserId: null,
createdByAgentId: null,
createdByUserId: null,
issueNumber: 1,
requestDepth: 0,
billingCode: null,
assigneeAdapterOverrides: null,
executionWorkspaceId: null,
executionWorkspacePreference: null,
executionWorkspaceSettings: null,
checkoutRunId: null,
executionRunId: null,
executionAgentNameKey: null,
executionLockedAt: null,
startedAt: null,
completedAt: null,
cancelledAt: null,
hiddenAt: null,
createdAt: new Date("2026-01-01T00:00:00.000Z"),
updatedAt: new Date("2026-01-01T00:00:00.000Z"),
labels: [],
labelIds: [],
myLastTouchAt: null,
lastExternalCommentAt: null,
isUnreadForMe: false,
};
}
describe("buildIssueTree", () => {
it("returns all items as roots when no parent-child relationships exist", () => {
const items = [makeIssue("a"), makeIssue("b"), makeIssue("c")];
const { roots, childMap } = buildIssueTree(items);
expect(roots.map((r) => r.id)).toEqual(["a", "b", "c"]);
expect(childMap.size).toBe(0);
});
it("places children under their parent and excludes them from roots", () => {
const parent = makeIssue("parent");
const child1 = makeIssue("child1", "parent");
const child2 = makeIssue("child2", "parent");
const { roots, childMap } = buildIssueTree([parent, child1, child2]);
expect(roots.map((r) => r.id)).toEqual(["parent"]);
expect(childMap.get("parent")?.map((c) => c.id)).toEqual(["child1", "child2"]);
});
it("handles multiple levels of nesting", () => {
const grandparent = makeIssue("gp");
const parent = makeIssue("p", "gp");
const child = makeIssue("c", "p");
const { roots, childMap } = buildIssueTree([grandparent, parent, child]);
expect(roots.map((r) => r.id)).toEqual(["gp"]);
expect(childMap.get("gp")?.map((i) => i.id)).toEqual(["p"]);
expect(childMap.get("p")?.map((i) => i.id)).toEqual(["c"]);
});
it("promotes orphaned sub-tasks (parent not in list) to root level", () => {
// child references a parent that is not in the items array (e.g. filtered out)
const child = makeIssue("child", "missing-parent");
const unrelated = makeIssue("unrelated");
const { roots, childMap } = buildIssueTree([child, unrelated]);
expect(roots.map((r) => r.id)).toEqual(["child", "unrelated"]);
expect(childMap.size).toBe(0);
});
it("returns empty roots and empty childMap for an empty list", () => {
const { roots, childMap } = buildIssueTree([]);
expect(roots).toEqual([]);
expect(childMap.size).toBe(0);
});
it("preserves list order within roots and within children", () => {
const p1 = makeIssue("p1");
const p2 = makeIssue("p2");
const c1 = makeIssue("c1", "p1");
const c2 = makeIssue("c2", "p1");
const { roots, childMap } = buildIssueTree([p1, c1, p2, c2]);
expect(roots.map((r) => r.id)).toEqual(["p1", "p2"]);
expect(childMap.get("p1")?.map((c) => c.id)).toEqual(["c1", "c2"]);
});
});
describe("countDescendants", () => {
it("returns 0 for a leaf node", () => {
const { childMap } = buildIssueTree([makeIssue("a")]);
expect(countDescendants("a", childMap)).toBe(0);
});
it("returns direct child count for a single-level parent", () => {
const { childMap } = buildIssueTree([
makeIssue("p"),
makeIssue("c1", "p"),
makeIssue("c2", "p"),
]);
expect(countDescendants("p", childMap)).toBe(2);
});
it("counts all descendants across multiple levels", () => {
// P → C → G1, G2 (P has 3 total descendants: C, G1, G2)
const { childMap } = buildIssueTree([
makeIssue("p"),
makeIssue("c", "p"),
makeIssue("g1", "c"),
makeIssue("g2", "c"),
]);
expect(countDescendants("p", childMap)).toBe(3);
});
it("returns 0 for an id not in the childMap", () => {
const { childMap } = buildIssueTree([makeIssue("a"), makeIssue("b")]);
expect(countDescendants("nonexistent", childMap)).toBe(0);
});
});