forked from farhoodlabs/paperclip
4272c1604d
## Thinking Path > - Paperclip orchestrates AI-agent companies through a control plane that can start, supervise, and recover agent runs. > - Local adapters are the bridge between Paperclip issues and concrete agent runtimes such as Claude, Codex, and other ACP-compatible tools. > - The roadmap calls out broader “bring your own agent” and claw-style agent support, and ACPX gives Paperclip one path to normalize multiple ACP agents behind a single adapter. > - The branch needed to become one reviewable PR against current `paperclipai/paperclip:master`, without carrying stale base conflicts or generated lockfile churn. > - This pull request adds an experimental built-in `acpx_local` adapter, integrates it through the server/CLI/UI adapter surfaces, and adds regression coverage for runtime execution, skill sync, stream parsing, diagnostics, and log redaction. > - The benefit is that Paperclip can run Claude/Codex/custom ACP agents through ACPX while keeping operator configuration, skills, logging, and transcript rendering inside the existing adapter model. ## What Changed - Added `@paperclipai/adapter-acpx-local` with server execution, config schema, ACPX session handling, CLI formatting, UI config helpers, and stdout parsing. - Registered `acpx_local` across CLI, server, shared constants, UI adapter metadata, adapter capabilities, and agent creation/editing surfaces. - Added ACPX runtime execution support with persistent sessions, local-agent JWT environment handling, skill snapshots, runtime skill materialization, and isolation/security regressions. - Added ACPX adapter diagnostics and marked the adapter experimental in the UI. - Added command/env secret redaction for resolved command metadata in adapter-utils, server event storage, and the Agent Detail invocation UI. - Added Storybook coverage for ACPX config, transcript rendering, and skill states, plus PR screenshots under `docs/pr-screenshots/pap-2944/`. - Rebased the branch onto current `public-gh/master`; `pnpm-lock.yaml` is intentionally not included and there are no migration/schema changes. ## Verification - `pnpm exec vitest run packages/adapters/acpx-local/src/server/execute.test.ts packages/adapters/acpx-local/src/server/test.test.ts packages/adapters/acpx-local/src/cli/format-event.test.ts packages/adapters/acpx-local/src/ui/parse-stdout.test.ts packages/adapter-utils/src/server-utils.test.ts server/src/__tests__/redaction.test.ts server/src/__tests__/acpx-local-execute.test.ts server/src/__tests__/acpx-local-skill-sync.test.ts server/src/__tests__/acpx-local-adapter-environment.test.ts server/src/__tests__/adapter-routes.test.ts server/src/__tests__/agent-skills-routes.test.ts ui/src/adapters/metadata.test.ts` — 12 files, 87 tests passed. - `pnpm --filter @paperclipai/adapter-acpx-local typecheck` — passed. - `pnpm --filter @paperclipai/server typecheck` — passed. - `pnpm --filter @paperclipai/ui typecheck` — passed. - Confirmed PR diff does not include `pnpm-lock.yaml`, database schema files, or migrations. Screenshots:    ## Risks - Medium risk: this introduces a new built-in adapter package and touches runtime execution, adapter registration, agent config, skills, and transcript rendering. - ACPX and ACP agent behavior can vary by installed tool versions; the adapter is marked experimental to set operator expectations. - `pnpm-lock.yaml` is excluded per repository PR policy, so dependency lock refresh must be handled by the repo’s automation or maintainers. - No database migration risk: no schema or migration files changed. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex coding agent based on GPT-5, with repository tool use, shell execution, git operations, and local verification. Exact hosted context window was not exposed in this environment. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
216 lines
7.5 KiB
TypeScript
216 lines
7.5 KiB
TypeScript
import { useState, useMemo } from "react";
|
|
import { useQuery } from "@tanstack/react-query";
|
|
import { useNavigate } from "@/lib/router";
|
|
import { useDialog } from "../context/DialogContext";
|
|
import { useCompany } from "../context/CompanyContext";
|
|
import { agentsApi } from "../api/agents";
|
|
import { adaptersApi } from "../api/adapters";
|
|
import { queryKeys } from "@/lib/queryKeys";
|
|
import {
|
|
Dialog,
|
|
DialogContent,
|
|
} from "@/components/ui/dialog";
|
|
import { Button } from "@/components/ui/button";
|
|
import {
|
|
ArrowLeft,
|
|
Bot,
|
|
} from "lucide-react";
|
|
import { cn } from "@/lib/utils";
|
|
import { listUIAdapters } from "../adapters";
|
|
import { isVisualAdapterChoice } from "../adapters/metadata";
|
|
import { getAdapterDisplay } from "../adapters/adapter-display-registry";
|
|
import { useDisabledAdaptersSync } from "../adapters/use-disabled-adapters";
|
|
|
|
/**
|
|
* Adapter types that are suitable for agent creation (excludes internal
|
|
* system adapters like "process" and "http").
|
|
*/
|
|
const SYSTEM_ADAPTER_TYPES = new Set(["process", "http"]);
|
|
|
|
function isAgentAdapterType(type: string): boolean {
|
|
return !SYSTEM_ADAPTER_TYPES.has(type);
|
|
}
|
|
|
|
export function NewAgentDialog() {
|
|
const { newAgentOpen, closeNewAgent, openNewIssue } = useDialog();
|
|
const { selectedCompanyId } = useCompany();
|
|
const navigate = useNavigate();
|
|
const [showAdvancedCards, setShowAdvancedCards] = useState(false);
|
|
const disabledTypes = useDisabledAdaptersSync();
|
|
|
|
// Fetch registered adapters from server (syncs disabled store + provides data)
|
|
const { data: serverAdapters } = useQuery({
|
|
queryKey: queryKeys.adapters.all,
|
|
queryFn: () => adaptersApi.list(),
|
|
staleTime: 5 * 60 * 1000,
|
|
});
|
|
|
|
// Fetch existing agents for the "Ask CEO" flow
|
|
const { data: agents } = useQuery({
|
|
queryKey: queryKeys.agents.list(selectedCompanyId!),
|
|
queryFn: () => agentsApi.list(selectedCompanyId!),
|
|
enabled: !!selectedCompanyId && newAgentOpen,
|
|
});
|
|
|
|
const ceoAgent = (agents ?? []).find((a) => a.role === "ceo");
|
|
|
|
// Build the adapter grid from the UI registry merged with display metadata.
|
|
// This automatically includes external/plugin adapters.
|
|
const adapterGrid = useMemo(() => {
|
|
const registered = listUIAdapters()
|
|
.filter((a) =>
|
|
isAgentAdapterType(a.type) &&
|
|
!disabledTypes.has(a.type) &&
|
|
isVisualAdapterChoice(a.type)
|
|
);
|
|
|
|
// Sort: recommended first, then alphabetical
|
|
return registered
|
|
.map((a) => {
|
|
const display = getAdapterDisplay(a.type);
|
|
return {
|
|
value: a.type,
|
|
label: display.label,
|
|
desc: display.description,
|
|
icon: display.icon,
|
|
recommended: display.recommended,
|
|
comingSoon: display.comingSoon,
|
|
disabledLabel: display.disabledLabel,
|
|
};
|
|
})
|
|
.sort((a, b) => {
|
|
if (a.recommended && !b.recommended) return -1;
|
|
if (!a.recommended && b.recommended) return 1;
|
|
return a.label.localeCompare(b.label);
|
|
});
|
|
}, [disabledTypes, serverAdapters]);
|
|
|
|
function handleAskCeo() {
|
|
closeNewAgent();
|
|
openNewIssue({
|
|
assigneeAgentId: ceoAgent?.id,
|
|
title: "Create a new agent",
|
|
description: "(type in what kind of agent you want here)",
|
|
});
|
|
}
|
|
|
|
function handleAdvancedConfig() {
|
|
setShowAdvancedCards(true);
|
|
}
|
|
|
|
function handleAdvancedAdapterPick(adapterType: string) {
|
|
closeNewAgent();
|
|
setShowAdvancedCards(false);
|
|
navigate(`/agents/new?adapterType=${encodeURIComponent(adapterType)}`);
|
|
}
|
|
|
|
return (
|
|
<Dialog
|
|
open={newAgentOpen}
|
|
onOpenChange={(open) => {
|
|
if (!open) {
|
|
setShowAdvancedCards(false);
|
|
closeNewAgent();
|
|
}
|
|
}}
|
|
>
|
|
<DialogContent
|
|
showCloseButton={false}
|
|
className="sm:max-w-md p-0 gap-0 overflow-hidden"
|
|
>
|
|
{/* Header */}
|
|
<div className="flex items-center justify-between px-4 py-2.5 border-b border-border">
|
|
<span className="text-sm text-muted-foreground">Add a new agent</span>
|
|
<Button
|
|
variant="ghost"
|
|
size="icon-xs"
|
|
className="text-muted-foreground"
|
|
onClick={() => {
|
|
setShowAdvancedCards(false);
|
|
closeNewAgent();
|
|
}}
|
|
>
|
|
<span className="text-lg leading-none">×</span>
|
|
</Button>
|
|
</div>
|
|
|
|
<div className="p-6 space-y-6">
|
|
{!showAdvancedCards ? (
|
|
<>
|
|
{/* Recommendation */}
|
|
<div className="text-center space-y-3">
|
|
<div className="mx-auto flex h-12 w-12 items-center justify-center rounded-full bg-accent">
|
|
<Bot className="h-6 w-6 text-foreground" />
|
|
</div>
|
|
<p className="text-sm text-muted-foreground">
|
|
We recommend letting your CEO handle agent setup — they know the
|
|
org structure and can configure reporting, permissions, and
|
|
adapters.
|
|
</p>
|
|
</div>
|
|
|
|
<Button className="w-full" size="lg" onClick={handleAskCeo}>
|
|
<Bot className="h-4 w-4 mr-2" />
|
|
Ask the CEO to create a new agent
|
|
</Button>
|
|
|
|
{/* Advanced link */}
|
|
<div className="text-center">
|
|
<button
|
|
className="text-xs text-muted-foreground hover:text-foreground underline underline-offset-2 transition-colors"
|
|
onClick={handleAdvancedConfig}
|
|
>
|
|
I want advanced configuration myself
|
|
</button>
|
|
</div>
|
|
</>
|
|
) : (
|
|
<>
|
|
<div className="space-y-2">
|
|
<button
|
|
className="inline-flex items-center gap-1 text-xs text-muted-foreground hover:text-foreground transition-colors"
|
|
onClick={() => setShowAdvancedCards(false)}
|
|
>
|
|
<ArrowLeft className="h-3.5 w-3.5" />
|
|
Back
|
|
</button>
|
|
<p className="text-sm text-muted-foreground">
|
|
Choose your adapter type for advanced setup.
|
|
</p>
|
|
</div>
|
|
|
|
<div className="grid grid-cols-2 gap-2">
|
|
{adapterGrid.map((opt) => (
|
|
<button
|
|
key={opt.value}
|
|
className={cn(
|
|
"flex flex-col items-center gap-1.5 rounded-md border border-border p-3 text-xs transition-colors hover:bg-accent/50 relative",
|
|
opt.comingSoon && "opacity-40 cursor-not-allowed",
|
|
)}
|
|
disabled={!!opt.comingSoon}
|
|
title={opt.comingSoon ? opt.disabledLabel : undefined}
|
|
onClick={() => {
|
|
if (!opt.comingSoon) handleAdvancedAdapterPick(opt.value);
|
|
}}
|
|
>
|
|
{opt.recommended && (
|
|
<span className="absolute -top-1.5 right-1.5 bg-green-500 text-white text-[9px] font-semibold px-1.5 py-0.5 rounded-full leading-none">
|
|
Recommended
|
|
</span>
|
|
)}
|
|
<opt.icon className="h-4 w-4" />
|
|
<span className="font-medium">{opt.label}</span>
|
|
<span className="text-muted-foreground text-[10px]">
|
|
{opt.desc}
|
|
</span>
|
|
</button>
|
|
))}
|
|
</div>
|
|
</>
|
|
)}
|
|
</div>
|
|
</DialogContent>
|
|
</Dialog>
|
|
);
|
|
}
|