forked from farhoodlabs/paperclip
a26e1288b6
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies > - Human operators supervise that work through issue lists, issue detail, comments, inbox groups, markdown references, and profile/activity surfaces > - The branch had many small UI fixes that improve the operator loop but do not need to ship with backend runtime migrations > - These changes belong together as board workflow polish because they affect scanning, navigation, issue context, comment state, and markdown clarity > - This pull request groups the UI-only slice so it can merge independently from runtime/backend changes > - The benefit is a clearer board experience with better issue context, steadier optimistic updates, and more predictable keyboard navigation ## What Changed - Improves issue properties, sub-issue actions, blocker chips, and issue list/detail refresh behavior. - Adds blocker context above the issue composer and stabilizes queued/interrupted comment UI state. - Improves markdown issue/GitHub link rendering and opens external markdown links in a new tab. - Adds inbox group keyboard navigation and fold/unfold support. - Polishes activity/avatar/profile/settings/workspace presentation details. ## Verification - `pnpm exec vitest run ui/src/components/IssueProperties.test.tsx ui/src/components/IssueChatThread.test.tsx ui/src/components/MarkdownBody.test.tsx ui/src/lib/inbox.test.ts ui/src/lib/optimistic-issue-comments.test.ts` ## Risks - Low to medium risk: changes are UI-focused but cover high-traffic issue and inbox surfaces. - This branch intentionally does not include the backend runtime changes from the companion PR; where UI calls newer API filters, unsupported servers should continue to fail visibly through existing API error handling. - Visual screenshots were not captured in this heartbeat; targeted component/helper tests cover the changed behavior. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5-based coding agent runtime, shell/git tool use enabled. Exact hosted model build and context window are not exposed in this Paperclip heartbeat environment. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge
95 lines
3.0 KiB
TypeScript
95 lines
3.0 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import type { Issue } from "@paperclipai/shared";
|
|
import { buildIssuePropertiesPanelKey } from "./issue-properties-panel-key";
|
|
|
|
function createIssue(overrides: Partial<Issue> = {}) {
|
|
return {
|
|
id: "issue-1",
|
|
status: "in_progress" as const,
|
|
priority: "medium" as const,
|
|
assigneeAgentId: "agent-1",
|
|
assigneeUserId: null,
|
|
projectId: "project-1",
|
|
projectWorkspaceId: null,
|
|
parentId: null,
|
|
createdByUserId: "user-1",
|
|
hiddenAt: null,
|
|
labelIds: ["label-1"],
|
|
executionPolicy: null,
|
|
executionState: null,
|
|
executionWorkspaceId: null,
|
|
executionWorkspacePreference: null,
|
|
executionWorkspaceSettings: null,
|
|
currentExecutionWorkspace: null,
|
|
blocks: [],
|
|
blockedBy: [],
|
|
ancestors: [],
|
|
updatedAt: new Date("2026-04-12T12:00:00.000Z"),
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
describe("buildIssuePropertiesPanelKey", () => {
|
|
it("ignores plain updatedAt churn", () => {
|
|
const first = buildIssuePropertiesPanelKey(createIssue(), []);
|
|
const second = buildIssuePropertiesPanelKey(
|
|
createIssue({ updatedAt: new Date("2026-04-12T12:05:00.000Z") }),
|
|
[],
|
|
);
|
|
|
|
expect(second).toBe(first);
|
|
});
|
|
|
|
it("changes when a displayed property changes", () => {
|
|
const first = buildIssuePropertiesPanelKey(createIssue(), []);
|
|
const second = buildIssuePropertiesPanelKey(
|
|
createIssue({ assigneeAgentId: "agent-2" }),
|
|
[],
|
|
);
|
|
|
|
expect(second).not.toBe(first);
|
|
});
|
|
|
|
it("changes when workspace detail hydrates after opening from a cached issue", () => {
|
|
const first = buildIssuePropertiesPanelKey(createIssue(), []);
|
|
const second = buildIssuePropertiesPanelKey(
|
|
createIssue({
|
|
executionWorkspaceId: "workspace-1",
|
|
executionWorkspacePreference: "reuse_existing",
|
|
executionWorkspaceSettings: { mode: "isolated_workspace" },
|
|
currentExecutionWorkspace: {
|
|
id: "workspace-1",
|
|
companyId: "company-1",
|
|
projectId: "project-1",
|
|
projectWorkspaceId: "project-workspace-1",
|
|
sourceIssueId: "issue-1",
|
|
mode: "isolated_workspace",
|
|
strategyType: "git_worktree",
|
|
name: "PAP-1 workspace",
|
|
status: "active",
|
|
cwd: "/tmp/paperclip/PAP-1",
|
|
repoUrl: null,
|
|
baseRef: "master",
|
|
branchName: "PAP-1-workspace",
|
|
providerType: "git_worktree",
|
|
providerRef: "/tmp/paperclip/PAP-1",
|
|
derivedFromExecutionWorkspaceId: null,
|
|
lastUsedAt: new Date("2026-04-12T12:01:00.000Z"),
|
|
openedAt: new Date("2026-04-12T12:01:00.000Z"),
|
|
closedAt: null,
|
|
cleanupEligibleAt: null,
|
|
cleanupReason: null,
|
|
config: null,
|
|
metadata: null,
|
|
runtimeServices: [],
|
|
createdAt: new Date("2026-04-12T12:01:00.000Z"),
|
|
updatedAt: new Date("2026-04-12T12:01:00.000Z"),
|
|
},
|
|
}),
|
|
[],
|
|
);
|
|
|
|
expect(second).not.toBe(first);
|
|
});
|
|
});
|