forked from farhoodlabs/paperclip
ab9051b595
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies. > - Operators and agents coordinate through company-scoped issues, comments, documents, and task relationships. > - Issue text can mention other tickets, but those references were previously plain markdown/text without durable relationship data. > - That made it harder to understand related work, surface backlinks, and keep cross-ticket context visible in the board. > - This pull request adds first-class issue reference extraction, storage, API responses, and UI surfaces. > - The benefit is that issue references become queryable, navigable, and visible without relying on ad hoc text scanning. ## What Changed - Added shared issue-reference parsing utilities and exported reference-related types/constants. - Added an `issue_reference_mentions` table, idempotent migration DDL, schema exports, and database documentation. - Added server-side issue reference services, route integration, activity summaries, and a backfill command for existing issue content. - Added UI reference pills, related-work panels, markdown/editor mention handling, and issue detail/property rendering updates. - Added focused shared, server, and UI tests for parsing, persistence, display, and related-work behavior. - Rebased `PAP-735-first-class-task-references` cleanly onto `public-gh/master`; no `pnpm-lock.yaml` changes are included. ## Verification - `pnpm -r typecheck` - `pnpm test:run packages/shared/src/issue-references.test.ts server/src/__tests__/issue-references-service.test.ts ui/src/components/IssueRelatedWorkPanel.test.tsx ui/src/components/IssueProperties.test.tsx ui/src/components/MarkdownBody.test.tsx` ## Risks - Medium risk because this adds a new issue-reference persistence path that touches shared parsing, database schema, server routes, and UI rendering. - Migration risk is mitigated by `CREATE TABLE IF NOT EXISTS`, guarded foreign-key creation, and `CREATE INDEX IF NOT EXISTS` statements so users who have applied an older local version of the numbered migration can re-run safely. - UI risk is limited by focused component coverage, but reviewers should still manually inspect issue detail pages containing ticket references before merge. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5-based coding agent, tool-using shell workflow with repository inspection, git rebase/push, typecheck, and focused Vitest verification. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: dotta <dotta@example.com> Co-authored-by: Paperclip <noreply@paperclip.ing>
69 lines
2.3 KiB
TypeScript
69 lines
2.3 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import {
|
|
buildIssueReferenceHref,
|
|
extractIssueReferenceIdentifiers,
|
|
findIssueReferenceMatches,
|
|
normalizeIssueIdentifier,
|
|
parseIssueReferenceHref,
|
|
} from "./issue-references.js";
|
|
|
|
describe("issue references", () => {
|
|
it("normalizes identifiers to uppercase", () => {
|
|
expect(normalizeIssueIdentifier("pap-123")).toBe("PAP-123");
|
|
expect(normalizeIssueIdentifier("not-an-issue")).toBeNull();
|
|
});
|
|
|
|
it("parses relative and absolute issue hrefs", () => {
|
|
expect(parseIssueReferenceHref("/issues/PAP-123")).toEqual({ identifier: "PAP-123" });
|
|
expect(parseIssueReferenceHref("/PAP/issues/pap-456")).toEqual({ identifier: "PAP-456" });
|
|
expect(parseIssueReferenceHref("https://paperclip.ing/PAP/issues/pap-789#comment-1")).toEqual({
|
|
identifier: "PAP-789",
|
|
});
|
|
expect(parseIssueReferenceHref("https://paperclip.ing/projects/PAP-789")).toBeNull();
|
|
});
|
|
|
|
it("builds canonical issue hrefs", () => {
|
|
expect(buildIssueReferenceHref("pap-123")).toBe("/issues/PAP-123");
|
|
});
|
|
|
|
it("finds identifiers and issue paths in plain text", () => {
|
|
expect(findIssueReferenceMatches("See PAP-1, /issues/PAP-2, and https://x.test/PAP/issues/pap-3.")).toEqual([
|
|
{ index: 4, length: 5, identifier: "PAP-1", matchedText: "PAP-1" },
|
|
{ index: 11, length: 13, identifier: "PAP-2", matchedText: "/issues/PAP-2" },
|
|
{
|
|
index: 30,
|
|
length: 31,
|
|
identifier: "PAP-3",
|
|
matchedText: "https://x.test/PAP/issues/pap-3",
|
|
},
|
|
]);
|
|
});
|
|
|
|
it("trims unmatched square brackets from issue path tokens", () => {
|
|
expect(findIssueReferenceMatches("See /issues/PAP-123] for context.")).toEqual([
|
|
{ index: 4, length: 15, identifier: "PAP-123", matchedText: "/issues/PAP-123" },
|
|
]);
|
|
});
|
|
|
|
it("extracts and dedupes references from markdown", () => {
|
|
expect(extractIssueReferenceIdentifiers("PAP-1 [again](/issues/pap-1) PAP-2")).toEqual(["PAP-1", "PAP-2"]);
|
|
});
|
|
|
|
it("ignores inline code and fenced code blocks", () => {
|
|
const markdown = [
|
|
"Use PAP-1 here.",
|
|
"",
|
|
"`PAP-2` should not count.",
|
|
"",
|
|
"```md",
|
|
"PAP-3",
|
|
"/issues/PAP-4",
|
|
"```",
|
|
"",
|
|
"Final /issues/PAP-5 mention.",
|
|
].join("\n");
|
|
|
|
expect(extractIssueReferenceIdentifiers(markdown)).toEqual(["PAP-1", "PAP-5"]);
|
|
});
|
|
});
|