forked from farhoodlabs/paperclip
4142559c37
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies through company-scoped issues, comments, approvals, and execution workspaces. > - Operators need the Inbox to show not only active work, but also blocked work that may need human or agent attention. > - The existing inbox experience did not have a dedicated blocked-work surface, so blocked tasks were harder to triage and resume deliberately. > - Backend consumers also needed a compact attention signal that distinguishes actionable blockers from covered or waiting blocker states. > - This pull request adds a Blocked Inbox tab backed by issue blocker-attention metadata, shared validators, and UI helpers. > - The benefit is a clearer triage path for stalled or blocked Paperclip work without exposing external wait internals in the operator-facing UI. ## What Changed - Added shared issue blocker-attention types, validators, and exports for the API/UI contract. - Added backend blocker-attention computation and issue route support for blocked inbox data. - Added the Blocked Inbox tab, blocked reason chips, filtering/search UI, responsive layouts, and Storybook stories. - Updated inbox helpers and page behavior so toolbar controls only appear where they apply. - Added coverage for shared validators, server blocker-attention behavior, blocked inbox UI helpers/components, and the Inbox page. - Added a screenshot helper script for the blocked inbox Storybook stories. - Addressed Greptile feedback by making urgency sorting deterministic for null stop times, avoiding full blocked-inbox list enrichment for counts, and hardening the screenshot helper. ## Verification - Rebased the branch cleanly onto `public-gh/master`. - Confirmed the diff does not include `pnpm-lock.yaml`. - Confirmed the diff does not include database migration files. - Ran `pnpm exec vitest run packages/shared/src/validators/issue.test.ts server/src/__tests__/issue-blocker-attention.test.ts ui/src/components/BlockedInboxView.test.tsx ui/src/components/BlockedReasonChip.test.tsx ui/src/lib/blockedInbox.test.ts ui/src/lib/inbox.test.ts ui/src/pages/Inbox.test.tsx`. - Ran `pnpm --filter @paperclipai/shared typecheck && pnpm --filter @paperclipai/server typecheck && pnpm --filter @paperclipai/ui typecheck`. - Checked `ROADMAP.md`; this is scoped inbox/operator triage work and does not duplicate a listed roadmap feature. - Greptile Review is green on the latest head and all four Greptile review threads are resolved. - GitHub PR checks are green on the latest head: policy, security/snyk, e2e, verify, Canary Dry Run, Greptile Review, and serialized server suites 1/4 through 4/4. ## Risks - Medium review surface because this touches the shared issue contract, server issue services, and the Inbox UI together. - Blocker-attention classification may need product tuning after operators use it on real blocked queues. - UI screenshots were not attached in this PR-opening pass; the branch includes `scripts/screenshot-blocked-inbox.mjs` and Storybook stories for visual capture. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used OpenAI Codex, GPT-5-based coding agent with shell, git, GitHub CLI, GitHub connector, and Paperclip API tool use. Reasoning mode: medium. Context window: not exposed by the runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
83 lines
2.9 KiB
TypeScript
83 lines
2.9 KiB
TypeScript
import { AlertTriangle, Clock, Pause, User, Wrench } from "lucide-react";
|
|
import type { ComponentType } from "react";
|
|
import type { IssueBlockedInboxSeverity } from "@paperclipai/shared";
|
|
import { cn } from "../lib/utils";
|
|
import {
|
|
blockedReasonVariant,
|
|
blockedVariantLabel,
|
|
type BlockedReasonVariant,
|
|
} from "../lib/blockedInbox";
|
|
import type { IssueBlockedInboxReason } from "@paperclipai/shared";
|
|
|
|
interface BlockedReasonChipProps {
|
|
reason: IssueBlockedInboxReason;
|
|
severity: IssueBlockedInboxSeverity;
|
|
compact?: boolean;
|
|
className?: string;
|
|
}
|
|
|
|
type IconComponent = ComponentType<{ className?: string; "aria-hidden"?: boolean | "true" | "false" }>;
|
|
|
|
const VARIANT_STYLES: Record<BlockedReasonVariant, string> = {
|
|
needs_decision:
|
|
"border-violet-300/70 bg-violet-50 text-violet-800 dark:border-violet-500/30 dark:bg-violet-500/10 dark:text-violet-300",
|
|
recovery_required:
|
|
"border-cyan-300/70 bg-cyan-50 text-cyan-800 dark:border-cyan-500/30 dark:bg-cyan-500/10 dark:text-cyan-300",
|
|
stalled:
|
|
"border-amber-400/70 bg-amber-100 text-amber-900 dark:border-amber-500/40 dark:bg-amber-500/15 dark:text-amber-200",
|
|
needs_attention:
|
|
"border-amber-300/70 bg-amber-50 text-amber-800 dark:border-amber-500/40 dark:bg-amber-500/10 dark:text-amber-300",
|
|
external_wait:
|
|
"border-slate-300 bg-slate-50 text-slate-700 dark:border-slate-500/30 dark:bg-slate-500/15 dark:text-slate-300",
|
|
owner_paused:
|
|
"border-red-300/70 bg-red-50 text-red-800 dark:border-red-500/30 dark:bg-red-500/10 dark:text-red-300",
|
|
};
|
|
|
|
const VARIANT_ICONS: Record<BlockedReasonVariant, IconComponent> = {
|
|
needs_decision: Clock,
|
|
recovery_required: Wrench,
|
|
stalled: AlertTriangle,
|
|
needs_attention: AlertTriangle,
|
|
external_wait: User,
|
|
owner_paused: Pause,
|
|
};
|
|
|
|
const SEVERITY_DOT: Partial<Record<IssueBlockedInboxSeverity, string>> = {
|
|
critical: "bg-red-500",
|
|
high: "bg-orange-500",
|
|
};
|
|
|
|
export function BlockedReasonChip({
|
|
reason,
|
|
severity,
|
|
compact = false,
|
|
className,
|
|
}: BlockedReasonChipProps) {
|
|
const variant = blockedReasonVariant(reason);
|
|
const label = blockedVariantLabel(variant);
|
|
const Icon = VARIANT_ICONS[variant];
|
|
const dotClass = SEVERITY_DOT[severity];
|
|
return (
|
|
<span
|
|
data-testid="blocked-reason-chip"
|
|
data-variant={variant}
|
|
data-severity={severity}
|
|
aria-label={`Reason: ${label}, severity ${severity}`}
|
|
className={cn(
|
|
"inline-flex shrink-0 items-center gap-1 rounded-md border px-2 py-0.5 text-[10px] font-medium leading-tight sm:text-[11px]",
|
|
VARIANT_STYLES[variant],
|
|
className,
|
|
)}
|
|
>
|
|
{dotClass ? (
|
|
<span
|
|
aria-hidden="true"
|
|
className={cn("inline-block h-1.5 w-1.5 shrink-0 rounded-full", dotClass)}
|
|
/>
|
|
) : null}
|
|
{compact ? null : <Icon className="h-3 w-3 shrink-0" aria-hidden="true" />}
|
|
<span className="truncate">{label}</span>
|
|
</span>
|
|
);
|
|
}
|