forked from farhoodlabs/paperclip
a3de1d764d
## Thinking Path > - Paperclip is a control plane for autonomous AI companies, where adapters are the boundary between the board, agents, and execution runtimes. > - Local adapters currently expose a primary runtime configuration, but operators often need a cheaper model lane for routine or low-risk work. > - That cheap lane has to stay adapter-owned: runtime profile settings should not mutate the primary adapter config or bypass existing auth/secret mediation. > - Issue creation also needs an ergonomic way to request primary, cheap, or custom model behavior for a selected assignee. > - This pull request adds a first-class `cheap` model profile contract across adapter capabilities, heartbeat config resolution, agent configuration, and issue creation. > - The benefit is cheaper task execution can be configured and requested explicitly while preserving adapter boundaries, secret handling, and audit visibility. ## What Changed - Added adapter model-profile capability metadata and a `cheap` profile contract for supported local adapters. - Applied `runtimeConfig.modelProfiles.cheap.adapterConfig` during heartbeat config resolution, including requested/applied/fallback run metadata. - Added agent configuration UI for cheap model profile settings without writing those settings into primary `adapterConfig`. - Added New Issue assignee model lane controls for Primary / Cheap / Custom and request payload handling. - Added run ledger profile badges and Storybook stories for the new cheap-lane UI states. - Added tests for validators, heartbeat model profile application, permission/secret mediation, UI payload helpers, and run ledger rendering. - Added committed UI verification screenshots under `docs/pr-screenshots/pap-2837/`. - Addressed Greptile review feedback around cheap-profile defaults, shared profile types, and fallback test data. ## Verification Local: - `pnpm exec vitest run packages/shared/src/validators/issue.test.ts server/src/__tests__/adapter-registry.test.ts server/src/__tests__/agent-permissions-routes.test.ts server/src/__tests__/heartbeat-model-profile.test.ts ui/src/components/IssueRunLedger.test.tsx ui/src/lib/agent-config-patch.test.ts ui/src/lib/issue-assignee-overrides.test.ts ui/src/lib/new-agent-runtime-config.test.ts` — passed, 8 files / 103 tests. - `pnpm exec vitest run ui/src/lib/new-agent-runtime-config.test.ts ui/src/components/IssueRunLedger.test.tsx` — passed after Greptile/rebase follow-up, 2 files / 17 tests. - `pnpm --filter @paperclipai/ui typecheck` — passed after Greptile/rebase follow-up. - `pnpm -r typecheck` — passed. - `pnpm build` — passed. - `pnpm test:run` — did not complete successfully in this local worktree: it stopped in pre-existing `@paperclipai/adapter-utils` sandbox/SSH fixture suites outside this PR diff. Failures were 5s local timeouts plus `git init -b` unsupported by this machine's Git 2.21.0. The branch-specific targeted suites above passed. - Branch was fetched/rebased onto `public-gh/master`; `git rev-list --left-right --count public-gh/master...HEAD` reports `0 9`. Remote PR checks on latest head `e30bf399146451c86cee98ed528d51d33fa5af5a`: - `policy` — passed. - `verify` — passed. - `e2e` — passed. - `Greptile Review` — passed, confidence score 5/5; Greptile review threads resolved. - `security/snyk (cryppadotta)` — passed. Screenshots: - [New issue cheap lane desktop](https://github.com/paperclipai/paperclip/blob/PAP-2837-plan-cheap-model-for-adapters-that-can-support-it/docs/pr-screenshots/pap-2837/newissue-cheap-desktop.png) - [New issue custom lane desktop](https://github.com/paperclipai/paperclip/blob/PAP-2837-plan-cheap-model-for-adapters-that-can-support-it/docs/pr-screenshots/pap-2837/newissue-custom-desktop.png) - [New issue unsupported adapter desktop](https://github.com/paperclipai/paperclip/blob/PAP-2837-plan-cheap-model-for-adapters-that-can-support-it/docs/pr-screenshots/pap-2837/newissue-unsupported-desktop.png) - [Run ledger model profile badges desktop](https://github.com/paperclipai/paperclip/blob/PAP-2837-plan-cheap-model-for-adapters-that-can-support-it/docs/pr-screenshots/pap-2837/runledger-profile-badges-desktop.png) - Mobile variants are also in `docs/pr-screenshots/pap-2837/`. ## Risks - Medium: heartbeat config mediation now merges runtime model profiles into adapter configs, so adapter secret normalization and host-command restrictions must keep covering nested config paths. - Medium: the UI adds another issue creation choice; unsupported adapters must keep hiding the cheap lane and preserve primary behavior. - Low migration risk: no database migration is included. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used OpenAI Codex coding agent using GPT-5-class reasoning with repo tool use and command execution. Exact served model/context window was not exposed by the runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [ ] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
119 lines
3.7 KiB
TypeScript
119 lines
3.7 KiB
TypeScript
import type { Agent } from "@paperclipai/shared";
|
|
|
|
export interface AgentModelProfileOverlay {
|
|
enabled?: boolean;
|
|
adapterConfig?: Record<string, unknown>;
|
|
/**
|
|
* Mark the cheap profile for clearing. When true, the patch removes
|
|
* `runtimeConfig.modelProfiles.cheap` instead of merging into it.
|
|
*/
|
|
cleared?: boolean;
|
|
}
|
|
|
|
export interface AgentConfigOverlay {
|
|
identity: Record<string, unknown>;
|
|
adapterType?: string;
|
|
adapterConfig: Record<string, unknown>;
|
|
heartbeat: Record<string, unknown>;
|
|
runtime: Record<string, unknown>;
|
|
modelProfiles?: { cheap?: AgentModelProfileOverlay };
|
|
}
|
|
|
|
const ADAPTER_AGNOSTIC_KEYS = [
|
|
"env",
|
|
"promptTemplate",
|
|
"instructionsFilePath",
|
|
"cwd",
|
|
"timeoutSec",
|
|
"graceSec",
|
|
"bootstrapPromptTemplate",
|
|
] as const;
|
|
|
|
function omitUndefinedEntries(value: Record<string, unknown>) {
|
|
return Object.fromEntries(
|
|
Object.entries(value).filter(([, entryValue]) => entryValue !== undefined),
|
|
);
|
|
}
|
|
|
|
export function buildAgentUpdatePatch(agent: Agent, overlay: AgentConfigOverlay) {
|
|
const patch: Record<string, unknown> = {};
|
|
|
|
if (Object.keys(overlay.identity).length > 0) {
|
|
Object.assign(patch, overlay.identity);
|
|
}
|
|
|
|
if (overlay.adapterType !== undefined) {
|
|
patch.adapterType = overlay.adapterType;
|
|
}
|
|
|
|
if (overlay.adapterType !== undefined || Object.keys(overlay.adapterConfig).length > 0) {
|
|
const existing = (agent.adapterConfig ?? {}) as Record<string, unknown>;
|
|
const nextAdapterConfig =
|
|
overlay.adapterType !== undefined
|
|
? {
|
|
...Object.fromEntries(
|
|
ADAPTER_AGNOSTIC_KEYS
|
|
.filter((key) => existing[key] !== undefined)
|
|
.map((key) => [key, existing[key]]),
|
|
),
|
|
...overlay.adapterConfig,
|
|
}
|
|
: {
|
|
...existing,
|
|
...overlay.adapterConfig,
|
|
};
|
|
|
|
patch.adapterConfig = omitUndefinedEntries(nextAdapterConfig);
|
|
patch.replaceAdapterConfig = true;
|
|
}
|
|
|
|
const cheapOverlay = overlay.modelProfiles?.cheap;
|
|
const hasModelProfileChange = cheapOverlay !== undefined;
|
|
|
|
if (Object.keys(overlay.heartbeat).length > 0 || hasModelProfileChange) {
|
|
const existingRc = (agent.runtimeConfig ?? {}) as Record<string, unknown>;
|
|
const nextRuntimeConfig: Record<string, unknown> = (patch.runtimeConfig as Record<string, unknown> | undefined)
|
|
?? { ...existingRc };
|
|
|
|
if (Object.keys(overlay.heartbeat).length > 0) {
|
|
const existingHb = (existingRc.heartbeat ?? {}) as Record<string, unknown>;
|
|
nextRuntimeConfig.heartbeat = { ...existingHb, ...overlay.heartbeat };
|
|
}
|
|
|
|
if (hasModelProfileChange) {
|
|
const existingProfiles = ((existingRc.modelProfiles ?? {}) as Record<string, unknown>);
|
|
const existingCheap = ((existingProfiles.cheap ?? {}) as Record<string, unknown>);
|
|
const nextProfiles = { ...existingProfiles };
|
|
|
|
if (cheapOverlay?.cleared) {
|
|
delete nextProfiles.cheap;
|
|
} else if (cheapOverlay) {
|
|
const mergedAdapterConfig = {
|
|
...((existingCheap.adapterConfig ?? {}) as Record<string, unknown>),
|
|
...(cheapOverlay.adapterConfig ?? {}),
|
|
};
|
|
const enabled = cheapOverlay.enabled ?? (existingCheap.enabled !== false);
|
|
nextProfiles.cheap = {
|
|
...existingCheap,
|
|
enabled,
|
|
adapterConfig: mergedAdapterConfig,
|
|
};
|
|
}
|
|
|
|
if (Object.keys(nextProfiles).length === 0) {
|
|
delete nextRuntimeConfig.modelProfiles;
|
|
} else {
|
|
nextRuntimeConfig.modelProfiles = nextProfiles;
|
|
}
|
|
}
|
|
|
|
patch.runtimeConfig = nextRuntimeConfig;
|
|
}
|
|
|
|
if (Object.keys(overlay.runtime).length > 0) {
|
|
Object.assign(patch, overlay.runtime);
|
|
}
|
|
|
|
return patch;
|
|
}
|