forked from farhoodlabs/paperclip
a957394420
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies. > - Operators supervise that work through issues, comments, approvals, and the board UI. > - Some agent proposals need structured board/user decisions, not hidden markdown conventions or heavyweight governed approvals. > - Issue-thread interactions already provide a natural thread-native surface for proposed tasks and questions. > - This pull request extends that surface with request confirmations, richer interaction cards, and agent/plugin/MCP helpers. > - The benefit is that plan approvals and yes/no decisions become explicit, auditable, and resumable without losing the single-issue workflow. ## What Changed - Added persisted issue-thread interactions for suggested tasks, structured questions, and request confirmations. - Added board UI cards for interaction review, selection, question answers, and accept/reject confirmation flows. - Added MCP and plugin SDK helpers for creating interaction cards from agents/plugins. - Updated agent wake instructions, onboarding assets, Paperclip skill docs, and public docs to prefer structured confirmations for issue-scoped decisions. - Rebased the branch onto `public-gh/master` and renumbered branch migrations to `0063` and `0064`; the idempotency migration uses `ADD COLUMN IF NOT EXISTS` for old branch users. ## Verification - `git diff --check public-gh/master..HEAD` - `pnpm exec vitest run packages/adapter-utils/src/server-utils.test.ts packages/mcp-server/src/tools.test.ts packages/shared/src/issue-thread-interactions.test.ts ui/src/lib/issue-thread-interactions.test.ts ui/src/lib/issue-chat-messages.test.ts ui/src/components/IssueThreadInteractionCard.test.tsx ui/src/components/IssueChatThread.test.tsx server/src/__tests__/issue-thread-interaction-routes.test.ts server/src/__tests__/issue-thread-interactions-service.test.ts server/src/services/issue-thread-interactions.test.ts` -> 9 files / 79 tests passed - `pnpm -r typecheck` -> passed, including `packages/db` migration numbering check ## Risks - Medium: this adds a new issue-thread interaction model across db/shared/server/ui/plugin surfaces. - Migration risk is reduced by placing this branch after current master migrations (`0063`, `0064`) and making the idempotency column add idempotent for users who applied the old branch numbering. - UI interaction behavior is covered by component tests, but this PR does not include browser screenshots. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5-class coding agent runtime. Exact model ID and context window are not exposed in this Paperclip run; tool use and local shell/code execution were enabled. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
151 lines
4.2 KiB
TypeScript
151 lines
4.2 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import {
|
|
buildIssueThreadInteractionSummary,
|
|
buildSuggestedTaskTree,
|
|
collectSuggestedTaskClientKeys,
|
|
countSuggestedTaskNodes,
|
|
getQuestionAnswerLabels,
|
|
} from "./issue-thread-interactions";
|
|
|
|
describe("buildSuggestedTaskTree", () => {
|
|
it("preserves parent-child relationships from client keys", () => {
|
|
const roots = buildSuggestedTaskTree([
|
|
{
|
|
clientKey: "root",
|
|
title: "Root",
|
|
},
|
|
{
|
|
clientKey: "child",
|
|
parentClientKey: "root",
|
|
title: "Child",
|
|
},
|
|
{
|
|
clientKey: "grandchild",
|
|
parentClientKey: "child",
|
|
title: "Grandchild",
|
|
},
|
|
]);
|
|
|
|
expect(roots).toHaveLength(1);
|
|
expect(roots[0]?.task.clientKey).toBe("root");
|
|
expect(roots[0]?.children[0]?.task.clientKey).toBe("child");
|
|
expect(countSuggestedTaskNodes(roots[0]!)).toBe(3);
|
|
expect(collectSuggestedTaskClientKeys(roots[0]!)).toEqual(["root", "child", "grandchild"]);
|
|
});
|
|
});
|
|
|
|
describe("issue thread interaction helpers", () => {
|
|
it("summarizes task and question interactions", () => {
|
|
expect(buildIssueThreadInteractionSummary({
|
|
id: "interaction-1",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
kind: "suggest_tasks",
|
|
status: "pending",
|
|
continuationPolicy: "wake_assignee",
|
|
createdAt: "2026-04-06T12:00:00.000Z",
|
|
updatedAt: "2026-04-06T12:00:00.000Z",
|
|
payload: {
|
|
version: 1,
|
|
tasks: [
|
|
{ clientKey: "task-1", title: "One" },
|
|
{ clientKey: "task-2", title: "Two" },
|
|
],
|
|
},
|
|
})).toBe("Suggested 2 tasks");
|
|
|
|
expect(buildIssueThreadInteractionSummary({
|
|
id: "interaction-accepted",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
kind: "suggest_tasks",
|
|
status: "accepted",
|
|
continuationPolicy: "wake_assignee",
|
|
createdAt: "2026-04-06T12:00:00.000Z",
|
|
updatedAt: "2026-04-06T12:00:00.000Z",
|
|
payload: {
|
|
version: 1,
|
|
tasks: [
|
|
{ clientKey: "task-1", title: "One" },
|
|
{ clientKey: "task-2", title: "Two" },
|
|
],
|
|
},
|
|
result: {
|
|
version: 1,
|
|
createdTasks: [{ clientKey: "task-1", issueId: "child-1" }],
|
|
skippedClientKeys: ["task-2"],
|
|
},
|
|
})).toBe("Accepted 1 of 2 tasks");
|
|
|
|
expect(buildIssueThreadInteractionSummary({
|
|
id: "interaction-2",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
kind: "ask_user_questions",
|
|
status: "pending",
|
|
continuationPolicy: "wake_assignee",
|
|
createdAt: "2026-04-06T12:00:00.000Z",
|
|
updatedAt: "2026-04-06T12:00:00.000Z",
|
|
payload: {
|
|
version: 1,
|
|
questions: [
|
|
{
|
|
id: "question-1",
|
|
prompt: "Pick one",
|
|
selectionMode: "single",
|
|
options: [{ id: "option-1", label: "Option 1" }],
|
|
},
|
|
],
|
|
},
|
|
})).toBe("Asked 1 question");
|
|
|
|
expect(buildIssueThreadInteractionSummary({
|
|
id: "interaction-answered",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
kind: "ask_user_questions",
|
|
status: "answered",
|
|
continuationPolicy: "wake_assignee",
|
|
createdAt: "2026-04-06T12:00:00.000Z",
|
|
updatedAt: "2026-04-06T12:00:00.000Z",
|
|
payload: {
|
|
version: 1,
|
|
questions: [
|
|
{
|
|
id: "question-1",
|
|
prompt: "Pick one",
|
|
selectionMode: "single",
|
|
options: [{ id: "option-1", label: "Option 1" }],
|
|
},
|
|
],
|
|
},
|
|
result: {
|
|
version: 1,
|
|
answers: [{ questionId: "question-1", optionIds: ["option-1"] }],
|
|
},
|
|
})).toBe("Answered 1 question");
|
|
});
|
|
|
|
it("maps stored option ids back to labels for answered summaries", () => {
|
|
const labels = getQuestionAnswerLabels({
|
|
question: {
|
|
id: "question-1",
|
|
prompt: "Pick options",
|
|
selectionMode: "multi",
|
|
options: [
|
|
{ id: "option-1", label: "Option 1" },
|
|
{ id: "option-2", label: "Option 2" },
|
|
],
|
|
},
|
|
answers: [
|
|
{
|
|
questionId: "question-1",
|
|
optionIds: ["option-2", "option-1"],
|
|
},
|
|
],
|
|
});
|
|
|
|
expect(labels).toEqual(["Option 2", "Option 1"]);
|
|
});
|
|
});
|