forked from farhoodlabs/paperclip
Dotta
3fa5d25de1
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies > - Heartbeat runs are the control-plane record of what agents did, why they woke up, and what operators should see next > - Run lists, stranded issue comments, and live log polling all depend on compact but accurate heartbeat summaries > - The current branch had a focused backend slice that improves how run result JSON is summarized, how stale process recovery comments are written, and how live log polling resolves the active run > - This pull request isolates that heartbeat/runtime reliability work from the unrelated UI and dev-tooling changes > - The benefit is more reliable issue context and cheaper run lookups without dragging unrelated board UI changes into the same review ## What Changed - Include the latest run failure in stranded issue comments during orphaned process recovery. - Bound heartbeat `result_json` payloads for list responses while preserving the raw stored payloads. - Narrow heartbeat log endpoint lookups so issue polling resolves the relevant active run with less unnecessary scanning. - Add focused tests for heartbeat list summaries, live run polling, orphaned process recovery, and the run context/result summary helpers. ## Verification - `pnpm vitest run server/src/__tests__/heartbeat-context-summary.test.ts server/src/__tests__/heartbeat-list.test.ts server/src/__tests__/agent-live-run-routes.test.ts server/src/__tests__/heartbeat-process-recovery.test.ts` ## Risks - The main risk is accidentally hiding a field that some client still expects from summarized `result_json`, or over-constraining the live log lookup path for edge-case run routing. - Recovery comments now surface the latest failure more aggressively, so wording changes may affect downstream expectations if anyone parses those comments too strictly. ## Model Used - OpenAI Codex, GPT-5-based coding agent in the Codex CLI environment. Exact backend model deployment ID was not exposed in-session. Tool-assisted editing and shell execution were used. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge
84 lines
2.2 KiB
TypeScript
84 lines
2.2 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import {
|
|
summarizeHeartbeatRunContextSnapshot,
|
|
summarizeHeartbeatRunListResultJson,
|
|
} from "../services/heartbeat.js";
|
|
|
|
describe("summarizeHeartbeatRunContextSnapshot", () => {
|
|
it("keeps only the small retry/linking fields needed by the client", () => {
|
|
const summarized = summarizeHeartbeatRunContextSnapshot({
|
|
issueId: "issue-1",
|
|
taskId: "task-1",
|
|
taskKey: "PAP-1",
|
|
commentId: "comment-1",
|
|
wakeCommentId: "comment-2",
|
|
wakeReason: "retry_failed_run",
|
|
wakeSource: "on_demand",
|
|
wakeTriggerDetail: "manual",
|
|
paperclipWake: {
|
|
comments: [
|
|
{
|
|
body: "x".repeat(50_000),
|
|
},
|
|
],
|
|
},
|
|
executionStage: {
|
|
summary: "large nested object that should not be sent back in run lists",
|
|
},
|
|
});
|
|
|
|
expect(summarized).toEqual({
|
|
issueId: "issue-1",
|
|
taskId: "task-1",
|
|
taskKey: "PAP-1",
|
|
commentId: "comment-1",
|
|
wakeCommentId: "comment-2",
|
|
wakeReason: "retry_failed_run",
|
|
wakeSource: "on_demand",
|
|
wakeTriggerDetail: "manual",
|
|
});
|
|
});
|
|
|
|
it("returns null when no allowed fields are present", () => {
|
|
expect(
|
|
summarizeHeartbeatRunContextSnapshot({
|
|
paperclipWake: { comments: [{ body: "hello" }] },
|
|
}),
|
|
).toBeNull();
|
|
});
|
|
});
|
|
|
|
describe("summarizeHeartbeatRunListResultJson", () => {
|
|
it("keeps only summary fields and parses numeric cost aliases", () => {
|
|
expect(
|
|
summarizeHeartbeatRunListResultJson({
|
|
summary: "Completed the task",
|
|
result: "Updated three files",
|
|
message: "",
|
|
error: null,
|
|
totalCostUsd: "1.25",
|
|
costUsd: "0.75",
|
|
costUsdCamel: "0.5",
|
|
}),
|
|
).toEqual({
|
|
summary: "Completed the task",
|
|
result: "Updated three files",
|
|
total_cost_usd: 1.25,
|
|
cost_usd: 0.75,
|
|
costUsd: 0.5,
|
|
});
|
|
});
|
|
|
|
it("returns null when projected fields are empty", () => {
|
|
expect(
|
|
summarizeHeartbeatRunListResultJson({
|
|
summary: "",
|
|
result: null,
|
|
message: undefined,
|
|
error: " ",
|
|
totalCostUsd: "abc",
|
|
}),
|
|
).toBeNull();
|
|
});
|
|
});
|