forked from farhoodlabs/paperclip
6b7f6ce4b8
## Thinking Path > - Paperclip orchestrates AI agents through a company-scoped control plane. > - The affected surface is the board UI for issue threads, issue lists, routines, dialogs, navigation, and issue review indicators. > - Closed PR #4692 bundled backend, schema, docs, workflow, and UI/QoL work into one oversized change set. > - Greptile could not keep reviewing that broad PR because it exceeded the 100-file review limit and mixed unrelated concerns. > - This pull request extracts the UI/QoL slice into a fresh branch under the review limit while leaving workflow and lockfile churn out. > - The benefit is a focused review path for the board UI performance and workflow improvements without reopening the oversized PR. ## What Changed - Added long issue-thread virtualization, scroll-container binding, anchor preservation, latest-comment jump targeting, and related regression/perf fixtures. - Improved issue list scalability with scroll-based loading, server offset parameters, and pagination-focused UI tests. - Reduced new issue dialog typing churn and split dialog action subscriptions so broad layout/nav surfaces avoid unnecessary renders. - Added routine variables help and routine description mention options for users, agents, and projects. - Added productivity review badge/link UI and fixed the badge to use Paperclip's company-prefixed router link. - Kept the split PR below Greptile's review limit and excluded `.github/workflows/pr.yml` and `pnpm-lock.yaml`. ## Verification - `pnpm install --no-frozen-lockfile` in the clean worktree to install `@tanstack/react-virtual` locally without committing lockfile churn. - `pnpm --filter @paperclipai/ui exec vitest run --config vitest.config.ts src/components/IssueChatThread.test.tsx src/components/IssuesList.test.tsx src/components/NewIssueDialog.test.tsx src/pages/Routines.test.tsx src/pages/Issues.test.tsx` passed: 5 files, 83 tests. - `pnpm --filter @paperclipai/ui typecheck` passed. - `git diff --check origin/master..HEAD` passed. - Split-scope checks: 53 changed files; no `.github/workflows/pr.yml`; no `pnpm-lock.yaml`. - Screenshots were not captured in this heartbeat; the changes are primarily virtualization, routing, pagination, and editor behavior covered by focused regression tests. ## Risks - Moderate UI risk because issue-thread virtualization changes scroll behavior on long conversations; regression tests cover anchor jumps, latest-comment targeting, row metadata, and short-thread fallback. - Moderate integration risk because the issue-list offset parameter and productivity review field depend on matching API behavior. - Dependency risk: the UI package adds `@tanstack/react-virtual` while repository policy keeps `pnpm-lock.yaml` out of PRs, so CI must resolve dependency changes through the repo's normal lockfile policy. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5 coding agent, tool-enabled local repository and GitHub workflow. Exact runtime context window was not exposed by the harness. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
126 lines
4.1 KiB
TypeScript
126 lines
4.1 KiB
TypeScript
import { useMemo } from "react";
|
|
import { NavLink, useLocation } from "@/lib/router";
|
|
import {
|
|
House,
|
|
CircleDot,
|
|
SquarePen,
|
|
Users,
|
|
Inbox,
|
|
} from "lucide-react";
|
|
import { useCompany } from "../context/CompanyContext";
|
|
import { useDialogActions } from "../context/DialogContext";
|
|
import { SIDEBAR_SCROLL_RESET_STATE } from "../lib/navigation-scroll";
|
|
import { cn } from "../lib/utils";
|
|
import { useInboxBadge } from "../hooks/useInboxBadge";
|
|
|
|
interface MobileBottomNavProps {
|
|
visible: boolean;
|
|
}
|
|
|
|
interface MobileNavLinkItem {
|
|
type: "link";
|
|
to: string;
|
|
label: string;
|
|
icon: typeof House;
|
|
badge?: number;
|
|
}
|
|
|
|
interface MobileNavActionItem {
|
|
type: "action";
|
|
label: string;
|
|
icon: typeof SquarePen;
|
|
onClick: () => void;
|
|
}
|
|
|
|
type MobileNavItem = MobileNavLinkItem | MobileNavActionItem;
|
|
|
|
export function MobileBottomNav({ visible }: MobileBottomNavProps) {
|
|
const location = useLocation();
|
|
const { selectedCompanyId } = useCompany();
|
|
const { openNewIssue } = useDialogActions();
|
|
const inboxBadge = useInboxBadge(selectedCompanyId);
|
|
|
|
const items = useMemo<MobileNavItem[]>(
|
|
() => [
|
|
{ type: "link", to: "/dashboard", label: "Home", icon: House },
|
|
{ type: "link", to: "/issues", label: "Issues", icon: CircleDot },
|
|
{ type: "action", label: "Create", icon: SquarePen, onClick: () => openNewIssue() },
|
|
{ type: "link", to: "/agents/all", label: "Agents", icon: Users },
|
|
{
|
|
type: "link",
|
|
to: "/inbox",
|
|
label: "Inbox",
|
|
icon: Inbox,
|
|
badge: inboxBadge.inbox,
|
|
},
|
|
],
|
|
[openNewIssue, inboxBadge.inbox],
|
|
);
|
|
|
|
return (
|
|
<nav
|
|
className={cn(
|
|
"fixed bottom-0 left-0 right-0 z-30 border-t border-border bg-background/95 backdrop-blur supports-[backdrop-filter]:bg-background/85 transition-transform duration-200 ease-out md:hidden pb-[env(safe-area-inset-bottom)]",
|
|
visible ? "translate-y-0" : "translate-y-full",
|
|
)}
|
|
aria-label="Mobile navigation"
|
|
>
|
|
<div className="grid h-16 grid-cols-5 px-1">
|
|
{items.map((item) => {
|
|
if (item.type === "action") {
|
|
const Icon = item.icon;
|
|
const active = /\/issues\/new(?:\/|$)/.test(location.pathname);
|
|
return (
|
|
<button
|
|
key={item.label}
|
|
type="button"
|
|
onClick={item.onClick}
|
|
className={cn(
|
|
"relative flex min-w-0 flex-col items-center justify-center gap-1 rounded-md text-[10px] font-medium transition-colors",
|
|
active
|
|
? "text-foreground"
|
|
: "text-muted-foreground hover:text-foreground",
|
|
)}
|
|
>
|
|
<Icon className="h-[18px] w-[18px]" />
|
|
<span className="truncate">{item.label}</span>
|
|
</button>
|
|
);
|
|
}
|
|
|
|
const Icon = item.icon;
|
|
return (
|
|
<NavLink
|
|
key={item.label}
|
|
to={item.to}
|
|
state={SIDEBAR_SCROLL_RESET_STATE}
|
|
className={({ isActive }) =>
|
|
cn(
|
|
"relative flex min-w-0 flex-col items-center justify-center gap-1 rounded-md text-[10px] font-medium transition-colors",
|
|
isActive
|
|
? "text-foreground"
|
|
: "text-muted-foreground hover:text-foreground",
|
|
)
|
|
}
|
|
>
|
|
{({ isActive }) => (
|
|
<>
|
|
<span className="relative">
|
|
<Icon className={cn("h-[18px] w-[18px]", isActive && "stroke-[2.3]")} />
|
|
{item.badge != null && item.badge > 0 && (
|
|
<span className="absolute -right-2 -top-2 rounded-full bg-primary px-1.5 py-0.5 text-[10px] leading-none text-primary-foreground">
|
|
{item.badge > 99 ? "99+" : item.badge}
|
|
</span>
|
|
)}
|
|
</span>
|
|
<span className="truncate">{item.label}</span>
|
|
</>
|
|
)}
|
|
</NavLink>
|
|
);
|
|
})}
|
|
</div>
|
|
</nav>
|
|
);
|
|
}
|