forked from farhoodlabs/paperclip
758a5538c5
pino-http was logging 500s at INFO level with a generic "failed with status code 500" message. Now 500s log at ERROR level and include the actual error (message, stack, name) via res.locals handoff from the error handler. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
41 lines
1.1 KiB
TypeScript
41 lines
1.1 KiB
TypeScript
import type { Request, Response, NextFunction } from "express";
|
|
import { ZodError } from "zod";
|
|
import { logger } from "./logger.js";
|
|
import { HttpError } from "../errors.js";
|
|
|
|
export function errorHandler(
|
|
err: unknown,
|
|
req: Request,
|
|
res: Response,
|
|
_next: NextFunction,
|
|
) {
|
|
if (err instanceof HttpError) {
|
|
res.status(err.status).json({
|
|
error: err.message,
|
|
...(err.details ? { details: err.details } : {}),
|
|
});
|
|
return;
|
|
}
|
|
|
|
if (err instanceof ZodError) {
|
|
res.status(400).json({ error: "Validation error", details: err.errors });
|
|
return;
|
|
}
|
|
|
|
const errObj = err instanceof Error
|
|
? { message: err.message, stack: err.stack, name: err.name }
|
|
: { raw: err };
|
|
|
|
// Attach the real error so pino-http can include it in its response log
|
|
res.locals.serverError = errObj;
|
|
|
|
logger.error(
|
|
{ err: errObj, method: req.method, url: req.originalUrl },
|
|
"Unhandled error: %s %s — %s",
|
|
req.method,
|
|
req.originalUrl,
|
|
err instanceof Error ? err.message : String(err),
|
|
);
|
|
res.status(500).json({ error: "Internal server error" });
|
|
}
|