forked from farhoodlabs/paperclip
d734bd43d1
## Thinking Path > - Paperclip is the control plane for autonomous AI companies, so agent work needs visible ownership, recovery, and operator controls. > - This local branch had accumulated several related control-plane reliability and operator-experience fixes across recovery actions, watchdog folding, model-profile defaults, mentions, markdown editing, plugin launchers, and small UI polish. > - The branch needed to be converted into a PR against the current `origin/master` without losing dirty work or including lockfile/workflow churn. > - The safest standalone shape is a single rollup PR because the recovery/server/UI files overlap heavily across the local commits and splitting would create avoidable conflicts. > - This pull request replays the local branch onto latest `origin/master`, preserves the uncommitted work as logical commits, and adds a Zod 4 validator compatibility fix found during verification. > - The benefit is that the May 17 local branch can be reviewed and merged as one coherent, conflict-free branch under the 100-file Greptile limit. ## What Changed - Rebased the local May 17 branch work onto current `origin/master` in a dedicated worktree. - Preserved and committed previously dirty changes for recovery retry handling, plugin/sidebar launcher polish, and `.herenow` ignores. - Added recovery-action behavior for returning source issues to `todo` when retrying source-scoped recovery. - Included the existing local recovery/liveness/watchdog fold, Codex cheap-profile, markdown/mention, duplicate-agent, and UI polish commits from the branch. - Normalized shared validator `z.record(...)` schemas to explicit string-key records for Zod 4 compatibility. - Confirmed the PR has no `pnpm-lock.yaml` or `.github/workflows/*` changes and stays below the 100-file Greptile limit. ## Verification - `pnpm install --frozen-lockfile --ignore-scripts` - `npm run install` in `node_modules/.pnpm/sqlite3@5.1.7/node_modules/sqlite3` to build the local native sqlite3 binding after installing with scripts disabled - `pnpm exec vitest run packages/shared/src/validators/issue.test.ts packages/shared/src/project-mentions.test.ts packages/adapter-utils/src/server-utils.test.ts server/src/__tests__/heartbeat-model-profile.test.ts server/src/__tests__/issue-recovery-actions.test.ts server/src/__tests__/issue-agent-mutation-ownership-routes.test.ts server/src/__tests__/heartbeat-active-run-output-watchdog.test.ts server/src/__tests__/plugin-local-folders.test.ts ui/src/components/IssueRecoveryActionCard.test.tsx ui/src/components/Sidebar.test.tsx ui/src/components/SidebarAccountMenu.test.tsx ui/src/components/IssueProperties.test.tsx ui/src/components/MarkdownEditor.test.tsx ui/src/components/MarkdownBody.test.tsx ui/src/lib/duplicate-agent-payload.test.ts ui/src/pages/Routines.test.tsx` - First pass: 13 files passed with 201 passing tests; 3 server files failed before sqlite3 native binding was built. - After rebuilding sqlite3: `server/src/__tests__/heartbeat-model-profile.test.ts`, `server/src/__tests__/issue-recovery-actions.test.ts`, and `server/src/__tests__/heartbeat-active-run-output-watchdog.test.ts` passed/loaded; embedded Postgres tests were skipped by the local host guard. - `pnpm --filter @paperclipai/shared typecheck` - `pnpm --filter @paperclipai/adapter-utils typecheck` - `pnpm --filter @paperclipai/server typecheck` - `pnpm --filter @paperclipai/ui typecheck` ## Risks - Medium risk: this is a broad rollup PR across recovery semantics, server tests, shared validators, and UI surfaces. - Some embedded Postgres tests skipped locally due the host guard, so CI should provide the stronger database-backed signal. - UI changes were covered by component tests, but no browser screenshot was captured in this PR creation pass. - This branch may overlap with existing recovery/liveness PR work; merge this PR independently or restack/close overlapping branches rather than merging duplicate implementations together. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5-based coding agent, tool-enabled local repository and GitHub workflow, medium reasoning effort. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
273 lines
7.9 KiB
TypeScript
273 lines
7.9 KiB
TypeScript
export const PROJECT_MENTION_SCHEME = "project://";
|
|
export const AGENT_MENTION_SCHEME = "agent://";
|
|
export const USER_MENTION_SCHEME = "user://";
|
|
export const SKILL_MENTION_SCHEME = "skill://";
|
|
export const ROUTINE_MENTION_SCHEME = "routine://";
|
|
|
|
const HEX_COLOR_RE = /^[0-9a-f]{6}$/i;
|
|
const HEX_COLOR_SHORT_RE = /^[0-9a-f]{3}$/i;
|
|
const HEX_COLOR_WITH_HASH_RE = /^#[0-9a-f]{6}$/i;
|
|
const HEX_COLOR_SHORT_WITH_HASH_RE = /^#[0-9a-f]{3}$/i;
|
|
const PROJECT_MENTION_LINK_RE = /\[[^\]]*]\((project:\/\/[^)\s]+)\)/gi;
|
|
const AGENT_MENTION_LINK_RE = /\[[^\]]*]\((agent:\/\/[^)\s]+)\)/gi;
|
|
const USER_MENTION_LINK_RE = /\[[^\]]*]\((user:\/\/[^)\s]+)\)/gi;
|
|
const SKILL_MENTION_LINK_RE = /\[[^\]]*]\((skill:\/\/[^)\s]+)\)/gi;
|
|
const ROUTINE_MENTION_LINK_RE = /\[[^\]]*]\((routine:\/\/[^)\s]+)\)/gi;
|
|
const AGENT_ICON_NAME_RE = /^[a-z0-9-]+$/i;
|
|
const SKILL_SLUG_RE = /^[a-z0-9][a-z0-9-]*$/i;
|
|
|
|
export interface ParsedProjectMention {
|
|
projectId: string;
|
|
color: string | null;
|
|
}
|
|
|
|
export interface ParsedAgentMention {
|
|
agentId: string;
|
|
icon: string | null;
|
|
}
|
|
|
|
export interface ParsedUserMention {
|
|
userId: string;
|
|
}
|
|
|
|
export interface ParsedSkillMention {
|
|
skillId: string;
|
|
slug: string | null;
|
|
}
|
|
|
|
export interface ParsedRoutineMention {
|
|
routineId: string;
|
|
}
|
|
|
|
function normalizeHexColor(input: string | null | undefined): string | null {
|
|
if (!input) return null;
|
|
const trimmed = input.trim();
|
|
if (!trimmed) return null;
|
|
|
|
if (HEX_COLOR_WITH_HASH_RE.test(trimmed)) {
|
|
return trimmed.toLowerCase();
|
|
}
|
|
if (HEX_COLOR_RE.test(trimmed)) {
|
|
return `#${trimmed.toLowerCase()}`;
|
|
}
|
|
if (HEX_COLOR_SHORT_WITH_HASH_RE.test(trimmed)) {
|
|
const raw = trimmed.slice(1).toLowerCase();
|
|
return `#${raw[0]}${raw[0]}${raw[1]}${raw[1]}${raw[2]}${raw[2]}`;
|
|
}
|
|
if (HEX_COLOR_SHORT_RE.test(trimmed)) {
|
|
const raw = trimmed.toLowerCase();
|
|
return `#${raw[0]}${raw[0]}${raw[1]}${raw[1]}${raw[2]}${raw[2]}`;
|
|
}
|
|
return null;
|
|
}
|
|
|
|
export function buildProjectMentionHref(projectId: string, color?: string | null): string {
|
|
const trimmedProjectId = projectId.trim();
|
|
const normalizedColor = normalizeHexColor(color ?? null);
|
|
if (!normalizedColor) {
|
|
return `${PROJECT_MENTION_SCHEME}${trimmedProjectId}`;
|
|
}
|
|
return `${PROJECT_MENTION_SCHEME}${trimmedProjectId}?c=${encodeURIComponent(normalizedColor.slice(1))}`;
|
|
}
|
|
|
|
export function parseProjectMentionHref(href: string): ParsedProjectMention | null {
|
|
if (!href.startsWith(PROJECT_MENTION_SCHEME)) return null;
|
|
|
|
let url: URL;
|
|
try {
|
|
url = new URL(href);
|
|
} catch {
|
|
return null;
|
|
}
|
|
|
|
if (url.protocol !== "project:") return null;
|
|
|
|
const projectId = `${url.hostname}${url.pathname}`.replace(/^\/+/, "").trim();
|
|
if (!projectId) return null;
|
|
|
|
const color = normalizeHexColor(url.searchParams.get("c") ?? url.searchParams.get("color"));
|
|
|
|
return {
|
|
projectId,
|
|
color,
|
|
};
|
|
}
|
|
|
|
export function buildAgentMentionHref(agentId: string, icon?: string | null): string {
|
|
const trimmedAgentId = agentId.trim();
|
|
const normalizedIcon = normalizeAgentIcon(icon ?? null);
|
|
if (!normalizedIcon) {
|
|
return `${AGENT_MENTION_SCHEME}${trimmedAgentId}`;
|
|
}
|
|
return `${AGENT_MENTION_SCHEME}${trimmedAgentId}?i=${encodeURIComponent(normalizedIcon)}`;
|
|
}
|
|
|
|
export function parseAgentMentionHref(href: string): ParsedAgentMention | null {
|
|
if (!href.startsWith(AGENT_MENTION_SCHEME)) return null;
|
|
|
|
let url: URL;
|
|
try {
|
|
url = new URL(href);
|
|
} catch {
|
|
return null;
|
|
}
|
|
|
|
if (url.protocol !== "agent:") return null;
|
|
|
|
const agentId = `${url.hostname}${url.pathname}`.replace(/^\/+/, "").trim();
|
|
if (!agentId) return null;
|
|
|
|
return {
|
|
agentId,
|
|
icon: normalizeAgentIcon(url.searchParams.get("i") ?? url.searchParams.get("icon")),
|
|
};
|
|
}
|
|
|
|
export function buildUserMentionHref(userId: string): string {
|
|
return `${USER_MENTION_SCHEME}${userId.trim()}`;
|
|
}
|
|
|
|
export function parseUserMentionHref(href: string): ParsedUserMention | null {
|
|
if (!href.startsWith(USER_MENTION_SCHEME)) return null;
|
|
|
|
let url: URL;
|
|
try {
|
|
url = new URL(href);
|
|
} catch {
|
|
return null;
|
|
}
|
|
|
|
if (url.protocol !== "user:") return null;
|
|
|
|
const userId = `${url.hostname}${url.pathname}`.replace(/^\/+/, "").trim();
|
|
if (!userId) return null;
|
|
|
|
return { userId };
|
|
}
|
|
|
|
export function buildSkillMentionHref(skillId: string, slug?: string | null): string {
|
|
const trimmedSkillId = skillId.trim();
|
|
const normalizedSlug = normalizeSkillSlug(slug ?? null);
|
|
if (!normalizedSlug) {
|
|
return `${SKILL_MENTION_SCHEME}${trimmedSkillId}`;
|
|
}
|
|
return `${SKILL_MENTION_SCHEME}${trimmedSkillId}?s=${encodeURIComponent(normalizedSlug)}`;
|
|
}
|
|
|
|
export function parseSkillMentionHref(href: string): ParsedSkillMention | null {
|
|
if (!href.startsWith(SKILL_MENTION_SCHEME)) return null;
|
|
|
|
let url: URL;
|
|
try {
|
|
url = new URL(href);
|
|
} catch {
|
|
return null;
|
|
}
|
|
|
|
if (url.protocol !== "skill:") return null;
|
|
|
|
const skillId = `${url.hostname}${url.pathname}`.replace(/^\/+/, "").trim();
|
|
if (!skillId) return null;
|
|
|
|
return {
|
|
skillId,
|
|
slug: normalizeSkillSlug(url.searchParams.get("s") ?? url.searchParams.get("slug")),
|
|
};
|
|
}
|
|
|
|
export function buildRoutineMentionHref(routineId: string): string {
|
|
return `${ROUTINE_MENTION_SCHEME}${routineId.trim()}`;
|
|
}
|
|
|
|
export function parseRoutineMentionHref(href: string): ParsedRoutineMention | null {
|
|
if (!href.startsWith(ROUTINE_MENTION_SCHEME)) return null;
|
|
|
|
let url: URL;
|
|
try {
|
|
url = new URL(href);
|
|
} catch {
|
|
return null;
|
|
}
|
|
|
|
if (url.protocol !== "routine:") return null;
|
|
|
|
const routineId = `${url.hostname}${url.pathname}`.replace(/^\/+/, "").trim();
|
|
if (!routineId) return null;
|
|
|
|
return { routineId };
|
|
}
|
|
|
|
export function extractProjectMentionIds(markdown: string): string[] {
|
|
if (!markdown) return [];
|
|
const ids = new Set<string>();
|
|
const re = new RegExp(PROJECT_MENTION_LINK_RE);
|
|
let match: RegExpExecArray | null;
|
|
while ((match = re.exec(markdown)) !== null) {
|
|
const parsed = parseProjectMentionHref(match[1]);
|
|
if (parsed) ids.add(parsed.projectId);
|
|
}
|
|
return [...ids];
|
|
}
|
|
|
|
export function extractAgentMentionIds(markdown: string): string[] {
|
|
if (!markdown) return [];
|
|
const ids = new Set<string>();
|
|
const re = new RegExp(AGENT_MENTION_LINK_RE);
|
|
let match: RegExpExecArray | null;
|
|
while ((match = re.exec(markdown)) !== null) {
|
|
const parsed = parseAgentMentionHref(match[1]);
|
|
if (parsed) ids.add(parsed.agentId);
|
|
}
|
|
return [...ids];
|
|
}
|
|
|
|
export function extractUserMentionIds(markdown: string): string[] {
|
|
if (!markdown) return [];
|
|
const ids = new Set<string>();
|
|
const re = new RegExp(USER_MENTION_LINK_RE);
|
|
let match: RegExpExecArray | null;
|
|
while ((match = re.exec(markdown)) !== null) {
|
|
const parsed = parseUserMentionHref(match[1]);
|
|
if (parsed) ids.add(parsed.userId);
|
|
}
|
|
return [...ids];
|
|
}
|
|
|
|
export function extractSkillMentionIds(markdown: string): string[] {
|
|
if (!markdown) return [];
|
|
const ids = new Set<string>();
|
|
const re = new RegExp(SKILL_MENTION_LINK_RE);
|
|
let match: RegExpExecArray | null;
|
|
while ((match = re.exec(markdown)) !== null) {
|
|
const parsed = parseSkillMentionHref(match[1]);
|
|
if (parsed) ids.add(parsed.skillId);
|
|
}
|
|
return [...ids];
|
|
}
|
|
|
|
export function extractRoutineMentionIds(markdown: string): string[] {
|
|
if (!markdown) return [];
|
|
const ids = new Set<string>();
|
|
const re = new RegExp(ROUTINE_MENTION_LINK_RE);
|
|
let match: RegExpExecArray | null;
|
|
while ((match = re.exec(markdown)) !== null) {
|
|
const parsed = parseRoutineMentionHref(match[1]);
|
|
if (parsed) ids.add(parsed.routineId);
|
|
}
|
|
return [...ids];
|
|
}
|
|
|
|
function normalizeAgentIcon(input: string | null | undefined): string | null {
|
|
if (!input) return null;
|
|
const trimmed = input.trim().toLowerCase();
|
|
if (!trimmed || !AGENT_ICON_NAME_RE.test(trimmed)) return null;
|
|
return trimmed;
|
|
}
|
|
|
|
function normalizeSkillSlug(input: string | null | undefined): string | null {
|
|
if (!input) return null;
|
|
const trimmed = input.trim().toLowerCase();
|
|
if (!trimmed || !SKILL_SLUG_RE.test(trimmed)) return null;
|
|
return trimmed;
|
|
}
|