forked from farhoodlabs/paperclip
d734bd43d1
## Thinking Path > - Paperclip is the control plane for autonomous AI companies, so agent work needs visible ownership, recovery, and operator controls. > - This local branch had accumulated several related control-plane reliability and operator-experience fixes across recovery actions, watchdog folding, model-profile defaults, mentions, markdown editing, plugin launchers, and small UI polish. > - The branch needed to be converted into a PR against the current `origin/master` without losing dirty work or including lockfile/workflow churn. > - The safest standalone shape is a single rollup PR because the recovery/server/UI files overlap heavily across the local commits and splitting would create avoidable conflicts. > - This pull request replays the local branch onto latest `origin/master`, preserves the uncommitted work as logical commits, and adds a Zod 4 validator compatibility fix found during verification. > - The benefit is that the May 17 local branch can be reviewed and merged as one coherent, conflict-free branch under the 100-file Greptile limit. ## What Changed - Rebased the local May 17 branch work onto current `origin/master` in a dedicated worktree. - Preserved and committed previously dirty changes for recovery retry handling, plugin/sidebar launcher polish, and `.herenow` ignores. - Added recovery-action behavior for returning source issues to `todo` when retrying source-scoped recovery. - Included the existing local recovery/liveness/watchdog fold, Codex cheap-profile, markdown/mention, duplicate-agent, and UI polish commits from the branch. - Normalized shared validator `z.record(...)` schemas to explicit string-key records for Zod 4 compatibility. - Confirmed the PR has no `pnpm-lock.yaml` or `.github/workflows/*` changes and stays below the 100-file Greptile limit. ## Verification - `pnpm install --frozen-lockfile --ignore-scripts` - `npm run install` in `node_modules/.pnpm/sqlite3@5.1.7/node_modules/sqlite3` to build the local native sqlite3 binding after installing with scripts disabled - `pnpm exec vitest run packages/shared/src/validators/issue.test.ts packages/shared/src/project-mentions.test.ts packages/adapter-utils/src/server-utils.test.ts server/src/__tests__/heartbeat-model-profile.test.ts server/src/__tests__/issue-recovery-actions.test.ts server/src/__tests__/issue-agent-mutation-ownership-routes.test.ts server/src/__tests__/heartbeat-active-run-output-watchdog.test.ts server/src/__tests__/plugin-local-folders.test.ts ui/src/components/IssueRecoveryActionCard.test.tsx ui/src/components/Sidebar.test.tsx ui/src/components/SidebarAccountMenu.test.tsx ui/src/components/IssueProperties.test.tsx ui/src/components/MarkdownEditor.test.tsx ui/src/components/MarkdownBody.test.tsx ui/src/lib/duplicate-agent-payload.test.ts ui/src/pages/Routines.test.tsx` - First pass: 13 files passed with 201 passing tests; 3 server files failed before sqlite3 native binding was built. - After rebuilding sqlite3: `server/src/__tests__/heartbeat-model-profile.test.ts`, `server/src/__tests__/issue-recovery-actions.test.ts`, and `server/src/__tests__/heartbeat-active-run-output-watchdog.test.ts` passed/loaded; embedded Postgres tests were skipped by the local host guard. - `pnpm --filter @paperclipai/shared typecheck` - `pnpm --filter @paperclipai/adapter-utils typecheck` - `pnpm --filter @paperclipai/server typecheck` - `pnpm --filter @paperclipai/ui typecheck` ## Risks - Medium risk: this is a broad rollup PR across recovery semantics, server tests, shared validators, and UI surfaces. - Some embedded Postgres tests skipped locally due the host guard, so CI should provide the stronger database-backed signal. - UI changes were covered by component tests, but no browser screenshot was captured in this PR creation pass. - This branch may overlap with existing recovery/liveness PR work; merge this PR independently or restack/close overlapping branches rather than merging duplicate implementations together. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5-based coding agent, tool-enabled local repository and GitHub workflow, medium reasoning effort. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
178 lines
6.7 KiB
TypeScript
178 lines
6.7 KiB
TypeScript
import { Sparkles } from "lucide-react";
|
|
import { Link } from "@/lib/router";
|
|
import { cn, relativeTime } from "@/lib/utils";
|
|
import {
|
|
type SourceResolvedWatchdogFold,
|
|
formatCleanupOutcome,
|
|
formatSilenceAgeMs,
|
|
shortenEvidenceId,
|
|
} from "@/lib/source-resolved-watchdog-fold";
|
|
|
|
export interface SourceResolvedFoldCalloutProps {
|
|
fold: SourceResolvedWatchdogFold;
|
|
/** Time the run was finalized — used for the "system audit · {when}" header chip. */
|
|
finalizedAt?: string | Date | null;
|
|
className?: string;
|
|
}
|
|
|
|
function isoOrLocaleString(value: string | null | undefined): string | null {
|
|
if (!value) return null;
|
|
const date = new Date(value);
|
|
if (Number.isNaN(date.getTime())) return value;
|
|
return date.toLocaleString();
|
|
}
|
|
|
|
function issueLink(id: string, identifier: string | null) {
|
|
return `/issues/${identifier ?? id}`;
|
|
}
|
|
|
|
function MetaRow({
|
|
label,
|
|
children,
|
|
}: {
|
|
label: string;
|
|
children: React.ReactNode;
|
|
}) {
|
|
return (
|
|
<div className="grid grid-cols-[10rem_1fr] gap-x-3 gap-y-0 py-1 text-xs sm:grid-cols-[12rem_1fr]">
|
|
<dt className="truncate text-[11px] font-medium uppercase tracking-[0.08em] text-emerald-900/70 dark:text-emerald-200/70">
|
|
{label}
|
|
</dt>
|
|
<dd className="min-w-0 break-words text-emerald-950 dark:text-emerald-100">{children}</dd>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
export function SourceResolvedFoldCallout({
|
|
fold,
|
|
finalizedAt,
|
|
className,
|
|
}: SourceResolvedFoldCalloutProps) {
|
|
const sourceLabel = fold.sourceIssueIdentifier ?? fold.sourceIssueId.slice(0, 8);
|
|
const evidenceShort = shortenEvidenceId(fold.sameRunEvidenceId);
|
|
const evidenceAt = isoOrLocaleString(fold.sameRunEvidenceAt);
|
|
const silenceAgeLabel = formatSilenceAgeMs(fold.silenceAgeMs);
|
|
const silenceStartedLabel = isoOrLocaleString(fold.silenceStartedAt);
|
|
const cleanupLabel = formatCleanupOutcome(fold.cleanup.outcome);
|
|
const finalizedRelative = finalizedAt ? relativeTime(finalizedAt) : null;
|
|
const evaluationLabel = fold.evaluationIssueIdentifier ?? fold.evaluationIssueId?.slice(0, 8);
|
|
|
|
return (
|
|
<section
|
|
role="status"
|
|
aria-label="Source-resolved watchdog fold"
|
|
data-source-resolved-fold
|
|
className={cn(
|
|
"relative w-full overflow-hidden rounded-lg border text-sm shadow-[0_1px_0_rgba(15,23,42,0.02)]",
|
|
"border-emerald-300/70 bg-emerald-50/80 text-emerald-950",
|
|
"dark:border-emerald-500/40 dark:bg-emerald-500/10 dark:text-emerald-100",
|
|
className,
|
|
)}
|
|
>
|
|
<header className="flex items-start gap-3 px-3 py-2.5 sm:px-4">
|
|
<span
|
|
className={cn(
|
|
"mt-0.5 flex h-7 w-7 shrink-0 items-center justify-center rounded-md",
|
|
"bg-emerald-100 text-emerald-800 dark:bg-emerald-500/20 dark:text-emerald-200",
|
|
)}
|
|
aria-hidden
|
|
>
|
|
<Sparkles className="h-4 w-4 text-emerald-700 dark:text-emerald-300" />
|
|
</span>
|
|
<div className="min-w-0 flex-1">
|
|
<div className="flex flex-wrap items-center gap-x-2 gap-y-0.5 text-[11px] font-semibold uppercase tracking-[0.14em]">
|
|
<span className="text-emerald-900 dark:text-emerald-200">SOURCE-RESOLVED FOLD</span>
|
|
<span className="text-muted-foreground/60" aria-hidden>·</span>
|
|
<span className="font-medium normal-case tracking-normal text-muted-foreground">
|
|
system audit
|
|
</span>
|
|
{finalizedRelative ? (
|
|
<>
|
|
<span className="text-muted-foreground/60" aria-hidden>·</span>
|
|
<span className="font-medium normal-case tracking-normal text-muted-foreground">
|
|
{finalizedRelative}
|
|
</span>
|
|
</>
|
|
) : null}
|
|
</div>
|
|
<p className="mt-1 text-[14px] leading-6">
|
|
This run was folded as a source-resolved false positive.
|
|
</p>
|
|
</div>
|
|
</header>
|
|
<dl
|
|
className={cn(
|
|
"divide-y border-t bg-background/40 px-3 py-2 sm:px-4 dark:bg-background/20",
|
|
"border-emerald-300/60 dark:border-emerald-500/30",
|
|
"[&>*]:border-emerald-300/40 dark:[&>*]:border-emerald-500/20",
|
|
)}
|
|
>
|
|
<MetaRow label="Source issue">
|
|
<span className="inline-flex flex-wrap items-center gap-1.5">
|
|
<Link
|
|
to={issueLink(fold.sourceIssueId, fold.sourceIssueIdentifier)}
|
|
className="rounded-sm font-medium underline-offset-2 hover:underline"
|
|
>
|
|
{sourceLabel}
|
|
</Link>
|
|
<span className="rounded-md border border-emerald-300/60 bg-background/60 px-1.5 py-0.5 text-[11px] font-medium text-emerald-900 dark:border-emerald-500/30 dark:text-emerald-200">
|
|
{fold.sourceIssueStatus}
|
|
</span>
|
|
</span>
|
|
</MetaRow>
|
|
<MetaRow label="Same-run evidence">
|
|
<span className="inline-flex flex-wrap items-baseline gap-1.5">
|
|
<span className="rounded bg-background/70 px-1.5 py-0.5 font-mono text-[11px] text-emerald-900 dark:bg-background/40 dark:text-emerald-100">
|
|
{fold.sameRunEvidenceKind}
|
|
</span>
|
|
<code
|
|
className="rounded bg-background/70 px-1.5 py-0.5 font-mono text-[11px] text-emerald-900 dark:bg-background/40 dark:text-emerald-100"
|
|
title={fold.sameRunEvidenceId}
|
|
>
|
|
{evidenceShort}
|
|
</code>
|
|
{evidenceAt ? (
|
|
<span className="text-[11px] text-muted-foreground">at {evidenceAt}</span>
|
|
) : null}
|
|
</span>
|
|
</MetaRow>
|
|
<MetaRow label="Silence age before fold">
|
|
{silenceAgeLabel ? (
|
|
<span>
|
|
{silenceAgeLabel}
|
|
{silenceStartedLabel ? (
|
|
<span className="text-muted-foreground"> (silence started {silenceStartedLabel})</span>
|
|
) : null}
|
|
</span>
|
|
) : (
|
|
<span className="text-muted-foreground">unknown</span>
|
|
)}
|
|
</MetaRow>
|
|
<MetaRow label="Process cleanup">
|
|
<span
|
|
className="inline-flex flex-wrap items-baseline gap-1.5"
|
|
title={fold.cleanup.outcome}
|
|
>
|
|
<span>{cleanupLabel}</span>
|
|
{fold.cleanup.error ? (
|
|
<span className="text-muted-foreground">— {fold.cleanup.error}</span>
|
|
) : null}
|
|
</span>
|
|
</MetaRow>
|
|
{fold.evaluationIssueId ? (
|
|
<MetaRow label="Evaluation issue">
|
|
<Link
|
|
to={issueLink(fold.evaluationIssueId, fold.evaluationIssueIdentifier)}
|
|
className="rounded-sm font-medium underline-offset-2 hover:underline"
|
|
>
|
|
{evaluationLabel}
|
|
</Link>
|
|
</MetaRow>
|
|
) : null}
|
|
</dl>
|
|
</section>
|
|
);
|
|
}
|
|
|
|
export default SourceResolvedFoldCallout;
|