forked from farhoodlabs/paperclip
b24c6909e8
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies > - Each agent runs inside a sandbox environment so its CLI is isolated from the host > - Sandbox-backed adapter runs go through a small set of shared helpers — `ensureAdapterExecutionTargetCommandResolvable`, the sandbox callback bridge runner, and per-adapter `SANDBOX_INSTALL_COMMAND` strings > - When standing up new sandbox provider plugins, the existing helpers timed out, missed install fallbacks, or leaned on assumptions that only held for E2B > - Local adapters (`claude-local`, `codex-local`, `gemini-local`, `opencode-local`) needed slightly hardened probes so they could install themselves and validate inside *any* remote sandbox transport, not just E2B > - This pull request bundles those runtime fixes so future sandbox provider plugins inherit a working baseline > - The benefit is that adding a new sandbox provider plugin no longer requires touching adapter-utils or each local-adapter probe — the supporting infra is already correct ## What Changed - `packages/adapter-utils/src/execution-target.ts`: introduce `DEFAULT_REMOTE_SANDBOX_ADAPTER_TIMEOUT_SEC = 1800` and `resolveAdapterExecutionTargetTimeoutSec(...)`. Local and SSH adapters keep the historical "0 means no adapter timeout" behavior; sandbox-backed runs without an explicit `timeoutSec` get an explicit 30-minute default so remote installs and warm-up don't time out at the per-RPC default. Plumbed `timeoutSec` through `ensureAdapterExecutionTargetCommandResolvable` so install probes inside a sandbox honor adapter-level overrides instead of the bridge's 5-minute default. - `packages/adapters/opencode-local/src/index.ts`: switch `SANDBOX_INSTALL_COMMAND` from `npm install -g opencode-ai` to `curl -fsSL https://opencode.ai/install | bash`. The npm package reifies four large prebuilt-binary subpackages in parallel even though only one matches the host arch; on bandwidth-constrained sandboxes that blew through the 240s install budget. The official installer fetches one arch-specific binary and adds `$HOME/.opencode/bin` to PATH via `~/.bashrc`, which the sandbox-callback-bridge login-shell script already sources. - `packages/adapters/{claude,codex,gemini,opencode}-local/`: harden remote-target probes — pass `--skip-git-repo-check` for Codex when probing outside a repo, normalize permission flags for Claude, and add `*.remote.test.ts` coverage that exercises the remote-sandbox path explicitly for each adapter. - `packages/adapter-utils/src/sandbox-install-command.{ts,test.ts}` (new): add `buildSandboxNpmInstallCommand` helper. `server/src/adapters/registry.ts` + new `server/src/__tests__/adapter-registry.test.ts`: wire adapter install commands so they fall back to a writable `$HOME/.local` prefix when global install isn't available. - `server/src/__tests__/plugin-worker-manager.test.ts` + new `server/src/__tests__/fixtures/plugin-worker-delayed.cjs`: pin per-call timeout overrides so plugin worker exec calls honor the caller's timeout instead of the worker's default. ## Verification - `pnpm typecheck` - `pnpm exec vitest run --no-coverage packages/adapter-utils/src/execution-target-sandbox.test.ts packages/adapter-utils/src/sandbox-install-command.test.ts` - `pnpm exec vitest run --no-coverage server/src/__tests__/plugin-worker-manager.test.ts server/src/__tests__/adapter-registry.test.ts server/src/__tests__/claude-local-adapter-environment.test.ts server/src/__tests__/claude-local-execute.test.ts server/src/__tests__/gemini-local-adapter-environment.test.ts` - `pnpm exec vitest run --no-coverage packages/adapters/codex-local/src/server/test.remote.test.ts packages/adapters/opencode-local/src/server/test.remote.test.ts packages/adapters/codex-local/src/server/codex-args.test.ts packages/adapters/codex-local/src/server/execute.remote.test.ts packages/adapters/gemini-local/src/server/execute.remote.test.ts` All passing locally. ## Risks - Touches shared `adapter-utils` and several `*-local` adapters. The 30-minute default applies only when both (a) the target is `remote+sandbox` and (b) no `timeoutSec` is configured — local + SSH paths are unchanged. New test coverage was added alongside each behavior change to pin the contracts. - Switching OpenCode's install command to the official installer is a behavior change for any operator running OpenCode inside a remote sandbox. Local installs are unaffected (the `SANDBOX_INSTALL_COMMAND` only runs when an adapter is being installed inside a sandbox). - Low risk overall — no migrations, no API surface change. ## Model Used - Provider: Anthropic - Model: Claude Opus 4.7 (1M context) - Capabilities used: extended reasoning, tool use (Read/Edit/Bash/Grep), no code execution beyond local repo commands ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots — N/A, no UI change - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge Co-authored-by: Paperclip <noreply@paperclip.ing>
182 lines
5.5 KiB
TypeScript
182 lines
5.5 KiB
TypeScript
import path from "node:path";
|
|
import { fileURLToPath } from "node:url";
|
|
import { describe, expect, it, vi } from "vitest";
|
|
import type { PaperclipPluginManifestV1 } from "@paperclipai/shared";
|
|
import {
|
|
JsonRpcCallError,
|
|
type HostToWorkerMethods,
|
|
} from "@paperclipai/plugin-sdk";
|
|
import {
|
|
appendStderrExcerpt,
|
|
createPluginWorkerHandle,
|
|
formatWorkerFailureMessage,
|
|
} from "../services/plugin-worker-manager.js";
|
|
|
|
const FIXTURES_DIR = path.join(path.dirname(fileURLToPath(import.meta.url)), "fixtures");
|
|
const DELAYED_WORKER_ENTRYPOINT = path.join(FIXTURES_DIR, "plugin-worker-delayed.cjs");
|
|
const TERMINATED_WORKER_ENTRYPOINT = path.join(FIXTURES_DIR, "plugin-worker-terminated.cjs");
|
|
|
|
const TEST_MANIFEST: PaperclipPluginManifestV1 = {
|
|
id: "test.plugin",
|
|
apiVersion: 1,
|
|
version: "1.0.0",
|
|
displayName: "Test plugin",
|
|
description: "Test plugin",
|
|
author: "Paperclip",
|
|
categories: ["automation"],
|
|
capabilities: [],
|
|
entrypoints: { worker: "dist/worker.js" },
|
|
};
|
|
|
|
describe("plugin-worker-manager stderr failure context", () => {
|
|
it("appends worker stderr context to failure messages", () => {
|
|
expect(
|
|
formatWorkerFailureMessage(
|
|
"Worker process exited (code=1, signal=null)",
|
|
"TypeError: Unknown file extension \".ts\"",
|
|
),
|
|
).toBe(
|
|
"Worker process exited (code=1, signal=null)\n\nWorker stderr:\nTypeError: Unknown file extension \".ts\"",
|
|
);
|
|
});
|
|
|
|
it("does not duplicate stderr that is already present", () => {
|
|
const message = [
|
|
"Worker process exited (code=1, signal=null)",
|
|
"",
|
|
"Worker stderr:",
|
|
"TypeError: Unknown file extension \".ts\"",
|
|
].join("\n");
|
|
|
|
expect(
|
|
formatWorkerFailureMessage(message, "TypeError: Unknown file extension \".ts\""),
|
|
).toBe(message);
|
|
});
|
|
|
|
it("keeps only the latest stderr excerpt", () => {
|
|
let excerpt = "";
|
|
excerpt = appendStderrExcerpt(excerpt, "first line");
|
|
excerpt = appendStderrExcerpt(excerpt, "second line");
|
|
|
|
expect(excerpt).toContain("first line");
|
|
expect(excerpt).toContain("second line");
|
|
|
|
excerpt = appendStderrExcerpt(excerpt, "x".repeat(9_000));
|
|
|
|
expect(excerpt).not.toContain("first line");
|
|
expect(excerpt).not.toContain("second line");
|
|
expect(excerpt.length).toBeLessThanOrEqual(8_000);
|
|
});
|
|
|
|
it("times out environmentExecute calls using the handle default when no override is provided", async () => {
|
|
const handle = createPluginWorkerHandle("test.plugin", {
|
|
entrypointPath: DELAYED_WORKER_ENTRYPOINT,
|
|
manifest: TEST_MANIFEST,
|
|
config: {},
|
|
instanceInfo: {
|
|
instanceId: "instance-1",
|
|
hostVersion: "1.0.0",
|
|
},
|
|
apiVersion: 1,
|
|
hostHandlers: {},
|
|
rpcTimeoutMs: 10,
|
|
});
|
|
|
|
try {
|
|
await handle.start();
|
|
|
|
await expect(handle.call("environmentExecute", {
|
|
driverKey: "e2b",
|
|
companyId: "company-1",
|
|
environmentId: "environment-1",
|
|
config: {},
|
|
lease: { providerLeaseId: "lease-1" },
|
|
command: "echo",
|
|
delayMs: 50,
|
|
} as HostToWorkerMethods["environmentExecute"][0])).rejects.toMatchObject({
|
|
message: expect.stringContaining("timed out after 10ms"),
|
|
});
|
|
} finally {
|
|
await handle.stop().catch(() => undefined);
|
|
}
|
|
});
|
|
|
|
it("honors per-call timeout overrides for environmentExecute", async () => {
|
|
const handle = createPluginWorkerHandle("test.plugin", {
|
|
entrypointPath: DELAYED_WORKER_ENTRYPOINT,
|
|
manifest: TEST_MANIFEST,
|
|
config: {},
|
|
instanceInfo: {
|
|
instanceId: "instance-1",
|
|
hostVersion: "1.0.0",
|
|
},
|
|
apiVersion: 1,
|
|
hostHandlers: {},
|
|
rpcTimeoutMs: 10,
|
|
});
|
|
|
|
try {
|
|
await handle.start();
|
|
|
|
await expect(handle.call("environmentExecute", {
|
|
driverKey: "e2b",
|
|
companyId: "company-1",
|
|
environmentId: "environment-1",
|
|
config: {},
|
|
lease: { providerLeaseId: "lease-1" },
|
|
command: "echo",
|
|
delayMs: 50,
|
|
} as HostToWorkerMethods["environmentExecute"][0], 100)).resolves.toMatchObject({
|
|
exitCode: 0,
|
|
stdout: "ok\n",
|
|
});
|
|
} finally {
|
|
await handle.stop().catch(() => undefined);
|
|
}
|
|
});
|
|
|
|
it("does not emit an unhandled rejection when a plugin responds with terminated before callers attach handlers", async () => {
|
|
const unhandledRejection = vi.fn();
|
|
process.on("unhandledRejection", unhandledRejection);
|
|
|
|
const handle = createPluginWorkerHandle("test.plugin", {
|
|
entrypointPath: TERMINATED_WORKER_ENTRYPOINT,
|
|
manifest: TEST_MANIFEST,
|
|
config: {},
|
|
instanceInfo: {
|
|
instanceId: "instance-1",
|
|
hostVersion: "1.0.0",
|
|
},
|
|
apiVersion: 1,
|
|
hostHandlers: {},
|
|
});
|
|
|
|
try {
|
|
await handle.start();
|
|
|
|
const pendingCall = handle.call(
|
|
"environmentExecute" as keyof HostToWorkerMethods,
|
|
{
|
|
driverKey: "e2b",
|
|
companyId: "company-1",
|
|
environmentId: "environment-1",
|
|
config: {},
|
|
lease: { providerLeaseId: "lease-1" },
|
|
command: "echo",
|
|
} as HostToWorkerMethods[keyof HostToWorkerMethods][0],
|
|
);
|
|
|
|
await new Promise((resolve) => setImmediate(resolve));
|
|
|
|
await expect(pendingCall).rejects.toBeInstanceOf(JsonRpcCallError);
|
|
await expect(pendingCall).rejects.toMatchObject({
|
|
message: expect.stringContaining("terminated"),
|
|
});
|
|
expect(unhandledRejection).not.toHaveBeenCalled();
|
|
} finally {
|
|
process.off("unhandledRejection", unhandledRejection);
|
|
await handle.stop().catch(() => undefined);
|
|
}
|
|
});
|
|
});
|