forked from farhoodlabs/paperclip
f257530537
## Thinking Path > - Paperclip operators spend most of their time scanning the board, inbox, sidebar, and local dev status surfaces > - Small UI and dev-ops frictions make repeated operator workflows feel slower than they need to be > - The working branch contained several independent quality-of-life improvements mixed with larger cloud work > - Grouping these smaller UI/dev-ops changes together keeps review overhead reasonable without merging them into feature PRs > - This pull request collects the operator-facing QoL polish into one standalone branch > - The benefit is a cleaner board navigation and local dev recovery experience without depending on cloud upstream sync ## What Changed - Relaxed forced 44px touch targets for small inline widgets. - Fixed mobile mention menu scrolling and sidebar spacing on touch/mobile layouts. - Synced inbox hover state with j/k selection. - Moved plugin sidebar entries into the Work section. - Added manual dev-server restart action/banner behavior. - Logged plugin bridge 502 causes for better diagnosis. ## Verification - `pnpm install --frozen-lockfile --ignore-scripts` - `pnpm --filter @paperclipai/plugin-sdk build` - `pnpm exec vitest run ui/src/components/MarkdownEditor.test.tsx ui/src/components/Sidebar.test.tsx ui/src/components/SidebarProjects.test.tsx ui/src/pages/Inbox.test.tsx ui/src/components/DevRestartBanner.test.tsx server/src/__tests__/dev-server-status.test.ts server/src/__tests__/health-dev-server-token.test.ts server/src/__tests__/plugin-routes-authz.test.ts` initially failed only because plugin SDK `dist` was not built in the fresh worktree. - Rerun after build: `pnpm exec vitest run server/src/__tests__/plugin-routes-authz.test.ts` passed. - The remaining targeted UI/dev-server tests passed on the first post-install run. ## Visual Evidence - Sidebar layout and plugin Work section:  - Inbox/task row selection and hover-state surface:  - Dev restart banner desktop:  - Dev restart banner mobile:  ## Risks - Mostly UI/dev ergonomics with low data risk. - Sidebar and inbox changes touch frequently used navigation surfaces, so visual review on desktop/mobile is still useful. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5-based coding agent with local shell/git/tool use. Exact hosted model ID and context-window size are not exposed by the local Paperclip adapter runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
104 lines
3.4 KiB
TypeScript
104 lines
3.4 KiB
TypeScript
import { existsSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import { afterEach, describe, expect, it } from "vitest";
|
|
import {
|
|
getDevServerRestartRequestFilePath,
|
|
readPersistedDevServerStatus,
|
|
toDevServerHealthStatus,
|
|
writeDevServerRestartRequest,
|
|
} from "../dev-server-status.js";
|
|
|
|
const tempDirs = [];
|
|
|
|
function createTempStatusFile(payload: unknown) {
|
|
const dir = mkdtempSync(path.join(os.tmpdir(), "paperclip-dev-status-"));
|
|
tempDirs.push(dir);
|
|
const filePath = path.join(dir, "dev-server-status.json");
|
|
writeFileSync(filePath, `${JSON.stringify(payload)}\n`, "utf8");
|
|
return filePath;
|
|
}
|
|
|
|
afterEach(() => {
|
|
for (const dir of tempDirs.splice(0)) {
|
|
rmSync(dir, { recursive: true, force: true });
|
|
}
|
|
});
|
|
|
|
describe("dev server status helpers", () => {
|
|
it("reads and normalizes persisted supervisor state", () => {
|
|
const filePath = createTempStatusFile({
|
|
dirty: true,
|
|
lastChangedAt: "2026-03-20T12:00:00.000Z",
|
|
changedPathCount: 4,
|
|
changedPathsSample: ["server/src/app.ts", "packages/shared/src/index.ts"],
|
|
pendingMigrations: ["0040_restart_banner.sql"],
|
|
lastRestartAt: "2026-03-20T11:30:00.000Z",
|
|
});
|
|
|
|
expect(readPersistedDevServerStatus({ PAPERCLIP_DEV_SERVER_STATUS_FILE: filePath })).toEqual({
|
|
dirty: true,
|
|
lastChangedAt: "2026-03-20T12:00:00.000Z",
|
|
changedPathCount: 4,
|
|
changedPathsSample: ["server/src/app.ts", "packages/shared/src/index.ts"],
|
|
pendingMigrations: ["0040_restart_banner.sql"],
|
|
lastRestartAt: "2026-03-20T11:30:00.000Z",
|
|
});
|
|
});
|
|
|
|
it("derives waiting-for-idle health state", () => {
|
|
const health = toDevServerHealthStatus(
|
|
{
|
|
dirty: true,
|
|
lastChangedAt: "2026-03-20T12:00:00.000Z",
|
|
changedPathCount: 2,
|
|
changedPathsSample: ["server/src/app.ts"],
|
|
pendingMigrations: [],
|
|
lastRestartAt: "2026-03-20T11:30:00.000Z",
|
|
},
|
|
{ autoRestartEnabled: true, activeRunCount: 3 },
|
|
);
|
|
|
|
expect(health).toMatchObject({
|
|
enabled: true,
|
|
restartRequired: true,
|
|
reason: "backend_changes",
|
|
autoRestartEnabled: true,
|
|
activeRunCount: 3,
|
|
waitingForIdle: true,
|
|
});
|
|
});
|
|
|
|
it("ignores oversized persisted status files", () => {
|
|
const filePath = createTempStatusFile({
|
|
dirty: true,
|
|
changedPathsSample: ["x".repeat(70 * 1024)],
|
|
pendingMigrations: [],
|
|
});
|
|
|
|
expect(readPersistedDevServerStatus({ PAPERCLIP_DEV_SERVER_STATUS_FILE: filePath })).toBeNull();
|
|
});
|
|
|
|
it("writes restart requests next to the persisted status file", () => {
|
|
const filePath = createTempStatusFile({
|
|
dirty: true,
|
|
changedPathsSample: ["server/src/app.ts"],
|
|
pendingMigrations: [],
|
|
});
|
|
|
|
const env = { PAPERCLIP_DEV_SERVER_STATUS_FILE: filePath };
|
|
expect(writeDevServerRestartRequest({
|
|
requestedAt: "2026-03-20T12:05:00.000Z",
|
|
reason: "manual_restart_now",
|
|
}, env)).toBe(true);
|
|
|
|
const requestPath = getDevServerRestartRequestFilePath(env);
|
|
expect(requestPath).toBe(path.join(path.dirname(filePath), "dev-server-restart-request.json"));
|
|
expect(requestPath && existsSync(requestPath)).toBe(true);
|
|
expect(JSON.parse(readFileSync(requestPath!, "utf8"))).toEqual({
|
|
requestedAt: "2026-03-20T12:05:00.000Z",
|
|
reason: "manual_restart_now",
|
|
});
|
|
});
|
|
});
|