forked from farhoodlabs/paperclip
7f893ac4ec
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies > - Reliable execution depends on heartbeat routing, issue lifecycle semantics, telemetry, and a fast enough local verification loop to keep regressions visible > - The remaining commits on this branch were mostly server/runtime correctness fixes plus test and documentation follow-ups in that area > - Those changes are logically separate from the UI-focused issue-detail and workspace/navigation branches even when they touch overlapping issue APIs > - This pull request groups the execution reliability, heartbeat, telemetry, and tooling changes into one standalone branch > - The benefit is a focused review of the control-plane correctness work, including the follow-up fix that restored the implicit comment-reopen helpers after branch splitting ## What Changed - Hardened issue/heartbeat execution behavior, including self-review stage skipping, deferred mention wakes during active execution, stranded execution recovery, active-run scoping, assignee resolution, and blocked-to-todo wake resumption - Reduced noisy polling/logging overhead by trimming issue run payloads, compacting persisted run logs, silencing high-volume request logs, and capping heartbeat-run queries in dashboard/inbox surfaces - Expanded telemetry and status semantics with adapter/model fields on task completion plus clearer status guidance in docs/onboarding material - Updated test infrastructure and verification defaults with faster route-test module isolation, cheaper default `pnpm test`, e2e isolation from local state, and repo verification follow-ups - Included docs/release housekeeping from the branch and added a small follow-up commit restoring the implicit comment-reopen helpers that were dropped during branch reconstruction ## Verification - `pnpm vitest run server/src/__tests__/issue-comment-reopen-routes.test.ts server/src/__tests__/issue-telemetry-routes.test.ts` - `pnpm vitest run server/src/__tests__/http-log-policy.test.ts server/src/__tests__/heartbeat-run-log.test.ts server/src/__tests__/health.test.ts` - `server/src/__tests__/activity-service.test.ts`, `server/src/__tests__/heartbeat-comment-wake-batching.test.ts`, and `server/src/__tests__/heartbeat-process-recovery.test.ts` were attempted on this host but the embedded Postgres harness reported init-script/data-dir problems and skipped or failed to start, so they are noted as environment-limited ## Risks - Medium: this branch changes core issue/heartbeat routing and reopen/wakeup behavior, so regressions would affect agent execution flow rather than isolated UI polish - Because it also updates verification infrastructure, reviewers should pay attention to whether the new tests are asserting the right failure modes and not just reshaping harness behavior ## Model Used - OpenAI Codex coding agent (GPT-5-class runtime in Codex CLI; exact deployed model ID is not exposed in this environment), reasoning enabled, tool use and local code execution enabled ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [ ] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
213 lines
6.4 KiB
TypeScript
213 lines
6.4 KiB
TypeScript
import express from "express";
|
|
import request from "supertest";
|
|
import { beforeEach, describe, expect, it, vi } from "vitest";
|
|
|
|
const issueId = "11111111-1111-4111-8111-111111111111";
|
|
const companyId = "22222222-2222-4222-8222-222222222222";
|
|
|
|
const mockIssueService = vi.hoisted(() => ({
|
|
getById: vi.fn(),
|
|
}));
|
|
|
|
const mockDocumentsService = vi.hoisted(() => ({
|
|
listIssueDocumentRevisions: vi.fn(),
|
|
restoreIssueDocumentRevision: vi.fn(),
|
|
}));
|
|
|
|
const mockAccessService = vi.hoisted(() => ({
|
|
canUser: vi.fn(),
|
|
hasPermission: vi.fn(),
|
|
}));
|
|
|
|
const mockAgentService = vi.hoisted(() => ({
|
|
getById: vi.fn(),
|
|
}));
|
|
|
|
const mockLogActivity = vi.hoisted(() => vi.fn(async () => undefined));
|
|
|
|
vi.mock("../services/index.js", () => ({
|
|
accessService: () => mockAccessService,
|
|
agentService: () => mockAgentService,
|
|
documentService: () => mockDocumentsService,
|
|
executionWorkspaceService: () => ({}),
|
|
feedbackService: () => ({}),
|
|
goalService: () => ({}),
|
|
heartbeatService: () => ({
|
|
wakeup: vi.fn(async () => undefined),
|
|
reportRunActivity: vi.fn(async () => undefined),
|
|
}),
|
|
instanceSettingsService: () => ({
|
|
getExperimental: vi.fn(async () => ({})),
|
|
getGeneral: vi.fn(async () => ({ feedbackDataSharingPreference: "prompt" })),
|
|
}),
|
|
issueApprovalService: () => ({}),
|
|
issueService: () => mockIssueService,
|
|
logActivity: mockLogActivity,
|
|
projectService: () => ({}),
|
|
routineService: () => ({
|
|
syncRunStatusForIssue: vi.fn(async () => undefined),
|
|
}),
|
|
workProductService: () => ({}),
|
|
}));
|
|
|
|
function registerModuleMocks() {
|
|
vi.doMock("../services/index.js", () => ({
|
|
accessService: () => mockAccessService,
|
|
agentService: () => mockAgentService,
|
|
documentService: () => mockDocumentsService,
|
|
executionWorkspaceService: () => ({}),
|
|
feedbackService: () => ({}),
|
|
goalService: () => ({}),
|
|
heartbeatService: () => ({
|
|
wakeup: vi.fn(async () => undefined),
|
|
reportRunActivity: vi.fn(async () => undefined),
|
|
}),
|
|
instanceSettingsService: () => ({
|
|
getExperimental: vi.fn(async () => ({})),
|
|
getGeneral: vi.fn(async () => ({ feedbackDataSharingPreference: "prompt" })),
|
|
}),
|
|
issueApprovalService: () => ({}),
|
|
issueService: () => mockIssueService,
|
|
logActivity: mockLogActivity,
|
|
projectService: () => ({}),
|
|
routineService: () => ({
|
|
syncRunStatusForIssue: vi.fn(async () => undefined),
|
|
}),
|
|
workProductService: () => ({}),
|
|
}));
|
|
}
|
|
|
|
async function createApp() {
|
|
const [{ issueRoutes }, { errorHandler }] = await Promise.all([
|
|
vi.importActual<typeof import("../routes/issues.js")>("../routes/issues.js"),
|
|
vi.importActual<typeof import("../middleware/index.js")>("../middleware/index.js"),
|
|
]);
|
|
const app = express();
|
|
app.use(express.json());
|
|
app.use((req, _res, next) => {
|
|
(req as any).actor = {
|
|
type: "board",
|
|
userId: "board-user",
|
|
companyIds: [companyId],
|
|
source: "local_implicit",
|
|
isInstanceAdmin: false,
|
|
};
|
|
next();
|
|
});
|
|
app.use("/api", issueRoutes({} as any, {} as any));
|
|
app.use(errorHandler);
|
|
return app;
|
|
}
|
|
|
|
describe("issue document revision routes", () => {
|
|
beforeEach(() => {
|
|
vi.resetModules();
|
|
vi.doUnmock("../services/routines.js");
|
|
vi.doUnmock("../routes/issues.js");
|
|
vi.doUnmock("../middleware/index.js");
|
|
registerModuleMocks();
|
|
vi.resetAllMocks();
|
|
mockIssueService.getById.mockResolvedValue({
|
|
id: issueId,
|
|
companyId,
|
|
identifier: "PAP-881",
|
|
title: "Document revisions",
|
|
status: "in_progress",
|
|
});
|
|
mockDocumentsService.listIssueDocumentRevisions.mockResolvedValue([
|
|
{
|
|
id: "revision-2",
|
|
companyId,
|
|
documentId: "document-1",
|
|
issueId,
|
|
key: "plan",
|
|
revisionNumber: 2,
|
|
title: "Plan v2",
|
|
format: "markdown",
|
|
body: "# Two",
|
|
changeSummary: null,
|
|
createdByAgentId: null,
|
|
createdByUserId: "board-user",
|
|
createdAt: new Date("2026-03-26T12:00:00.000Z"),
|
|
},
|
|
]);
|
|
mockDocumentsService.restoreIssueDocumentRevision.mockResolvedValue({
|
|
restoredFromRevisionId: "revision-1",
|
|
restoredFromRevisionNumber: 1,
|
|
document: {
|
|
id: "document-1",
|
|
companyId,
|
|
issueId,
|
|
key: "plan",
|
|
title: "Plan v1",
|
|
format: "markdown",
|
|
body: "# One",
|
|
latestRevisionId: "revision-3",
|
|
latestRevisionNumber: 3,
|
|
createdByAgentId: null,
|
|
createdByUserId: "board-user",
|
|
updatedByAgentId: null,
|
|
updatedByUserId: "board-user",
|
|
createdAt: new Date("2026-03-26T12:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-26T12:10:00.000Z"),
|
|
},
|
|
});
|
|
mockLogActivity.mockResolvedValue(undefined);
|
|
});
|
|
|
|
it("returns revision snapshots including title and format", async () => {
|
|
const res = await request(await createApp()).get(`/api/issues/${issueId}/documents/plan/revisions`);
|
|
|
|
expect(res.status).toBe(200);
|
|
expect(res.body).toEqual([
|
|
expect.objectContaining({
|
|
revisionNumber: 2,
|
|
title: "Plan v2",
|
|
format: "markdown",
|
|
body: "# Two",
|
|
}),
|
|
]);
|
|
});
|
|
|
|
it("restores a revision through the append-only route and logs the action", async () => {
|
|
const res = await request(await createApp())
|
|
.post(`/api/issues/${issueId}/documents/plan/revisions/revision-1/restore`)
|
|
.send({});
|
|
|
|
expect(res.status).toBe(200);
|
|
expect(mockDocumentsService.restoreIssueDocumentRevision).toHaveBeenCalledWith({
|
|
issueId,
|
|
key: "plan",
|
|
revisionId: "revision-1",
|
|
createdByAgentId: null,
|
|
createdByUserId: "board-user",
|
|
});
|
|
expect(mockLogActivity).toHaveBeenCalledWith(
|
|
expect.anything(),
|
|
expect.objectContaining({
|
|
action: "issue.document_restored",
|
|
details: expect.objectContaining({
|
|
key: "plan",
|
|
restoredFromRevisionId: "revision-1",
|
|
restoredFromRevisionNumber: 1,
|
|
revisionNumber: 3,
|
|
}),
|
|
}),
|
|
);
|
|
expect(res.body).toEqual(expect.objectContaining({
|
|
key: "plan",
|
|
title: "Plan v1",
|
|
latestRevisionNumber: 3,
|
|
}));
|
|
});
|
|
|
|
it("rejects invalid document keys before attempting restore", async () => {
|
|
const res = await request(await createApp())
|
|
.post(`/api/issues/${issueId}/documents/INVALID KEY/revisions/revision-1/restore`)
|
|
.send({});
|
|
|
|
expect(res.status).toBe(400);
|
|
expect(mockDocumentsService.restoreIssueDocumentRevision).not.toHaveBeenCalled();
|
|
});
|
|
});
|