From 44f30ec03f2409baa78abfb91aec1f50c574cf60 Mon Sep 17 00:00:00 2001
From: DevContainer User <devcontainer@example.com>
Date: Sun, 22 Feb 2026 12:59:16 +0000
Subject: [PATCH] fix: standardize secret key names to SCREAMING_SNAKE_CASE
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Fixes inconsistent variable naming across the codebase by standardizing
all secret keys to use SCREAMING_SNAKE_CASE format.

**Changes:**
- homeassistant-url → HOMEASSISTANT_URL
- homeassistant-token → HOMEASSISTANT_TOKEN
- database-uri → DATABASE_URI
- pgtuner-exclude-userids → PGTUNER_EXCLUDE_USERIDS
- github-token → GITHUB_TOKEN

**Files updated:**
- chart/templates/deployment.yaml - Fixed secret key references
- README.md - Updated documentation and examples

**Result:**
All secret keys now follow the established SCREAMING_SNAKE_CASE
convention (GITHUB_TOKEN, VNC_PASSWORD, SSH_AUTHORIZED_KEYS, etc.)
for consistency and clarity.

Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)

Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
---
 README.md                       | 14 +++++++-------
 chart/templates/deployment.yaml | 10 +++++-----
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/README.md b/README.md
index 8568c2e..c65187b 100644
--- a/README.md
+++ b/README.md
@@ -22,10 +22,10 @@ The secret is picked up automatically via `envFrom`. Keys recognised:
 | `VNC_PASSWORD` | Password for the VNC web UI |
 | `ANTHROPIC_API_KEY` | API key — alternative to browser-based Claude login |
 | `SSH_AUTHORIZED_KEYS` | Public key(s) for SSH access (required when `ssh: true`) |
-| `homeassistant-url` | Home Assistant URL (required when `mcpSidecars.homeassistant.enabled: true`) |
-| `homeassistant-token` | Home Assistant long-lived access token (required when `mcpSidecars.homeassistant.enabled: true`) |
-| `database-uri` | PostgreSQL connection string (required when `mcpSidecars.pgtuner.enabled: true`) |
-| `pgtuner-exclude-userids` | Comma-separated PostgreSQL user OIDs to exclude from monitoring (optional) |
+| `HOMEASSISTANT_URL` | Home Assistant URL (required when `mcpSidecars.homeassistant.enabled: true`) |
+| `HOMEASSISTANT_TOKEN` | Home Assistant long-lived access token (required when `mcpSidecars.homeassistant.enabled: true`) |
+| `DATABASE_URI` | PostgreSQL connection string (required when `mcpSidecars.pgtuner.enabled: true`) |
+| `PGTUNER_EXCLUDE_USERIDS` | Comma-separated PostgreSQL user OIDs to exclude from monitoring (optional) |
 
 ```bash
 kubectl create secret generic devcontainer-mydev-secrets-env \
@@ -196,8 +196,8 @@ helm install mydev ./chart \
 # Create secret with Home Assistant credentials
 kubectl create secret generic devcontainer-mydev-secrets-env \
   --from-literal=GITHUB_TOKEN='ghp_...' \
-  --from-literal=homeassistant-url='http://homeassistant.local:8123' \
-  --from-literal=homeassistant-token='your_long_lived_access_token'
+  --from-literal=HOMEASSISTANT_URL='http://homeassistant.local:8123' \
+  --from-literal=HOMEASSISTANT_TOKEN='your_long_lived_access_token'
 
 # Deploy with Home Assistant MCP enabled
 helm install mydev ./chart \
@@ -211,7 +211,7 @@ helm install mydev ./chart \
 # Create secret with PostgreSQL connection string
 kubectl create secret generic devcontainer-mydev-secrets-env \
   --from-literal=GITHUB_TOKEN='ghp_...' \
-  --from-literal=database-uri='postgresql://user:password@postgres.example.com:5432/dbname'
+  --from-literal=DATABASE_URI='postgresql://user:password@postgres.example.com:5432/dbname'
 
 # Deploy with PostgreSQL tuner MCP enabled
 helm install mydev ./chart \
diff --git a/chart/templates/deployment.yaml b/chart/templates/deployment.yaml
index 81ce13d..916348e 100644
--- a/chart/templates/deployment.yaml
+++ b/chart/templates/deployment.yaml
@@ -179,13 +179,13 @@ spec:
               valueFrom:
                 secretKeyRef:
                   name: {{ include "antigravity.envSecretName" . }}
-                  key: homeassistant-url
+                  key: HOMEASSISTANT_URL
                   optional: true
             - name: HOMEASSISTANT_TOKEN
               valueFrom:
                 secretKeyRef:
                   name: {{ include "antigravity.envSecretName" . }}
-                  key: homeassistant-token
+                  key: HOMEASSISTANT_TOKEN
                   optional: true
           livenessProbe:
             tcpSocket:
@@ -215,7 +215,7 @@ spec:
               valueFrom:
                 secretKeyRef:
                   name: {{ include "antigravity.envSecretName" . }}
-                  key: github-token
+                  key: GITHUB_TOKEN
                   optional: true
           livenessProbe:
             httpGet:
@@ -245,13 +245,13 @@ spec:
               valueFrom:
                 secretKeyRef:
                   name: {{ include "antigravity.envSecretName" . }}
-                  key: database-uri
+                  key: DATABASE_URI
                   optional: true
             - name: PGTUNER_EXCLUDE_USERIDS
               valueFrom:
                 secretKeyRef:
                   name: {{ include "antigravity.envSecretName" . }}
-                  key: pgtuner-exclude-userids
+                  key: PGTUNER_EXCLUDE_USERIDS
                   optional: true
           livenessProbe:
             tcpSocket: