farhoodlabs/devcontainer
8
0
Fork 0
Code Issues 10 Pull Requests Actions Packages Projects Releases 39 Wiki Activity

fix(chart): add missing MCP sidecars to values schema #47

Merged
cpfarhood merged 1 commits from fix/schema-new-mcp-sidecars into main 2026-02-23 23:57:41 +00:00
Conversation 0 Commits 1 Files Changed 1
+12 -1
cpfarhood commented 2026-02-23 23:55:11 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

PR #45 added fetch and sequentialthinking MCP sidecars to values.yaml and deployment.yaml but missed updating values.schema.json. Since the schema has additionalProperties: false on mcp.sidecars, all Helm upgrades to v0.4.6+ fail with:

- mcp.sidecars: Additional property sequentialthinking is not allowed
- mcp.sidecars: Additional property fetch is not allowed

Changes

  • Add fetch and sequentialthinking to allowed mcp.sidecars properties
  • Add resourceProfile to the top-level schema (was also missing)

Test plan

  • Merge and release as v0.4.8
  • Verify HelmRelease upgrade succeeds
  • Verify crush and opencode are available in the container

🤖 Generated with Claude Code

## Summary PR #45 added `fetch` and `sequentialthinking` MCP sidecars to `values.yaml` and `deployment.yaml` but missed updating `values.schema.json`. Since the schema has `additionalProperties: false` on `mcp.sidecars`, all Helm upgrades to v0.4.6+ fail with: ``` - mcp.sidecars: Additional property sequentialthinking is not allowed - mcp.sidecars: Additional property fetch is not allowed ``` ### Changes - Add `fetch` and `sequentialthinking` to allowed `mcp.sidecars` properties - Add `resourceProfile` to the top-level schema (was also missing) ## Test plan - [ ] Merge and release as v0.4.8 - [ ] Verify HelmRelease upgrade succeeds - [ ] Verify crush and opencode are available in the container 🤖 Generated with [Claude Code](https://claude.ai/code)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
antigravity
architecture
automation
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 examples
good first issue
Good for newcomers
 helm
help wanted
Extra attention is needed
 invalid
This doesn't seem right
 maintainability
monitoring
question
Further information is requested
 refactor
tooling
user-experience
validation
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
fl_blake (Blake MIddleware) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) flux (Flux CD) admin (Gitea Admin) fl_hugh (Hugh Commit) renovate (Mend Renovate) fl_warren (Warren Bufferpool)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: farhoodlabs/devcontainer#47
Delete Branch "fix/schema-new-mcp-sidecars"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?