farhoodlabs/paperclip-adapter-claude-k8s
8
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: skip all structured streaming events in buildPartialRunError (FAR-32 followup)

Browse Source 
Extends the previous fix (which only covered assistant/user) to skip every
JSON object with a non-empty "type" field — system, assistant, user,
rate_limit_event, result, and any future event types.  This prevents all
structured protocol artefacts from being surfaced verbatim as error messages.

Root cause of the new repro: when Claude emits a rate_limit_event before
producing output and then exits without a result event, the rate_limit_event
JSON blob was becoming the "first content line" and appearing in the error:

  Claude exited with code -1: {"type":"rate_limit_event","rate_limit_info":{...}}

With this fix, all typed events are filtered and the initOnlyOutput branch
fires, producing the clean diagnostic:

  Claude started but did not produce a result (model: claude-opus-4-7)
  — check API credentials, model support, and adapter config

Updated the "result event as content" test to match the new (correct) behaviour:
in production buildPartialRunError is only called when parseClaudeStreamJson
returns null (no result event), so the prior test was exercising a degenerate
state that cannot occur through execute().

Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
Chris Farhood
2026-04-24 17:17:48 +00:00
committed by Blake Middleware [agent]
parent f9ff04a354
commit cabdc3df98
2 changed files with 36 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/server/execute.ts
+10 -9
View File
@@ -117,11 +117,12 @@ export function buildPartialRunError(
): string {
if (exitCode === 0) return "Failed to parse Claude JSON output";
// Walk stdout lines, skip system and intermediate streaming events, return
// the first human-readable content line. assistant/user events are
// intermediate and contain raw JSON blobs that make poor error messages;
// result events are retained because they may carry useful error details
// (e.g. rate-limit messages).
// Walk stdout lines and skip every structured streaming event (any JSON
// object that carries a non-empty "type" field: system, assistant, user,
// rate_limit_event, result, …). All of these are protocol artefacts and
// produce confusing raw-JSON blobs when surfaced verbatim as an error
// message. Only plain-text lines (non-JSON, or JSON without a type field)
// are treated as human-readable content worth including in the error.
const firstContentLine = stdout.split(/\r?\n/)
.map((l) => l.trim())
.find((l) => {
@@ -130,7 +131,7 @@ export function buildPartialRunError(
const obj = JSON.parse(l);
if (typeof obj === "object" && obj !== null) {
const t = (obj as Record<string, unknown>).type;
if (t === "system" || t === "assistant" || t === "user") return false;
if (typeof t === "string" && t) return false;
}
} catch {
// not JSON — treat as content
@@ -138,9 +139,9 @@ export function buildPartialRunError(
return true;
}) ?? "";
// If the stream contains only system/init and intermediate events with no
// plain-text or result output, surface the model name so the operator can
// diagnose missing credentials or unsupported model.
// If the stream contained only structured events with no plain-text output,
// surface the model name so the operator can diagnose missing credentials
// or unsupported/misconfigured model.
const initOnlyOutput = stdout.trim() !== "" && model !== "" && !firstContentLine;
if (initOnlyOutput) {
const modelHint = model ? ` (model: ${model})` : "";