fix(plugin): guard kubernetes upload edge cases

This commit is contained in:
Dotta
2026-05-13 14:47:48 -05:00
committed by Chris Farhood
parent f8b8303089
commit 1eccb71213
4 changed files with 44 additions and 2 deletions
@@ -2,6 +2,7 @@ import { describe, it, expect } from "vitest";
import plugin, {
buildSandboxExecCommand,
buildSandboxExecShellCommand,
deriveUploadTargetDir,
extractAdapterEnvFromProcess,
} from "../../src/plugin.js";
@@ -179,4 +180,10 @@ describe("plugin", () => {
}),
).toEqual(["/bin/sh", "-lc", "pnpm test -- --runInBand"]);
});
it("derives upload target directories for root and nested paths", () => {
expect(deriveUploadTargetDir("/file")).toBe("/");
expect(deriveUploadTargetDir("/workspace/file")).toBe("/workspace");
expect(deriveUploadTargetDir("relative-file")).toBe(".");
});
});
@@ -62,6 +62,27 @@ describe("FastUploadInterceptor", () => {
expect(interceptor.pendingCount).toBe(1);
});
it("fails fast when data arrives after a padded chunk", () => {
const interceptor = new FastUploadInterceptor();
const target = "/workspace/file.bin";
expect(
interceptor.decide(
`mkdir -p '/workspace' && rm -f '${target}.paperclip-upload.b64' && : > '${target}.paperclip-upload.b64'`,
),
).toMatchObject({ action: "ack" });
expect(
interceptor.decide(`printf '%s' 'aGVs=' >> '${target}.paperclip-upload.b64'`),
).toMatchObject({ action: "ack" });
const decision = interceptor.decide(`printf '%s' 'bG8=' >> '${target}.paperclip-upload.b64'`);
expect(decision).toMatchObject({
action: "error",
message: expect.stringContaining("received data after a padded chunk"),
});
expect(interceptor.pendingCount).toBe(0);
});
it("falls through when the init command does not match the target parent directory", () => {
const interceptor = new FastUploadInterceptor();