From 6844226572161a4ea267bfb026b509b88cc66dd5 Mon Sep 17 00:00:00 2001 From: Dotta Date: Sun, 12 Apr 2026 21:30:50 -0500 Subject: [PATCH] Address Greptile navigation review --- ui/src/components/IssueLinkQuicklook.tsx | 9 +++++++-- ui/src/lib/issueDetailCache.ts | 2 +- ui/src/lib/router.tsx | 4 +--- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/ui/src/components/IssueLinkQuicklook.tsx b/ui/src/components/IssueLinkQuicklook.tsx index 089b236f..b6311eff 100644 --- a/ui/src/components/IssueLinkQuicklook.tsx +++ b/ui/src/components/IssueLinkQuicklook.tsx @@ -5,7 +5,12 @@ import type { Issue } from "@paperclipai/shared"; import { useQuery, useQueryClient } from "@tanstack/react-query"; import { timeAgo } from "@/lib/timeAgo"; import { createIssueDetailPath, withIssueDetailHeaderSeed } from "@/lib/issueDetailBreadcrumb"; -import { fetchIssueDetail, getCachedIssueDetail, prefetchIssueDetail } from "@/lib/issueDetailCache"; +import { + fetchIssueDetail, + getCachedIssueDetail, + ISSUE_DETAIL_STALE_TIME_MS, + prefetchIssueDetail, +} from "@/lib/issueDetailCache"; import { queryKeys } from "@/lib/queryKeys"; import { cn } from "@/lib/utils"; import { Popover, PopoverContent, PopoverTrigger } from "@/components/ui/popover"; @@ -99,7 +104,7 @@ export const IssueLinkQuicklook = React.forwardRef< queryFn: () => fetchIssueDetail(queryClient, issuePathId), enabled: open, initialData: () => cachedIssue, - staleTime: 60_000, + staleTime: ISSUE_DETAIL_STALE_TIME_MS, }); const detailPath = createIssueDetailPath(issuePathId); diff --git a/ui/src/lib/issueDetailCache.ts b/ui/src/lib/issueDetailCache.ts index b4fab727..8e02e46e 100644 --- a/ui/src/lib/issueDetailCache.ts +++ b/ui/src/lib/issueDetailCache.ts @@ -4,7 +4,7 @@ import { issuesApi } from "@/api/issues"; import { queryKeys } from "@/lib/queryKeys"; const ISSUE_DETAIL_QUERY_PREFIX = ["issues", "detail"] as const; -const ISSUE_DETAIL_STALE_TIME_MS = 60_000; +export const ISSUE_DETAIL_STALE_TIME_MS = 60_000; function isNonEmptyString(value: unknown): value is string { return typeof value === "string" && value.length > 0; diff --git a/ui/src/lib/router.tsx b/ui/src/lib/router.tsx index c1660277..c8d3a352 100644 --- a/ui/src/lib/router.tsx +++ b/ui/src/lib/router.tsx @@ -57,9 +57,7 @@ export const Link = React.forwardRef( function CompanyLink({ to, disableIssueQuicklook = false, issuePrefetch = null, ...props }, ref) { const companyPrefix = useActiveCompanyPrefix(); const resolvedTo = resolveTo(to, companyPrefix); - const issuePathId = disableIssueQuicklook - ? parseIssuePathIdFromPath(typeof resolvedTo === "string" ? resolvedTo : resolvedTo.pathname) - : parseIssuePathIdFromPath(typeof resolvedTo === "string" ? resolvedTo : resolvedTo.pathname); + const issuePathId = parseIssuePathIdFromPath(typeof resolvedTo === "string" ? resolvedTo : resolvedTo.pathname); if (issuePathId) { return (