1991ec9d6f
## Thinking Path > - Paperclip is the control plane for autonomous AI companies, so backend task ownership, recovery, review visibility, and company-scoped limits need to stay enforceable without UI-only coupling. > - Closed PR #4692 bundled those backend changes with UI workflow, docs, skills, workflow, and lockfile churn. > - PAP-2694 asks for a clean backend/control-plane slice from that closed branch. > - This branch starts from current `master` and mines only the `cli`, `packages/db`, `packages/shared`, and `server` contracts/tests needed for the backend behavior. > - It explicitly excludes UI workflow/performance work, `.github/workflows/pr.yml`, `pnpm-lock.yaml`, docs, skills, package-script, adapter UI build-config, and perf fixture script changes; the only UI files are fixture/test updates required by the tightened shared `Company` contract. > - The benefit is a smaller reviewable PR that preserves the control-plane fixes while staying under Greptile s 100-file review limit. ## What Changed - Added company-scoped attachment-size limits through DB schema/migrations, shared company portability contracts, CLI import/export coverage, and server attachment upload enforcement. - Added productivity review service/API behavior for no-comment streak, long-active, and high-churn review issues, including request-depth clamping and issue summary exposure. - Hardened issue ownership and recovery/control-plane paths: peer-agent mutation denial, issue tree pause/resume behavior, stranded recovery origins, and related activity/test coverage. - Preserved related backend contract updates for routine timestamp variables and managed agent instruction bundles because they live in shared/server contracts from the source branch. - Addressed Greptile feedback by making `Company.attachmentMaxBytes` non-optional, simplifying review request-depth clamping, fixing the migration final newline, and enforcing the process-level attachment cap as the final ceiling for uploads. - Added minimal company fixtures needed for repo-wide typecheck/build and kept the PR to 66 changed files with forbidden/non-slice paths excluded. ## Verification - `pnpm install --frozen-lockfile` - `git diff --check origin/master..HEAD` - `git diff --name-only origin/master..HEAD | wc -l` -> 66 files - `git diff --name-only origin/master..HEAD -- .github/workflows/pr.yml pnpm-lock.yaml package.json doc skills .agents scripts packages/adapters` -> no output - `pnpm exec vitest run --config vitest.config.ts packages/shared/src/validators/issue.test.ts packages/shared/src/routine-variables.test.ts packages/shared/src/adapter-types.test.ts cli/src/__tests__/company-import-export-e2e.test.ts cli/src/__tests__/company.test.ts server/src/__tests__/productivity-review-service.test.ts server/src/__tests__/issue-tree-control-service.test.ts server/src/__tests__/issue-tree-control-routes.test.ts server/src/__tests__/issue-agent-mutation-ownership-routes.test.ts server/src/__tests__/issue-attachment-routes.test.ts server/src/__tests__/heartbeat-process-recovery.test.ts server/src/__tests__/issues-service.test.ts` -> 12 files, 147 tests passed - `pnpm exec vitest run --config vitest.config.ts cli/src/__tests__/company-delete.test.ts cli/src/__tests__/company-import-export-e2e.test.ts server/src/__tests__/productivity-review-service.test.ts` -> 3 files, 18 tests passed - `pnpm exec vitest run --config vitest.config.ts server/src/__tests__/issue-attachment-routes.test.ts` -> 1 file, 6 tests passed - `pnpm --filter @paperclipai/db typecheck && pnpm --filter @paperclipai/shared typecheck && pnpm --filter @paperclipai/server typecheck && pnpm --filter paperclipai typecheck` - `pnpm --filter @paperclipai/server typecheck` - `pnpm --filter @paperclipai/ui typecheck && pnpm --filter @paperclipai/ui build` ## Risks - Includes migrations `0073_shiny_salo.sql` and `0074_striped_genesis.sql`; merge ordering matters if another PR adds migrations first. - This is intentionally backend-only apart from fixture/test updates forced by shared type correctness; UI affordances from PR #4692 are not present here and should land in separate UI slices. - The worktree install emitted plugin SDK bin-link warnings for unbuilt plugin packages, but the targeted tests and package typechecks completed successfully. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected; check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5 coding agent, tool-enabled terminal/GitHub workflow. Exact runtime context window was not exposed by the harness. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
246 lines
8.5 KiB
TypeScript
246 lines
8.5 KiB
TypeScript
import { z } from "zod";
|
|
import { MAX_COMPANY_ATTACHMENT_MAX_BYTES } from "../constants.js";
|
|
import { routineVariableSchema } from "./routine.js";
|
|
|
|
export const portabilityIncludeSchema = z
|
|
.object({
|
|
company: z.boolean().optional(),
|
|
agents: z.boolean().optional(),
|
|
projects: z.boolean().optional(),
|
|
issues: z.boolean().optional(),
|
|
skills: z.boolean().optional(),
|
|
})
|
|
.partial();
|
|
|
|
export const portabilityEnvInputSchema = z.object({
|
|
key: z.string().min(1),
|
|
description: z.string().nullable(),
|
|
agentSlug: z.string().min(1).nullable(),
|
|
projectSlug: z.string().min(1).nullable(),
|
|
kind: z.enum(["secret", "plain"]),
|
|
requirement: z.enum(["required", "optional"]),
|
|
defaultValue: z.string().nullable(),
|
|
portability: z.enum(["portable", "system_dependent"]),
|
|
});
|
|
|
|
export const portabilityFileEntrySchema = z.union([
|
|
z.string(),
|
|
z.object({
|
|
encoding: z.literal("base64"),
|
|
data: z.string(),
|
|
contentType: z.string().min(1).optional().nullable(),
|
|
}),
|
|
]);
|
|
|
|
export const portabilityCompanyManifestEntrySchema = z.object({
|
|
path: z.string().min(1),
|
|
name: z.string().min(1),
|
|
description: z.string().nullable(),
|
|
brandColor: z.string().nullable(),
|
|
logoPath: z.string().nullable(),
|
|
attachmentMaxBytes: z.number().int().min(1).max(MAX_COMPANY_ATTACHMENT_MAX_BYTES).nullable().default(null),
|
|
requireBoardApprovalForNewAgents: z.boolean(),
|
|
feedbackDataSharingEnabled: z.boolean().default(false),
|
|
feedbackDataSharingConsentAt: z.string().datetime().nullable().default(null),
|
|
feedbackDataSharingConsentByUserId: z.string().nullable().default(null),
|
|
feedbackDataSharingTermsVersion: z.string().nullable().default(null),
|
|
});
|
|
|
|
export const portabilitySidebarOrderSchema = z.object({
|
|
agents: z.array(z.string().min(1)).default([]),
|
|
projects: z.array(z.string().min(1)).default([]),
|
|
});
|
|
|
|
export const portabilityAgentManifestEntrySchema = z.object({
|
|
slug: z.string().min(1),
|
|
name: z.string().min(1),
|
|
path: z.string().min(1),
|
|
skills: z.array(z.string().min(1)).default([]),
|
|
role: z.string().min(1),
|
|
title: z.string().nullable(),
|
|
icon: z.string().nullable(),
|
|
capabilities: z.string().nullable(),
|
|
reportsToSlug: z.string().min(1).nullable(),
|
|
adapterType: z.string().min(1),
|
|
adapterConfig: z.record(z.unknown()),
|
|
runtimeConfig: z.record(z.unknown()),
|
|
permissions: z.record(z.unknown()),
|
|
budgetMonthlyCents: z.number().int().nonnegative(),
|
|
metadata: z.record(z.unknown()).nullable(),
|
|
});
|
|
|
|
export const portabilitySkillManifestEntrySchema = z.object({
|
|
key: z.string().min(1),
|
|
slug: z.string().min(1),
|
|
name: z.string().min(1),
|
|
path: z.string().min(1),
|
|
description: z.string().nullable(),
|
|
sourceType: z.string().min(1),
|
|
sourceLocator: z.string().nullable(),
|
|
sourceRef: z.string().nullable(),
|
|
trustLevel: z.string().nullable(),
|
|
compatibility: z.string().nullable(),
|
|
metadata: z.record(z.unknown()).nullable(),
|
|
fileInventory: z.array(z.object({
|
|
path: z.string().min(1),
|
|
kind: z.string().min(1),
|
|
})).default([]),
|
|
});
|
|
|
|
export const portabilityProjectManifestEntrySchema = z.object({
|
|
slug: z.string().min(1),
|
|
name: z.string().min(1),
|
|
path: z.string().min(1),
|
|
description: z.string().nullable(),
|
|
ownerAgentSlug: z.string().min(1).nullable(),
|
|
leadAgentSlug: z.string().min(1).nullable(),
|
|
targetDate: z.string().nullable(),
|
|
color: z.string().nullable(),
|
|
status: z.string().nullable(),
|
|
executionWorkspacePolicy: z.record(z.unknown()).nullable(),
|
|
workspaces: z.array(z.object({
|
|
key: z.string().min(1),
|
|
name: z.string().min(1),
|
|
sourceType: z.string().nullable(),
|
|
repoUrl: z.string().nullable(),
|
|
repoRef: z.string().nullable(),
|
|
defaultRef: z.string().nullable(),
|
|
visibility: z.string().nullable(),
|
|
setupCommand: z.string().nullable(),
|
|
cleanupCommand: z.string().nullable(),
|
|
metadata: z.record(z.unknown()).nullable(),
|
|
isPrimary: z.boolean(),
|
|
})).default([]),
|
|
metadata: z.record(z.unknown()).nullable(),
|
|
});
|
|
|
|
export const portabilityIssueRoutineTriggerManifestEntrySchema = z.object({
|
|
kind: z.string().min(1),
|
|
label: z.string().nullable(),
|
|
enabled: z.boolean(),
|
|
cronExpression: z.string().nullable(),
|
|
timezone: z.string().nullable(),
|
|
signingMode: z.string().nullable(),
|
|
replayWindowSec: z.number().int().nullable(),
|
|
});
|
|
|
|
export const portabilityIssueRoutineManifestEntrySchema = z.object({
|
|
concurrencyPolicy: z.string().nullable(),
|
|
catchUpPolicy: z.string().nullable(),
|
|
variables: z.array(routineVariableSchema).nullable().optional(),
|
|
triggers: z.array(portabilityIssueRoutineTriggerManifestEntrySchema).default([]),
|
|
});
|
|
|
|
export const portabilityIssueManifestEntrySchema = z.object({
|
|
slug: z.string().min(1),
|
|
identifier: z.string().min(1).nullable(),
|
|
title: z.string().min(1),
|
|
path: z.string().min(1),
|
|
projectSlug: z.string().min(1).nullable(),
|
|
projectWorkspaceKey: z.string().min(1).nullable(),
|
|
assigneeAgentSlug: z.string().min(1).nullable(),
|
|
description: z.string().nullable(),
|
|
recurring: z.boolean().default(false),
|
|
routine: portabilityIssueRoutineManifestEntrySchema.nullable(),
|
|
legacyRecurrence: z.record(z.unknown()).nullable(),
|
|
status: z.string().nullable(),
|
|
priority: z.string().nullable(),
|
|
labelIds: z.array(z.string().min(1)).default([]),
|
|
billingCode: z.string().nullable(),
|
|
executionWorkspaceSettings: z.record(z.unknown()).nullable(),
|
|
assigneeAdapterOverrides: z.record(z.unknown()).nullable(),
|
|
metadata: z.record(z.unknown()).nullable(),
|
|
});
|
|
|
|
export const portabilityManifestSchema = z.object({
|
|
schemaVersion: z.number().int().positive(),
|
|
generatedAt: z.string().datetime(),
|
|
source: z
|
|
.object({
|
|
companyId: z.string().uuid(),
|
|
companyName: z.string().min(1),
|
|
})
|
|
.nullable(),
|
|
includes: z.object({
|
|
company: z.boolean(),
|
|
agents: z.boolean(),
|
|
projects: z.boolean(),
|
|
issues: z.boolean(),
|
|
skills: z.boolean(),
|
|
}),
|
|
company: portabilityCompanyManifestEntrySchema.nullable(),
|
|
sidebar: portabilitySidebarOrderSchema.nullable(),
|
|
agents: z.array(portabilityAgentManifestEntrySchema),
|
|
skills: z.array(portabilitySkillManifestEntrySchema).default([]),
|
|
projects: z.array(portabilityProjectManifestEntrySchema).default([]),
|
|
issues: z.array(portabilityIssueManifestEntrySchema).default([]),
|
|
envInputs: z.array(portabilityEnvInputSchema).default([]),
|
|
});
|
|
|
|
export const portabilitySourceSchema = z.discriminatedUnion("type", [
|
|
z.object({
|
|
type: z.literal("inline"),
|
|
rootPath: z.string().min(1).optional().nullable(),
|
|
files: z.record(portabilityFileEntrySchema),
|
|
}),
|
|
z.object({
|
|
type: z.literal("github"),
|
|
url: z.string().url(),
|
|
}),
|
|
]);
|
|
|
|
export const portabilityTargetSchema = z.discriminatedUnion("mode", [
|
|
z.object({
|
|
mode: z.literal("new_company"),
|
|
newCompanyName: z.string().min(1).optional().nullable(),
|
|
}),
|
|
z.object({
|
|
mode: z.literal("existing_company"),
|
|
companyId: z.string().uuid(),
|
|
}),
|
|
]);
|
|
|
|
export const portabilityAgentSelectionSchema = z.union([
|
|
z.literal("all"),
|
|
z.array(z.string().min(1)),
|
|
]);
|
|
|
|
export const portabilityCollisionStrategySchema = z.enum(["rename", "skip", "replace"]);
|
|
|
|
export const companyPortabilityExportSchema = z.object({
|
|
include: portabilityIncludeSchema.optional(),
|
|
agents: z.array(z.string().min(1)).optional(),
|
|
skills: z.array(z.string().min(1)).optional(),
|
|
projects: z.array(z.string().min(1)).optional(),
|
|
issues: z.array(z.string().min(1)).optional(),
|
|
projectIssues: z.array(z.string().min(1)).optional(),
|
|
selectedFiles: z.array(z.string().min(1)).optional(),
|
|
expandReferencedSkills: z.boolean().optional(),
|
|
sidebarOrder: portabilitySidebarOrderSchema.partial().optional(),
|
|
});
|
|
|
|
export type CompanyPortabilityExport = z.infer<typeof companyPortabilityExportSchema>;
|
|
|
|
export const companyPortabilityPreviewSchema = z.object({
|
|
source: portabilitySourceSchema,
|
|
include: portabilityIncludeSchema.optional(),
|
|
target: portabilityTargetSchema,
|
|
agents: portabilityAgentSelectionSchema.optional(),
|
|
collisionStrategy: portabilityCollisionStrategySchema.optional(),
|
|
nameOverrides: z.record(z.string().min(1), z.string().min(1)).optional(),
|
|
selectedFiles: z.array(z.string().min(1)).optional(),
|
|
});
|
|
|
|
export type CompanyPortabilityPreview = z.infer<typeof companyPortabilityPreviewSchema>;
|
|
|
|
export const portabilityAdapterOverrideSchema = z.object({
|
|
adapterType: z.string().min(1),
|
|
adapterConfig: z.record(z.unknown()).optional(),
|
|
});
|
|
|
|
export const companyPortabilityImportSchema = companyPortabilityPreviewSchema.extend({
|
|
adapterOverrides: z.record(z.string().min(1), portabilityAdapterOverrideSchema).optional(),
|
|
});
|
|
|
|
export type CompanyPortabilityImport = z.infer<typeof companyPortabilityImportSchema>;
|