2d72292ad6
## Thinking Path > - Paperclip orchestrates AI agents through reusable execution workspaces and routines > - Operators need a fast way to run workspace-aware routines against a specific execution workspace > - The existing workspace detail surface showed configuration, runtime logs, and linked issues, but not routines that depend on workspace variables > - Routine runs also needed to prefill the selected execution workspace so branch variables resolve correctly > - This pull request adds a workspace routines tab and prefilled routine-run dialog support > - The benefit is a tighter workflow for rerunning reviews, smoke checks, and other workspace-specific routines ## What Changed - Added an execution workspace `Routines` tab and company-prefixed routes. - Listed routines that declare or reference workspace-specific variables. - Added `Run now` support that preselects the current execution workspace in `RoutineRunVariablesDialog`. - Centralized reusable execution workspace ordering/deduplication for issue creation and workspace cards. - Added focused UI helper and dialog regression tests. ## Verification - `pnpm exec vitest run ui/src/lib/reusable-execution-workspaces.test.ts ui/src/lib/workspace-routines.test.ts ui/src/components/RoutineRunVariablesDialog.test.tsx ui/src/lib/company-routes.test.ts` - Screenshots were not captured in this PR split; the visible flow is covered by focused component/helper tests and should get browser QA in the follow-up issue. ## Risks - Medium risk: this adds a new workspace detail tab and routine-run path. It is isolated to workspace-scoped routines and uses existing routine run APIs. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5 coding agent, tool use and local command execution. Exact context window was not exposed in the runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
83 lines
2.8 KiB
TypeScript
83 lines
2.8 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import { orderReusableExecutionWorkspaces, type ReusableExecutionWorkspaceLike } from "./reusable-execution-workspaces";
|
|
|
|
function workspace(overrides: Partial<ReusableExecutionWorkspaceLike>): ReusableExecutionWorkspaceLike {
|
|
return {
|
|
id: overrides.id ?? "workspace-id",
|
|
name: overrides.name ?? "Workspace",
|
|
cwd: overrides.cwd ?? null,
|
|
lastUsedAt: overrides.lastUsedAt ?? "2026-01-01T00:00:00.000Z",
|
|
};
|
|
}
|
|
|
|
describe("orderReusableExecutionWorkspaces", () => {
|
|
it("puts the most recently used workspace first and sorts the rest alphabetically", () => {
|
|
const workspaces = [
|
|
workspace({ id: "charlie", name: "Charlie", lastUsedAt: "2026-01-03T00:00:00.000Z" }),
|
|
workspace({ id: "zulu", name: "Zulu", lastUsedAt: "2026-01-05T00:00:00.000Z" }),
|
|
workspace({ id: "alpha", name: "Alpha", lastUsedAt: "2026-01-01T00:00:00.000Z" }),
|
|
workspace({ id: "bravo", name: "Bravo", lastUsedAt: "2026-01-04T00:00:00.000Z" }),
|
|
];
|
|
|
|
expect(orderReusableExecutionWorkspaces(workspaces).map((item) => item.id)).toEqual([
|
|
"zulu",
|
|
"alpha",
|
|
"bravo",
|
|
"charlie",
|
|
]);
|
|
});
|
|
|
|
it("keeps only the latest used workspace for duplicate paths before sorting", () => {
|
|
const workspaces = [
|
|
workspace({
|
|
id: "older-duplicate",
|
|
name: "Older duplicate",
|
|
cwd: "/tmp/shared",
|
|
lastUsedAt: "2026-01-01T00:00:00.000Z",
|
|
}),
|
|
workspace({ id: "beta", name: "Beta", cwd: "/tmp/beta", lastUsedAt: "2026-01-02T00:00:00.000Z" }),
|
|
workspace({
|
|
id: "newer-duplicate",
|
|
name: "Newer duplicate",
|
|
cwd: "/tmp/shared",
|
|
lastUsedAt: "2026-01-04T00:00:00.000Z",
|
|
}),
|
|
workspace({ id: "alpha", name: "Alpha", cwd: "/tmp/alpha", lastUsedAt: "2026-01-03T00:00:00.000Z" }),
|
|
];
|
|
|
|
expect(orderReusableExecutionWorkspaces(workspaces).map((item) => item.id)).toEqual([
|
|
"newer-duplicate",
|
|
"alpha",
|
|
"beta",
|
|
]);
|
|
});
|
|
|
|
it("does not let updatedAt churn outrank the last used workspace", () => {
|
|
type WorkspaceWithUpdatedAt = ReusableExecutionWorkspaceLike & { updatedAt: Date | string };
|
|
const workspaces: WorkspaceWithUpdatedAt[] = [
|
|
{
|
|
...workspace({
|
|
id: "recently-used",
|
|
name: "Recently used",
|
|
cwd: "/tmp/shared",
|
|
lastUsedAt: "2026-01-04T00:00:00.000Z",
|
|
}),
|
|
updatedAt: "2026-01-01T00:00:00.000Z",
|
|
},
|
|
{
|
|
...workspace({
|
|
id: "recently-updated",
|
|
name: "Recently updated",
|
|
cwd: "/tmp/shared",
|
|
lastUsedAt: "2026-01-01T00:00:00.000Z",
|
|
}),
|
|
updatedAt: "2026-01-05T00:00:00.000Z",
|
|
},
|
|
];
|
|
|
|
expect(orderReusableExecutionWorkspaces(workspaces).map((item) => item.id)).toEqual([
|
|
"recently-used",
|
|
]);
|
|
});
|
|
});
|