38c185fb8b
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies by keeping task ownership, approvals, and operator control inside one control plane. > - Agent permissions and plugin-hosted company settings sit on the boundary between autonomy and governance. > - V1 needs scoped task assignment rules, plugin extension points, and clearer company access surfaces without weakening company boundaries. > - The branch builds the core authorization service, plugin SDK/host APIs, and UI simplifications needed to support those controls. > - Paperclip EE plugin surfaces were intentionally moved out of this core PR per review direction, so this PR now carries only the public core/plugin infrastructure work. > - The latest updates preserve the PAP-9937 branch changes that belong in this PR, remove the `design/` artifacts, and exclude the experimental `plugin-briefs` package. > - Greptile feedback was applied through the authorization/audit paths and the final cleanup commit was re-reviewed at 5/5 with no unresolved Greptile threads. > - The benefit is safer assignment control with extension hooks for richer permission products while preserving simple defaults for normal operators. ## What Changed - Added scoped task-assignment authorization decisions and routed issue/agent assignment mutations through the authorization service. - Added plugin SDK and host APIs for company settings slots, authorization policy/grant management, assignment previews, and bridge invocation scope propagation. - Simplified core company access UI and moved advanced controls behind plugin-provided settings surfaces. - Added retry-now affordances for blocked issue next-step notices. - Added protected-assignment enforcement for persisted agent/project/issue policies, including explicit-grant fallback behavior. - Added incremental principal-access compatibility backfill for active agent memberships and role-default human permission grants. - Added the Markdown code block wrap action fix from the latest branch changes. - Removed `design/` artifacts from the PR and removed `packages/plugins/plugin-briefs` from the final diff. - Addressed Greptile feedback for plugin actor sanitization, legacy membership handling, audit pagination, unknown grant-scope metadata, and startup test mocks. ## Verification - `pnpm exec vitest run server/src/__tests__/access-service.test.ts server/src/__tests__/company-portability.test.ts` -> 2 files passed, 54 tests passed. - `pnpm exec vitest run server/src/__tests__/server-startup-feedback-export.test.ts server/src/__tests__/access-service.test.ts server/src/__tests__/company-portability.test.ts` -> 3 files passed, 62 tests passed. - `pnpm exec vitest run server/src/__tests__/authorization-service.test.ts server/src/__tests__/plugin-access-authorization-host-services.test.ts server/src/__tests__/server-startup-feedback-export.test.ts` -> 3 files passed, 28 tests passed. - `pnpm --filter @paperclipai/server typecheck` -> passed. - `git diff --check` -> passed. - `node ./scripts/check-docker-deps-stage.mjs` -> passed. - `CI=true pnpm install --frozen-lockfile --ignore-scripts` -> passed with no lockfile update. - `pnpm exec vitest run ui/src/components/MarkdownBody.interaction.test.tsx` -> 1 test passed. - `git ls-files design packages/plugins/plugin-briefs | wc -l` -> 0. - GitHub CI on `40cd83b53` -> all checks passed, merge state `CLEAN`. - Greptile on `40cd83b53` -> 5/5, 102 files reviewed, 0 comments/annotations added, 0 unresolved review threads. - Confirmed the PR diff contains no `design/`, `packages/plugins/plugin-briefs`, `pnpm-lock.yaml`, or `.github/workflows` changes. ## Risks - Medium: task assignment authorization paths are behaviorally stricter for protected/private policy data, so existing plugin-authored policies may block assignment until explicit grants or approval flows are configured. - Medium: plugin-host authorization APIs expand the surface area available to trusted plugins and need careful review for company scoping. - Low: startup now performs a principal-access compatibility backfill, but the migration and runtime backfill use conflict-tolerant inserts. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5 coding agent, tool-enabled workflow with shell, git, and GitHub CLI access. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
269 lines
8.3 KiB
TypeScript
269 lines
8.3 KiB
TypeScript
// @vitest-environment jsdom
|
|
|
|
import { act } from "react";
|
|
import { createRoot } from "react-dom/client";
|
|
import type { AnchorHTMLAttributes, ReactElement, ReactNode } from "react";
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
|
|
import { MemoryRouter } from "react-router-dom";
|
|
import type { IssueRetryNowOutcome, IssueScheduledRetry } from "@paperclipai/shared";
|
|
import { IssueBlockedNotice } from "./IssueBlockedNotice";
|
|
import { ToastProvider } from "../context/ToastContext";
|
|
|
|
const retryNowMock = vi.hoisted(() => vi.fn());
|
|
|
|
vi.mock("@/lib/router", () => ({
|
|
Link: ({ children, to, ...props }: AnchorHTMLAttributes<HTMLAnchorElement> & { to: string }) => (
|
|
<a href={to} {...props}>{children}</a>
|
|
),
|
|
}));
|
|
|
|
vi.mock("../api/issues", () => ({
|
|
issuesApi: {
|
|
retryScheduledRetryNow: retryNowMock,
|
|
},
|
|
}));
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
(globalThis as any).IS_REACT_ACT_ENVIRONMENT = true;
|
|
|
|
let root: ReturnType<typeof createRoot> | null = null;
|
|
let container: HTMLDivElement | null = null;
|
|
let dateNowSpy: ReturnType<typeof vi.spyOn> | null = null;
|
|
|
|
const SYSTEM_NOW = new Date("2026-04-18T20:00:00.000Z").getTime();
|
|
|
|
const baseRetry: IssueScheduledRetry = {
|
|
runId: "retry-run-1",
|
|
status: "scheduled_retry",
|
|
agentId: "agent-1",
|
|
agentName: "CodexCoder",
|
|
retryOfRunId: "source-run-1",
|
|
scheduledRetryAt: "2026-04-19T20:00:00.000Z",
|
|
scheduledRetryAttempt: 1,
|
|
scheduledRetryReason: "max_turns_continuation",
|
|
retryExhaustedReason: null,
|
|
error: null,
|
|
errorCode: null,
|
|
};
|
|
|
|
function buildRetryResponse(outcome: IssueRetryNowOutcome) {
|
|
return {
|
|
outcome,
|
|
message:
|
|
outcome === "promoted"
|
|
? "Promoted scheduled retry"
|
|
: outcome === "already_promoted"
|
|
? "Scheduled retry already promoted"
|
|
: outcome === "no_scheduled_retry"
|
|
? "No scheduled retry"
|
|
: "Promotion suppressed by gate",
|
|
scheduledRetry:
|
|
outcome === "promoted" || outcome === "already_promoted"
|
|
? { ...baseRetry, status: "queued" as const }
|
|
: null,
|
|
};
|
|
}
|
|
|
|
beforeEach(() => {
|
|
dateNowSpy = vi.spyOn(Date, "now").mockReturnValue(SYSTEM_NOW);
|
|
retryNowMock.mockReset();
|
|
});
|
|
|
|
afterEach(() => {
|
|
if (root) {
|
|
act(() => root?.unmount());
|
|
}
|
|
root = null;
|
|
container?.remove();
|
|
container = null;
|
|
dateNowSpy?.mockRestore();
|
|
dateNowSpy = null;
|
|
});
|
|
|
|
function withProviders(node: ReactNode) {
|
|
const client = new QueryClient({
|
|
defaultOptions: {
|
|
queries: { retry: false, gcTime: 0, staleTime: 0 },
|
|
mutations: { retry: false },
|
|
},
|
|
});
|
|
return (
|
|
<MemoryRouter>
|
|
<QueryClientProvider client={client}>
|
|
<ToastProvider>{node}</ToastProvider>
|
|
</QueryClientProvider>
|
|
</MemoryRouter>
|
|
);
|
|
}
|
|
|
|
function render(element: ReactElement) {
|
|
container = document.createElement("div");
|
|
document.body.appendChild(container);
|
|
root = createRoot(container);
|
|
act(() => root?.render(withProviders(element)));
|
|
return container;
|
|
}
|
|
|
|
describe("IssueBlockedNotice", () => {
|
|
it("renders a successful-run next-step notice without requiring blockers", () => {
|
|
const node = render(
|
|
<IssueBlockedNotice
|
|
issueStatus="in_progress"
|
|
blockers={[]}
|
|
agentName="CodexCoder"
|
|
successfulRunHandoff={{
|
|
state: "required",
|
|
required: true,
|
|
sourceRunId: "12345678-aaaa-bbbb-cccc-123456789abc",
|
|
correctiveRunId: null,
|
|
assigneeAgentId: "agent-1",
|
|
detectedProgressSummary: "Updated the plan and left follow-up work.",
|
|
createdAt: "2026-05-01T00:00:00.000Z",
|
|
}}
|
|
/>,
|
|
);
|
|
|
|
expect(node.textContent).toContain("This issue still needs a next step.");
|
|
expect(node.textContent).toContain("Corrective wake queued for CodexCoder");
|
|
expect(node.textContent).toContain("Detected progress: Updated the plan");
|
|
expect(node.textContent).not.toContain("Retry now");
|
|
expect(node.textContent).not.toContain("Work on this issue is blocked until");
|
|
expect(node.querySelector('[data-successful-run-handoff="required"]')).not.toBeNull();
|
|
});
|
|
|
|
it("shows retry-now action for next-step notices with a scheduled retry", async () => {
|
|
retryNowMock.mockResolvedValue(buildRetryResponse("promoted"));
|
|
const node = render(
|
|
<IssueBlockedNotice
|
|
issueId="issue-1"
|
|
issueStatus="in_progress"
|
|
blockers={[]}
|
|
agentName="CodexCoder"
|
|
scheduledRetry={baseRetry}
|
|
successfulRunHandoff={{
|
|
state: "required",
|
|
required: true,
|
|
sourceRunId: "12345678-aaaa-bbbb-cccc-123456789abc",
|
|
correctiveRunId: null,
|
|
assigneeAgentId: "agent-1",
|
|
detectedProgressSummary: null,
|
|
createdAt: "2026-05-01T00:00:00.000Z",
|
|
}}
|
|
/>,
|
|
);
|
|
|
|
expect(node.textContent).toContain("Corrective wake scheduled in 1d");
|
|
const button = node.querySelector<HTMLButtonElement>('[data-testid="issue-next-step-retry-now"]');
|
|
expect(button).not.toBeNull();
|
|
expect(button!.textContent ?? "").toContain("Retry now");
|
|
|
|
await act(async () => {
|
|
button!.click();
|
|
await Promise.resolve();
|
|
});
|
|
|
|
await vi.waitFor(() => {
|
|
expect(retryNowMock).toHaveBeenCalledWith("issue-1");
|
|
expect(button!.textContent ?? "").toContain("Promoted");
|
|
expect(button!.disabled).toBe(true);
|
|
});
|
|
});
|
|
|
|
it("does not render when the issue is done even if a stale handoff state is required", () => {
|
|
const node = render(
|
|
<IssueBlockedNotice
|
|
issueStatus="done"
|
|
blockers={[]}
|
|
agentName="CodexCoder"
|
|
successfulRunHandoff={{
|
|
state: "required",
|
|
required: true,
|
|
sourceRunId: "12345678-aaaa-bbbb-cccc-123456789abc",
|
|
correctiveRunId: null,
|
|
assigneeAgentId: "agent-1",
|
|
detectedProgressSummary: "Updated the plan and left follow-up work.",
|
|
createdAt: "2026-05-01T00:00:00.000Z",
|
|
}}
|
|
/>,
|
|
);
|
|
|
|
expect(node.textContent).toBe("");
|
|
});
|
|
|
|
it("does not render when the issue is cancelled even if blockers remain", () => {
|
|
const node = render(
|
|
<IssueBlockedNotice
|
|
issueStatus="cancelled"
|
|
blockers={[
|
|
{
|
|
id: "blocker-1",
|
|
identifier: "PAP-123",
|
|
title: "Blocker",
|
|
status: "in_progress",
|
|
priority: "medium",
|
|
assigneeAgentId: null,
|
|
assigneeUserId: null,
|
|
},
|
|
]}
|
|
/>,
|
|
);
|
|
|
|
expect(node.textContent).toBe("");
|
|
});
|
|
|
|
it("renders a recovery indicator on a blocker chip when the blocker has an active recovery action", () => {
|
|
const node = render(
|
|
<IssueBlockedNotice
|
|
issueStatus="blocked"
|
|
blockers={[
|
|
{
|
|
id: "blocker-1",
|
|
identifier: "PAP-123",
|
|
title: "Build still red",
|
|
status: "in_progress",
|
|
priority: "medium",
|
|
assigneeAgentId: null,
|
|
assigneeUserId: null,
|
|
activeRecoveryAction: {
|
|
id: "rec-1",
|
|
companyId: "co-1",
|
|
sourceIssueId: "blocker-1",
|
|
recoveryIssueId: null,
|
|
kind: "missing_disposition",
|
|
status: "active",
|
|
ownerType: "agent",
|
|
ownerAgentId: "agent-cto",
|
|
ownerUserId: null,
|
|
previousOwnerAgentId: null,
|
|
returnOwnerAgentId: null,
|
|
cause: "successful_run_missing_state",
|
|
fingerprint: "fp-1",
|
|
evidence: {},
|
|
nextAction: "choose disposition",
|
|
wakePolicy: { type: "wake_owner" },
|
|
monitorPolicy: null,
|
|
attemptCount: 1,
|
|
maxAttempts: 3,
|
|
timeoutAt: null,
|
|
lastAttemptAt: null,
|
|
outcome: null,
|
|
resolutionNote: null,
|
|
resolvedAt: null,
|
|
createdAt: "2026-05-01T00:00:00.000Z",
|
|
updatedAt: "2026-05-01T00:00:00.000Z",
|
|
},
|
|
},
|
|
]}
|
|
/>,
|
|
);
|
|
|
|
const indicator = node.querySelector(
|
|
'[data-testid="issue-blocked-notice-recovery-indicator"]',
|
|
);
|
|
expect(indicator).not.toBeNull();
|
|
expect(indicator?.getAttribute("data-recovery-state")).toBe("needed");
|
|
expect(indicator?.textContent).toContain("Recovery needed");
|
|
});
|
|
});
|